[16.0][MIG] stock_report_quantity_by_location: Migration to version 16.0 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 96.3% (26 of 27 strings) Translation: stock-logistics-reporting-12.0/stock-logistics-reporting-12.0-stock_report_quantity_by_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-12-0/stock-logistics-reporting-12-0-stock_report_quantity_by_location/es_MX/
- Add an option in the wizard 'Quantity > 0' to speed up the report
…ilability. New field 'availability' in the wizard, allowing you to report on quantities on hand, or quantities unreserved (on hand - reservations).
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-13.0/stock-logistics-reporting-13.0-stock_report_quantity_by_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-13-0/stock-logistics-reporting-13-0-stock_report_quantity_by_location/
Currently translated at 100.0% (35 of 35 strings) Translation: stock-logistics-reporting-15.0/stock-logistics-reporting-15.0-stock_report_quantity_by_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-15-0/stock-logistics-reporting-15-0-stock_report_quantity_by_location/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-15.0/stock-logistics-reporting-15.0-stock_report_quantity_by_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-15-0/stock-logistics-reporting-15-0-stock_report_quantity_by_location/
|
/ocabot migration stock_report_quantity_by_location |
hugo-cordoba
force-pushed
the
16.0-mig-stock_report_quantity_by_location
branch
from
4d43985
to
3a8a586
Compare
RodrigoBM
suggested changes
Nov 27, 2023
| class TestStockReportQuantityByLocation(TransactionCase): | ||
| @classmethod | ||
| def setUpClass(cls): | ||
| super(TestStockReportQuantityByLocation, cls).setUpClass() |
There was a problem hiding this comment.
Apply PEP 3135 (28-Apr-2007) to "super()."
| qty_on_hand = qty_dict.get("quantity_on_hand", 0.0) | ||
| qty_reserved = qty_dict.get("quantity_reserved", 0.0) | ||
| qty_unreserved = qty_dict.get("quantity_unreserved", 0.0) | ||
| if (self.with_quantity and qty_on_hand) or not self.with_quantity: |
There was a problem hiding this comment.
this would not be the same as this:
Suggested change
| if (self.with_quantity and qty_on_hand) or not self.with_quantity: | |
| if not self.with_quantity or qty_on_hand: |
| } | ||
| ) | ||
| recs = self.env["stock.report.quantity.by.location"].create(vals_list) | ||
| return recs.ids |
There was a problem hiding this comment.
this method does not need to return anything, you can remove recs.
RodrigoBM
suggested changes
Nov 27, 2023
| "default_code": product.default_code, | ||
| } | ||
| ) | ||
| recs = self.env["stock.report.quantity.by.location"].create(vals_list) |
There was a problem hiding this comment.
can do this operation only once, moving it out of the for.
hugo-cordoba
force-pushed
the
16.0-mig-stock_report_quantity_by_location
branch
from
3a8a586
to
30c3e4b
Compare
|
Hi @RodrigoBM, changes done, thanks! 👍🏼 |
rousseldenis
approved these changes
Nov 28, 2023
RodrigoBM
suggested changes
Nov 28, 2023
| } | ||
| mapping.setdefault(quant_group["product_id"][0], qty_dict) | ||
| products = self.env["product.product"].search([("type", "=", "product")]) | ||
| vals_list = [] |
There was a problem hiding this comment.
this variable has to be outside the for, if not, only records from the last iteration of location_ids will be created.
hugo-cordoba
force-pushed
the
16.0-mig-stock_report_quantity_by_location
branch
from
30c3e4b
to
b1766c6
Compare
RodrigoBM
approved these changes
Nov 28, 2023
|
Hi @pedrobaeza, how are you? Could you check the mr and merge it? Thanks! |
|
Merging based on the reviews and due to @rousseldenis as Logistics PSC approval /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at d4db922. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[16.0][MIG] stock_report_quantity_by_location