[16.0][FIX] stock_picking_report_valued: Use original qty done column from … #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilioPascual
changed the title
rafaelbn
approved these changes
Apr 19, 2024
yajo
approved these changes
Apr 19, 2024
| @@ -94,36 +88,18 @@ | |||
| inherit_id="stock.stock_report_delivery_has_serial_move_line" | |||
| > | |||
| <xpath expr="//td[@name='move_line_lot_qty_done']" position="after"> | |||
There was a problem hiding this comment.
suggestion: if possible, it's better to add a name attribute to the th above and find the corresponding position here in the tbody using this trick. Otherwise, other modules that extend the same report could put some column in the middle and break the layout.
There was a problem hiding this comment.
Cool trick! I save it for the future. Thanks.
Now I fix with name for this case.
…Odoo I don't understand why it is necessary to hide the original qty done column. This makes other modules that modify the qty done column not work. @moduon MT-5825
EmilioPascual
force-pushed
the
16.0-fix_stock_picking_report_valued
branch
from
68c12ae
to
8868129
Compare
yajo
approved these changes
Apr 19, 2024
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 94ce82f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand why it is necessary to hide the original qty done column. This makes other modules that inherit the qty done column not work.
@Shide @yajo please review.
@moduon MT-5825