Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] stock_picking_report_header_repeater: New module to repeat the header in all pages of the delivery report #320

Merged
merged 1 commit into from
Jun 5, 2024
Merged

[16.0][ADD] stock_picking_report_header_repeater: New module to repeat the header in all pages of the delivery report #320

merged 1 commit into from
Jun 5, 2024

Conversation

CarlosRoca13
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 changed the title [16.0][ADD] stock_picking_report_header_repeater: New module to repeat the header in all pages [16.0][ADD] stock_picking_report_header_repeater: New module to repeat the header in all pages of the delivery report May 29, 2024
@CarlosRoca13 CarlosRoca13 force-pushed the 16.0-ADD-stock_picking_report_header_repeater branch 4 times, most recently from 42f8a23 to 74274c2 Compare May 29, 2024 09:11
@EmilioPascual
Copy link
Contributor

Why change the report?
In odoo core the addresses appear at the beginning.
image

But in your report the address is shown below the shipping date.
image

@rafaelbn rafaelbn added this to the 16.0 milestone Jun 3, 2024
Shide
Shide suggested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report header has been changed without reason

Delivery Slip - Azure Interior - WH_OUT_00014 (2).pdf

@pilarvargas-tecnativa
Copy link
Contributor

image
The functionality of repeating the header on all sheets is correct for me.
Please check the tests.
Thanks!

@CarlosRoca13 CarlosRoca13 force-pushed the 16.0-ADD-stock_picking_report_header_repeater branch from 74274c2 to 4d96c7f Compare June 5, 2024 10:21
@CarlosRoca13
Copy link
Contributor Author

Changes done!

@CarlosRoca13 CarlosRoca13 force-pushed the 16.0-ADD-stock_picking_report_header_repeater branch from 4d96c7f to 3e32cf0 Compare June 5, 2024 10:26
@CarlosRoca13
Copy link
Contributor Author

image

Here is the result

pilarvargas-tecnativa
pilarvargas-tecnativa approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-320-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 58997e4 into OCA:16.0 Jun 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d450b81. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-ADD-stock_picking_report_header_repeater branch June 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shide Shide Shide approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@pilarvargas-tecnativa pilarvargas-tecnativa pilarvargas-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@CarlosRoca13 @EmilioPascual @pilarvargas-tecnativa @OCA-git-bot @pedrobaeza @Shide @sergio-teruel @rafaelbn