Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] [16.0] stock_picking_report_delivery_driver #321

Merged

Conversation

Shide
Copy link
Contributor

@Shide Shide commented May 29, 2024

Adds Delivery Driver to Stock Picking reports

Delivery Slip report

image

Picking Operations report

image

Delivery Slip without Carrier but Driver

image

MT-6115 @moduon @rafaelbn @yajo @EmilioPascual @fcvalgar please review if you want :)

Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

LGTM, Thank you @Shide

image

Picking Operations
image

Delivery Slip
image

Only driver
image

Only Carrier
image

Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job @Shide. Just a single change

@Shide Shide force-pushed the 16.0-stock_picking_report_delivery_driver branch from 65480cd to 4b2a74a Compare May 31, 2024 09:40
@Shide Shide requested review from EmilioPascual and yajo May 31, 2024 09:40
@rafaelbn rafaelbn added this to the 16.0 milestone Jun 2, 2024
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Thank you!

@rafaelbn
Copy link
Member

rafaelbn commented Jun 2, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-321-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 2, 2024
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-321-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rafaelbn
Copy link
Member

rafaelbn commented Jun 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-321-by-rafaelbn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 2, 2024
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-321-by-rafaelbn-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rafaelbn
Copy link
Member

rafaelbn commented Jun 2, 2024

Hello @Shide ! :-)

Test are failing, this is the message:


2024-06-02 20:58:05,334 288 ERROR odoo odoo.addons.stock_average_daily_sale.tests.test_average_daily_sale: FAIL: TestAverageSale.test_average_sale
Traceback (most recent call last):
  File "/__w/stock-logistics-reporting/stock-logistics-reporting/stock_average_daily_sale/tests/test_average_daily_sale.py", line 52, in test_average_sale
    self.assertRecordValues(
  File "/opt/odoo/odoo/tests/common.py", line 610, in assertRecordValues
    self.fail('\n'.join(errors))
AssertionError: The records and expected_values do not match.
Wrong number of records to compare: 0 records versus 1 expected values.

==== Missing record ====
{'average_qty_by_sale': 10.0,
 'nbr_sales': 1.0,
 'qty_in_stock': 40.0,
 'recommended_qty': 20.0,
 'warehouse_id': 1}
 
2024-06-02 20:58:05,337 288 INFO odoo odoo.addons.stock_average_daily_sale.tests.test_average_daily_sale: Starting TestAverageSale.test_average_sale_multiple ... 
2024-06-02 20:58:05,631 288 INFO odoo odoo.addons.stock_average_daily_sale.tests.test_average_daily_sale: ====================================================================== 
2024-06-02 20:58:05,631 288 ERROR odoo odoo.addons.stock_average_daily_sale.tests.test_average_daily_sale: FAIL: TestAverageSale.test_average_sale_multiple
Traceback (most recent call last):
  File "/__w/stock-logistics-reporting/stock-logistics-reporting/stock_average_daily_sale/tests/test_average_daily_sale.py", line 129, in test_average_sale_multiple
    self.assertRecordValues(
  File "/opt/odoo/odoo/tests/common.py", line 610, in assertRecordValues
    self.fail('\n'.join(errors))
AssertionError: The records and expected_values do not match.
Wrong number of records to compare: 0 records versus 1 expected values.

==== Missing record ====
{'nbr_sales': 3.0, 'qty_in_stock': 19.0, 'warehouse_id': 1}

Could you please take a look? 😄 ❤️

Thank you!

@Shide
Copy link
Contributor Author

Shide commented Jun 4, 2024

@rousseldenis @lmignon Could you please check the failing tests in stock_average_daily_sale module?

@rousseldenis
Copy link
Sponsor Contributor

@rousseldenis @lmignon Could you please check the failing tests in stock_average_daily_sale module?

@Shide Where ?

@rousseldenis
Copy link
Sponsor Contributor

@rousseldenis @lmignon Could you please check the failing tests in stock_average_daily_sale module?

@Shide Where ?

Ok, I see. I can check

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-321-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d8dce0b into OCA:16.0 Jun 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 28ac0b1. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 16.0-stock_picking_report_delivery_driver branch June 5, 2024 05:38
@Shide
Copy link
Contributor Author

Shide commented Jun 5, 2024

@rousseldenis what was happening? What do you do to let tests pass?

@rousseldenis
Copy link
Sponsor Contributor

@rousseldenis what was happening? What do you do to let tests pass?

Apparently, a temporary failure. Wasn't able to reproduce problem locally, I re run the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants