-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12.0 mig stock_picking_report_valued #63
12.0 mig stock_picking_report_valued #63
Conversation
For avoiding problems if you don't have access to sales orders (stricter warehouse users, inter-company records...).
- This commit odoo/odoo@41bea41 breaked the inheritance.
In certain conditions of the DB (i.e. integration tests), previous code doesn't assure the price is going to be 100.
…use don't apply here
…t decimal precision
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work 👍
I did a code review: LGTM
if you like an optional change
<?xml version="1.0" encoding="utf-8"?> | ||
<odoo> | ||
|
||
<record model="ir.ui.view" id="view_partner_valued_picking"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional change:
id before model
and
use original id (view_partner_form)
This PR has the |
/ocabot merge |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 2fafc22. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
Supersedes #50
Cc @Tecnativa