Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 mig stock_picking_report_valued #63

Merged
merged 14 commits into from
Jul 1, 2019

Conversation

ernestotejeda
Copy link
Member

Supersedes #50

Cc @Tecnativa

Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: LGTM
if you like an optional change

<?xml version="1.0" encoding="utf-8"?>
<odoo>

<record model="ir.ui.view" id="view_partner_valued_picking">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional change:
id before model
and
use original id (view_partner_form)

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 27, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 27, 2019
8 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 12.0-ocabot-merge-pr-63-by-rousseldenis-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2d114bd into OCA:12.0 Jul 1, 2019
OCA-git-bot added a commit that referenced this pull request Jul 1, 2019
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2fafc22. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@pedrobaeza pedrobaeza deleted the 12.0-mig-stock_picking_report_valued branch July 2, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants