[FIX] stock_quantity_history_location: qty by location #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelbn please test |
pedrobaeza
reviewed
Dec 30, 2019
chienandalu
force-pushed
the
12.0-fix-stock_account_quantity_history_location
branch
from
3c0831f
to
c33ca54
Compare
yajo
reviewed
Dec 30, 2019
chienandalu
force-pushed
the
12.0-fix-stock_account_quantity_history_location
branch
from
c33ca54
to
ae5e934
Compare
|
@chienandalu Do you plan to add a test for that fix ? |
|
@rousseldenis Yes, I'd like to |
dreispt
approved these changes
Apr 2, 2020
When a qty at date is asked the location context could be overriden if the company_owned one was inserted after we removed it. We ensure to remove it to always obtain the right values. As a side effect, stock_account valuation is now correctly computed when AVCO or Standard methods are implied. So should be with FIFO manual (as it computes the quantities the same way) but doubtful in FIFO real time.
chienandalu
force-pushed
the
12.0-fix-stock_account_quantity_history_location
branch
from
ae5e934
to
6f856e7
Compare
|
@rousseldenis Added tests |
rousseldenis
approved these changes
Apr 15, 2020
|
@chienandalu Is this ready ? |
|
Yeah :) |
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at 3af4963. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a qty at date is asked the location context could be overriden if
the company_owned one was inserted after we removed it. We ensure to
remove it to always obtain the right values.
As a side effect, stock_account valuation is now correctly computed when
AVCO or Standard methods are implied. So should be with FIFO manual (as
it computes the quantities the same way) but doubtful in FIFO real time.
So maybe stock_account_quantity_history_location is of no much use (warning advising that the computation is not true, wich isn't accurate and show 0 qtys values to dectect errors)
cc @Tecnativa TT21183