Add modules stock_packaging_usability and stock_packaging_usability_ul

[alexis-via]

This contribution includes 2 modules that work together (that's why I put them in the same PR):

1. stock_packaging_usability: it restores the button "Put in current pack" which was native in v7 but is not present in v8, and it adds a button "Put residual in new pack" which puts all the lines that are not already in a pack in one single new pack

2. stock_packaging_usability_ul: it depends on the module stock_packaging_usability and extends it behavior: when you go "put in new pack" or "Put residual in new pack", it will ask you to choose a product.ul (logistical unit) that will be set on the new pack.

[coveralls]

Coverage remained the same when pulling 3d10a42 on akretion:8.0-add-stock-packaging-usability into c2369a3 on OCA:8.0.

[coveralls]

Coverage remained the same when pulling fada9c3 on akretion:8.0-add-stock-packaging-usability into c2369a3 on OCA:8.0.

[pedrobaeza]

Hi, Alexis, thanks for this contribution.

Let me tell you about some remarks:

• Current Odoo v8 version includes already a button for putting a line in a new package (it's an icon of a package actually), so this part of the functionality is not needed.
• I would do in the same module both functionality: move residual to a new package and select logistical unit as an optional parameter.
• The module name would be more explicit if it were stock_picking_residual_packaging, following convention area + object + function.

[alexis-via]

@pedrobaeza
I know that Odoo v8 provides a button "Put in new pack". The module "stock_packaging_usability" doesn't change that ; it adds the buttons "Put in current pack" (which was native in v7 and has been dropped in v8) and "Put residual in new pack" at the top (which didn't exist in v7, but is a big time saver).

I decided to have 2 separated modules (even if it required more work for me) because the first module is designed for those who don't use the object product.ul and just want the same features as v7 ; the second module is for those who also want to use the object product.ul.

I don't care about the module name. If all reviewers agree with your proposal for a new module name, i'll change it.

[coveralls]

Coverage remained the same at 25.81% when pulling 7780bc6 on akretion:8.0-add-stock-packaging-usability into c2369a3 on OCA:8.0.

[pedrobaeza]

OK, I understand that it's not the same. The only flaw I see then is to know what is "the current pack". Can you add a readonly field in the screen to show this data?

About ul, I would insist to put it on one module, because it's only a data that can be ignored if you don't work with it. Even I think you can control its visibility with the option of "Track logistic units" on Configuration.

[alexis-via]

@pedrobaeza
Maybe "put in last pack" is more clear for the user than "Put in current pack". I used the string "Put in current pack" because it's the string that was used by the native button in v7, so it's easier for the users of v7 to understand what the button will do.

I am surprised by your insistance on merging the 2 modules. Of course, we could use a group to know if we display the pop-up to select product.ul or not. But I made the effort to put this in 2 different modules because I thought that some companies that don't want to use product.ul and only want the same features as v7 wouldn't like to install a module that adds features that they don't want/need. There is no group "Track logistic units" in v8 ; I guess you refer to the group with XMLID "stock.group_tracking_lot" which is called "Manage Packages" in v8. The problem is that this group is required to track the packages, but you may want to track packages and not use the object product.ul. So we would need to create a new group "Manage Logistic Units" that would be created by our module.

[pedrobaeza]

I see better to say "Put in last pack", but what happens when there is no last pack?

I insist to merge both because the functionality is too short for a module, and it's perfectly compatible. Yeah, the group I mean is that, and is labelled in general configuration as "Use packages: pallets, boxes, ... "

[guewen]

I prefer "Put in current pack", because irl, the pack below your hands is "the current pack".

[yvaucher]

Please leave translation empty if not translated

[brother-bernard]

👍 Fully operationnal for our mail-order service.

[sebastienbeau]

👍 I also prefers "Put in current pack" for the fact that we should or not merge the module both solution seem correct for me. So I am ok with the current one