Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] shipment_advice_planner #106

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

simahawk
Copy link

@simahawk simahawk commented Oct 6, 2023

This module is used to plan ready transfers in shipment advices.

As this is the base module, it provides only a simple: Transfers are grouped to have a single shipment advice by warehouse.

Replaces #88 just to address some minor comments and move fwd w/ the merge faster.

This module is used to plan ready transfers in shipment advices.

As this is the base module, it provides only a simple:  Transfers
are grouped to have a single shipment advice by warehouse.

[IMP] shipment_advice_planner: Add init script

[FIX] - shipment_advice_planner: fix typo

[FIX] - group pickings to plan by picking type instead of the warehouse

[IMP] - shipment_advice_planner: add search for can_be_planned_in_shipment_advice field

[IMP] shipment_advice_planner: shipment advice is created confirmed and arrival and departure date

[IMP] - shipment_advice_planner: add unit tests

[IMP] shipment_advice_planner: add author & maintainer

Co-authored-by: Jacques-Etienne Baudoux <je@bcim.be>

[IMP] add depends_context to _compute_picking_to_plan_ids
@simahawk
Copy link
Author

simahawk commented Oct 6, 2023

Original PR already approved

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-106-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 11be5d3 into OCA:16.0 Oct 6, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d3ccd61. Thanks a lot for contributing to OCA. ❤️

@rousseldenis
Copy link
Sponsor Contributor

@simahawk a little bit cavalier to come on the PR late and self-do the whole thing. Nevertheless, thanks for this

@simahawk
Copy link
Author

simahawk commented Oct 6, 2023

@rousseldenis Yeah, sorry... I'm in touch w/ @jbaudoux and I've got confirmation of the approval and of the minor glitches... Same for OCA/wms#560 😉

In the end, I'm just trying to make everybody happy here w/o annoying you guys as much as possible 😅
We also had some problems due to conflicts with multiple test requirements and I wanted to clean them up (for something that was already approved anyway).

@rousseldenis
Copy link
Sponsor Contributor

@rousseldenis Yeah, sorry... I'm in touch w/ @jbaudoux and I've got confirmation of the approval and of the minor glitches... Same for OCA/wms#560 😉

In the end, I'm just trying to make everybody happy here w/o annoying you guys as much as possible 😅 We also had some problems due to conflicts with multiple test requirements and I wanted to clean them up (for something that was already approved anyway).

@simahawk Yeah I know. But you are aware too we are currently maintaining the whole v16 stack. You should have waited some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants