Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] stock_putaway_product_template: Migration to 13.0 #1001

Merged
merged 7 commits into from Feb 15, 2021
Merged

[13.0][MIG] stock_putaway_product_template: Migration to 13.0 #1001

merged 7 commits into from Feb 15, 2021

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Oct 28, 2020 •
edited

Renamed from stock_putaway_product_form to stock_putaway_product_template

Locked by:

Please, @pedrobaeza and @sergio-teruel review it.
@Tecnativa TT25955

@OCA-git-bot
Copy link
Contributor

Hi @sebastienbeau, @kevinkhao,
some modules you are maintaining are being modified, check this out!

@victoralmau victoralmau mentioned this pull request Oct 28, 2020
Closed
53 tasks
@victoralmau
Copy link
Member Author

Fix for the branch in #1000

@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from 1fa6d5b to 1c92ebf Compare October 28, 2020 10:39
@rousseldenis rousseldenis added this to the 13.0 milestone Oct 29, 2020
@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from 1c92ebf to 784b13d Compare November 23, 2020 07:12
sergio-teruel
sergio-teruel suggested changes Nov 23, 2020
View reviewed changes
stock_putaway_product_form/README.rst Outdated Show resolved Hide resolved
stock_putaway_product_form/__init__.py Outdated Show resolved Hide resolved
stock_putaway_product_form/models/stock_putaway_rule.py Outdated Show resolved Hide resolved
stock_putaway_product_form/views/product.xml Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch 3 times, most recently from 722e9c8 to de629c5 Compare November 23, 2020 09:51
@victoralmau victoralmau mentioned this pull request Nov 23, 2020
Merged
@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from de629c5 to 1f5a28c Compare November 25, 2020 08:23
@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch 3 times, most recently from f05b7c5 to a2798a5 Compare December 21, 2020 14:49
@victoralmau
Copy link
Member Author

Travis error related to stock_vertical_lift and previously reported in #1021 (comment)
Actually, CI don't work in 13.0

@pedrobaeza
Copy link
Member

Please rebase

@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from a2798a5 to b03f310 Compare December 29, 2020 07:03
@HaraldPanten
Copy link

Hi @victoralmau How's this PR going? THX

@victoralmau
Copy link
Member Author

It's ready to review it. Work fine.

@HaraldPanten
Copy link

Hi @victoralmau I've been testing the module on runbot, but I wasn't able to see the putaway rules in the product form (inventory tab), apart from the smartbutton ones. Could you check? Am I missing something?

Captura de pantalla 2021-01-25 a las 18 52 28

@victoralmau
Copy link
Member Author

Maybe these video from runbot help you.

stock_putaway_product_form

@HaraldPanten
Copy link

Hi @victoralmau Maybe I didn't explain my question well enough.

I mean:

Your video is a standard functionality in Odoo V13, so... what is your module migration adding?

@HaraldPanten
Copy link

Hi @victoralmau @pedrobaeza could you have a look at my comments? THX!

@victoralmau
Copy link
Member Author

Ping @sergio-teruel

@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from b03f310 to 6ddf49b Compare February 1, 2021 15:50
@victoralmau
Copy link
Member Author

Some important changes apply now.
These addon is necessary because add possibility to select product_template in stock_putaway_rule (prevent to create records for every variant).

IMO, is need to rename addon to stock_putaway_product_template what do you ythink?

@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from f71dea3 to d02a474 Compare February 10, 2021 15:30
@sergio-teruel
Copy link
Contributor

@victoralmau Can you increase the coverage?

@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from d02a474 to 4d99e34 Compare February 11, 2021 10:24
@sergio-teruel sergio-teruel mentioned this pull request Feb 12, 2021
Closed
@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from 4d99e34 to 66517d4 Compare February 12, 2021 11:56
@victoralmau
Copy link
Member Author

victoralmau commented Feb 12, 2021 •
edited

Travis fail acording to stock_storage_type because need stock_putaway_hook (as dependency).
IMO exists 2 possibilities to solved it:

@guewen and @simahawk What do you think about it?
It's related to OCA/wms#173

@simahawk
Copy link
Contributor

simahawk commented Feb 12, 2021 •
edited

@victoralmau my bad, I'll restore those deps. Coming soon.

@simahawk
Copy link
Contributor

done and restarted your build

@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch 2 times, most recently from dfd44a9 to f954fef Compare February 12, 2021 17:41
@victoralmau
Copy link
Member Author

victoralmau commented Feb 12, 2021 •
edited

It's not finished yet because in 13.0 don't exist _get_putaway_rule. https://github.com/OCA/stock-logistics-warehouse/blob/12.0/stock_putaway_product_form/models/putaway_strategy.py#L13
In next days investigate about it and included it (and add test to check it).

Maybe use _get_putaway_strategy function related to location is the better way.

@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from f954fef to a216672 Compare February 15, 2021 09:07
@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from a216672 to c46609e Compare February 15, 2021 09:19
@victoralmau victoralmau force-pushed the 13.0-mig-stock_putaway_product_form branch from c46609e to 75cf49e Compare February 15, 2021 09:47
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-1001-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit a3e22bd into OCA:13.0 Feb 15, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bb65485. Thanks a lot for contributing to OCA. ❤️

CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
@OCA-git-bot
Merge PR OCA#1001 into 13.0
8beeb01 
Signed-off-by pedrobaeza
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
@OCA-git-bot
Merge PR OCA#1001 into 13.0
676af15 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@victoralmau @OCA-git-bot @pedrobaeza @HaraldPanten @sergio-teruel @simahawk @rousseldenis @kevinkhao @oca-travis