Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] scrap_reason_code #1389

Merged
merged 11 commits into from Mar 17, 2022
Merged

[12.0][MIG] scrap_reason_code #1389

merged 11 commits into from Mar 17, 2022

Conversation

HviorForgeFlow
Copy link
Member

Backport from 13.0

CC @ForgeFlow

@rousseldenis rousseldenis added this to the 12.0 milestone Mar 10, 2022
@rousseldenis
Copy link
Sponsor Contributor

@HviorForgeFlow Could you fix tests ?

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration scrap_reason_code

@OCA-git-bot
Copy link
Contributor

There's no issue in this repo with the title 'Migration to version 12.0' and the milestone 12.0, so not possible to add the comment.

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration scrap_reason_code

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 10, 2022
Closed
54 tasks
@HviorForgeFlow
Copy link
Member Author

@rousseldenis tests fixed

rousseldenis
rousseldenis approved these changes Mar 14, 2022
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-1389-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 233ff1c into OCA:12.0 Mar 17, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8d2d353. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-mig-scrap_reason_code branch March 17, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@HviorForgeFlow @rousseldenis @OCA-git-bot @LoisRForgeFlow @Khalid-SerpentCS @oca-travis