[16.0] [MIG] stock_secondary_unit #1769

BT-aleonard · 2023-06-21T08:37:35Z

The PR [16.0][MIG] stock_secondary_unit #1701 is not attended, so I replaced it with this PR.

…ry unit

…ependencies

Currently translated at 100.0% (15 of 15 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_secondary_unit/zh_CN/

On move line creation, the precision of secondary qty rounding is wrong; the unit of measure factor is being used instead of rounding.

…s field. TT26606

…variants view on common form. Create related template secondary unit field. TT27057

[IMP] stock_secondary_unit: Use product_secondary_unit mixin model from product-attribute repository.

…r mobile views TT30538

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_secondary_unit/

BT-aleonard · 2023-06-22T07:31:42Z

@sergio-teruel can we replace this PR in the issues file?

rousseldenis · 2023-06-22T07:39:22Z

/ocabot migration stock_secondary_unit.

@BT-aleonard It's usually better to add the link to the depending PR in this one description. Thanks

OCA-git-bot · 2023-06-22T07:39:31Z

The migration issue (#1494) has not been updated to reference the current pull request because a previous pull request (#1701) is not closed.
Perhaps you should check that there is no duplicate work.
CC @remihb

BT-aleonard · 2023-06-22T07:55:14Z

The PR #1701 is not attended, so I replaced it with this PR.

BT-aleonard · 2023-07-10T13:33:53Z

@sergio-teruel Can you please review this PR, thanks.

rousseldenis

Code review

yajo

After double-checking, you can see in the CI you can see you have these warnings:

2023-06-22 07:27:17,318 245 WARNING odoo py.warnings: /opt/odoo/odoo/fields.py:802: UserWarning: Field stock.move.product_uom_qty cannot be precomputed as it depends on non-precomputed field stock.move.secondary_uom_qty
2023-06-22 07:27:17,322 245 WARNING odoo py.warnings: /opt/odoo/odoo/fields.py:802: UserWarning: Field stock.move.line.qty_done cannot be precomputed as it depends on non-precomputed field stock.move.line.secondary_uom_qty

Follow the suggestions below to fix the situation, please.

yajo · 2023-08-23T11:23:27Z

stock_secondary_unit/models/stock_move.py

+        copy=True,
+        precompute=True,
+    )
+


Please add this code here:

Suggested change

secondary_uom_qty = fields.Float(

compute="_compute_secondary_uom_qty",

precompute=True,

store=True,

)

yajo · 2023-08-23T11:23:57Z

stock_secondary_unit/models/stock_move.py

+    qty_done = fields.Float(
+        store=True, readonly=False, compute="_compute_qty_done", precompute=True
+    )
+


Also here:

Suggested change

secondary_uom_qty = fields.Float(

compute="_compute_secondary_uom_qty",

precompute=True,

store=True,

)

sergio-teruel · 2023-08-24T05:27:03Z

Minor commente... I hava commented in this PR OCA/sale-workflow#2645 you can add the precompute attribute in mixin model in product_secondary_unit module

yajo · 2023-08-24T07:31:53Z

I was unsure about that because a lot of modules depend on it. I'm afraid it could break other behaviors unexpectedly...

sergio-teruel · 2023-08-28T13:27:52Z

Hi @BT-aleonard Can you take into account this PR #1606 from V15??

acsonefho · 2023-11-03T10:46:01Z

stock_secondary_unit/models/stock_move.py

+            if move.secondary_uom_id:
+                uom = self.env["uom.uom"].browse(vals["product_uom_id"])
+                factor = move.secondary_uom_id.factor * uom.factor
+                move_line_qty = vals.get("product_uom_qty", vals.get("qty_done", 0.0))


This product_uom_qty doesn't exist in v16.0
Should be replaced by reserved_uom_qty

https://github.com/odoo/odoo/blob/16.0/addons/stock/models/stock_move.py#L1449

acsonefho · 2023-11-16T10:16:52Z

stock_secondary_unit/report/report_deliveryslip.xml

+    >
+        <xpath expr="//span[@t-field='move_line.product_id']/.." position="after">
+            <td>
+                <span t-field="move_line.secondary_uom_qty" />


If your stock.picking is validated, the table header is displayed ("Secondary Qty") but the layout is not correct, it's shifted. In others states, the layout is correct.

rousseldenis · 2023-11-16T13:07:55Z

@BT-aleonard Could you attend comments ? Moreover, this deserves some little tests. Thanks

pedrobaeza · 2023-12-15T07:19:49Z

Please include #1606

pedrobaeza · 2024-02-22T17:00:02Z

Please cherry-pick #1948

rousseldenis · 2024-02-22T17:04:53Z

@BT-dmoreno Maybe someone still active to continue this ?

Rad0van · 2024-03-04T13:33:02Z

stock_secondary_unit/models/stock_move.py

+            if move.secondary_uom_id:
+                uom = self.env["uom.uom"].browse(vals["product_uom_id"])
+                factor = move.secondary_uom_id.factor * uom.factor
+                move_line_qty = vals.get("product_uom_qty", vals.get("qty_done", 0.0))


I am trying to wrap my head around this because whatever I do the lines end up with 0 secondary qty and None secondary uom id. Why? Because move.secondary_uom_id is None. I cannot find any piece of code that would ever be attempting to write any value there. And I have looked and tested versions 15 and 14 as well. Any insights on this?

So when I confirm Purchase Order and have a look at associated stock picking this is what I get always. Or am I expecting wrongly to have secondary qty and uom displayed here?

In my opinion stock.move is missing something like this:

@api.model_create_multi def create(self, vals_list): for vals in vals_list: product = self.env["product.product"].browse(vals.get("product_id", False)) if product: vals.update( { "secondary_uom_id": product.stock_secondary_uom_id.id or product.product_tmpl_id.stock_secondary_uom_id.id, } ) return super().create(vals_list)

After that the result is what (at least) I expect:

Rad0van · 2024-03-05T10:27:35Z

stock_secondary_unit/models/stock_move.py

+        distinct_fields += ["secondary_uom_id"]
+        return distinct_fields
+
+


This ensures calculation of secondary qty. See comments in main thread.

Suggested change

@api.model_create_multi

def create(self, vals_list):

for vals in vals_list:

product = self.env["product.product"].browse(vals.get("product_id", False))

if product:

vals.update(

{

"secondary_uom_id": product.stock_secondary_uom_id.id

or product.product_tmpl_id.stock_secondary_uom_id.id,

}

)

return super().create(vals_list)

sergio-teruel and others added 23 commits June 22, 2023 08:45

[ADD] stock_secondary_unit: New module for getting stock in a seconda…

bfdd904

…ry unit

[11.0][FIX] stock_secondary_unit: Remove procurement_rule move. Fix d…

10943e8

…ependencies

[12.0][MIG] stock_secondary_unit

74cc167

[FIX] stock_secondary_unit: Fix key error in vals

9acea4c

Added translation using Weblate (Chinese (Simplified))

e293181

[12.0][FIX] stock_secondary_unit: move line create round

e9b96ff

On move line creation, the precision of secondary qty rounding is wrong; the unit of measure factor is being used instead of rounding.

[IMP] stock_secondary_unit: black, isort

d18b719

[MIG] stock_secondary_unit: Migration to 13.0

be65675

[IMP] stock_secondary_unit: Display info only for inventory users

8ee6e46

[IMP] stock_secondary_unit: Remove unnecessary code. Always compute a…

4361373

…s field. TT26606

[FIX] stock_secondary_unit: Incorrect secondary unit link in product …

5e9eb6f

…variants view on common form. Create related template secondary unit field. TT27057

[IMP] stock_secondary_unit: Use secondary units directly in pickings

d3d0acb

[IMP] stock_secondary_unit: Use product_secondary_unit mixin model from product-attribute repository.

[FIX] stock_secondary_unit: Allow use secondary units in form view fo…

6fa3199

…r mobile views TT30538

[IMP] stock_secondary_unit: black, isort, prettier

5a2f03a

[MIG] stock_secondary_unit: migration to V14.

e6f8c69

[MIG] stock_secondary_unit: Migration to 15.0

6443aed

[UPD] Update stock_secondary_unit.pot

9f757cd

[UPD] README.rst

f50fe94

[UPD] Update stock_secondary_unit.pot

373ab1c

[MIG] stock_secondary_unit: Migration to 16.0

d6c85d8

BT-aleonard force-pushed the 16.0-mig-stock_secondary_unit branch from d96af01 to e3c72c0 Compare June 22, 2023 07:18

[DON'T MERGE] test-requirements.txt

ea66351

BT-aleonard force-pushed the 16.0-mig-stock_secondary_unit branch from e3c72c0 to ea66351 Compare June 22, 2023 07:24

BT-aleonard mentioned this pull request Jun 22, 2023

Migration to version 16.0 #1494

Open

61 tasks

OCA-git-bot added this to the 16.0 milestone Jun 22, 2023

rousseldenis added needs review migration labels Jun 22, 2023

BT-dmoreno approved these changes Jun 22, 2023

View reviewed changes

yajo approved these changes Aug 23, 2023

View reviewed changes

OCA-git-bot added the approved label Aug 23, 2023

rousseldenis mentioned this pull request Aug 23, 2023

[16.0][MIG] stock_secondary_unit #1701

Closed

rousseldenis approved these changes Aug 23, 2023

View reviewed changes

yajo mentioned this pull request Aug 23, 2023

[MIG] sale_stock_secondary_unit: migrate to v16 OCA/sale-workflow#2652

Closed

2 tasks

yajo suggested changes Aug 23, 2023

View reviewed changes

OCA-git-bot removed approved labels Aug 23, 2023

OpenCode approved these changes Sep 4, 2023

View reviewed changes

acsonefho mentioned this pull request Oct 30, 2023

[16.0][MIG] purchase_stock_secondary_unit OCA/purchase-workflow#2059

Open

acsonefho suggested changes Nov 3, 2023

View reviewed changes

acsonefho suggested changes Nov 16, 2023

View reviewed changes

Rad0van reviewed Mar 4, 2024

View reviewed changes

Rad0van reviewed Mar 5, 2024

View reviewed changes

lk-eska mentioned this pull request Apr 8, 2024

16.0 mig stock secondary unit #1985

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [MIG] stock_secondary_unit #1769

[16.0] [MIG] stock_secondary_unit #1769

BT-aleonard commented Jun 21, 2023 •

edited

BT-aleonard commented Jun 22, 2023

rousseldenis commented Jun 22, 2023

OCA-git-bot commented Jun 22, 2023

BT-aleonard commented Jun 22, 2023

BT-aleonard commented Jul 10, 2023

rousseldenis left a comment

yajo left a comment •

edited

yajo Aug 23, 2023

yajo Aug 23, 2023

sergio-teruel commented Aug 24, 2023

yajo commented Aug 24, 2023

sergio-teruel commented Aug 28, 2023

acsonefho Nov 3, 2023

acsonefho Nov 16, 2023

rousseldenis commented Nov 16, 2023

pedrobaeza commented Dec 15, 2023

pedrobaeza commented Feb 22, 2024

rousseldenis commented Feb 22, 2024

Rad0van Mar 4, 2024 •

edited

Rad0van Mar 4, 2024

Rad0van Mar 4, 2024

Rad0van Mar 5, 2024 •

edited

		distinct_fields += ["secondary_uom_id"]
		return distinct_fields

+        @api.model_create_multi
+    def create(self, vals_list):
+        for vals in vals_list:
+            product = self.env["product.product"].browse(vals.get("product_id", False))
+            if product:
+                vals.update(
+                    {
+                        "secondary_uom_id": product.stock_secondary_uom_id.id
+                        or product.product_tmpl_id.stock_secondary_uom_id.id,
+                    }
+                )
+        return super().create(vals_list)

[16.0] [MIG] stock_secondary_unit #1769

Are you sure you want to change the base?

[16.0] [MIG] stock_secondary_unit #1769

Conversation

BT-aleonard commented Jun 21, 2023 • edited

BT-aleonard commented Jun 22, 2023

rousseldenis commented Jun 22, 2023

OCA-git-bot commented Jun 22, 2023

BT-aleonard commented Jun 22, 2023

BT-aleonard commented Jul 10, 2023

rousseldenis left a comment

Choose a reason for hiding this comment

yajo left a comment • edited

Choose a reason for hiding this comment

yajo Aug 23, 2023

Choose a reason for hiding this comment

yajo Aug 23, 2023

Choose a reason for hiding this comment

sergio-teruel commented Aug 24, 2023

yajo commented Aug 24, 2023

sergio-teruel commented Aug 28, 2023

acsonefho Nov 3, 2023

Choose a reason for hiding this comment

acsonefho Nov 16, 2023

Choose a reason for hiding this comment

rousseldenis commented Nov 16, 2023

pedrobaeza commented Dec 15, 2023

pedrobaeza commented Feb 22, 2024

rousseldenis commented Feb 22, 2024

Rad0van Mar 4, 2024 • edited

Choose a reason for hiding this comment

Rad0van Mar 4, 2024

Choose a reason for hiding this comment

Rad0van Mar 4, 2024

Choose a reason for hiding this comment

Rad0van Mar 5, 2024 • edited

Choose a reason for hiding this comment

BT-aleonard commented Jun 21, 2023 •

edited

yajo left a comment •

edited

Rad0van Mar 4, 2024 •

edited

Rad0van Mar 5, 2024 •

edited