[17.0][MIG] stock_quant_manual_assign: Migration to 17.0 #1973

siemenv · 2024-03-25T20:19:10Z

No description provided.

* Better layout * Remove active_id dependency in some computed fields * Clean code * Refine constraint * Take into account if the current line is previously reserved before clicking on the button.

… default them

…ds + add security groups + hook

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_quant_manual_assign/

There are cases where auto-filling of qty_done of stock move line is not desirable. e.g. you assign quants manually for some of the moves in a picking and not the others, in such case you need to go over all the moves in the picking to either remove qty_done or fill it in to proceed with the validation of the entire moves. Auto-fill behavior is also troublesome when this function is used in a manufacturing order. i.e. having qty_done of the component move live messes up the outcome of the production.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_quant_manual_assign/

Currently translated at 100.0% (31 of 31 strings) Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_quant_manual_assign/fr/

some minor change in code + on real bug in screen -> readonly fields needs a force_save on the view

Currently translated at 44.1% (15 of 34 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/it/

Currently translated at 100.0% (34 of 34 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/

Currently translated at 100.0% (34 of 34 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/es/

Currently translated at 44.1% (15 of 34 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/it/

Currently translated at 100.0% (34 of 34 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/fr/

Currently translated at 44.1% (15 of 34 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/it/

Currently translated at 100.0% (34 of 34 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/it/

Currently translated at 100.0% (34 of 34 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/ja/

Currently translated at 100.0% (34 of 34 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_manual_assign/it/

siemenv · 2024-03-28T12:54:28Z

stock_quant_manual_assign/wizard/assign_manual_quants.py

        if move.picking_type_id.auto_fill_qty_done:
            # Auto-fill all lines as done
            for ml in move.move_line_ids:
-                ml.qty_done = ml.reserved_uom_qty
+                ml.quantity = ml.quantity


I need help for this part. What functionality does "auto_fill_qty_done" need to have? In V17 there is no distinction between reserved and done quantity on stock move lines as far as I can see.

the field qty_done is removed in 17.0, so I think we don't need to care about it.

rousseldenis · 2024-03-28T12:57:46Z

/ocabot migration stock_quant_manual_assign

BT-jmichaud · 2024-05-03T07:03:27Z

When testing, I get the following error.
We have the same problem in 16.0.
The toogle button does not work here.

I would suggest to remove it like here: #1792

fanha99

just few comment.

fanha99 · 2024-05-24T07:47:34Z

stock_quant_manual_assign/wizard/assign_manual_quants.py

-            reserved = quant.reserved_quantity - sum(
-                move_lines.mapped("reserved_uom_qty")
-            )
+            reserved = quant.reserved_quantity - sum(move_lines.mapped("quantity"))


I think you need to map the "quantity_product_uom" instead of just "quantity"

fanha99 · 2024-05-24T07:47:49Z

stock_quant_manual_assign/wizard/assign_manual_quants.py

        if move.picking_type_id.auto_fill_qty_done:
            # Auto-fill all lines as done
            for ml in move.move_line_ids:
-                ml.qty_done = ml.reserved_uom_qty
+                ml.quantity = ml.quantity


the field qty_done is removed in 17.0, so I think we don't need to care about it.

fanha99 · 2024-05-24T08:00:22Z

stock_quant_manual_assign/tests/test_stock_quant_manual_assign.py

-        cls.picking_type_out = cls.ModelDataObj._xmlid_to_res_id(
-            "stock.picking_type_out"
-        )
+        cls.picking_type_out = cls.env.ref("stock.warehouse0").out_type_id.id


why need to change these code? how about multi stock, multi warehouse

fanha99 · 2024-05-29T14:54:29Z

stock_quant_manual_assign/views/stock_picking_type_views.xml

because of qty_done was removed in 17.0, so this file is no need any more.

fanha99 · 2024-05-29T14:56:37Z

stock_quant_manual_assign/__manifest__.py

@@ -7,7 +7,7 @@

 {
    "name": "Stock - Manual Quant Assignment",
-    "version": "16.0.1.0.1",


last version is 16.0.1.1.0, so please pick the last one.
beside, you can take a look at PR #2038.

fanha99 · 2024-05-29T15:00:58Z

stock_quant_manual_assign/tests/test_stock_quant_manual_assign.py

@@ -149,7 +149,7 @@ def test_quant_manual_assign(self):
            "There are 2 quants selected",
        )
        self.assertFalse(self.move.picking_type_id.auto_fill_qty_done)
-        self.assertEqual(sum(self.move.move_line_ids.mapped("qty_done")), 0.0)


because of "qty_done" was removed in 17.0, so I think we don't need these test case.

fanha99 · 2024-05-29T15:22:32Z

stock_quant_manual_assign/tests/test_stock_quant_manual_assign.py

you can take a look at https://www.odoo.com/documentation/17.0/developer/reference/backend/testing.html#
It will help to save time, by test it yourself before make pull request.

fanha99 and others added 30 commits March 25, 2024 20:28

[MIG] stock_quant_manual_assign: Migration to 10.0

2785319

11.0-mig-stock_quant_manual_assign

0e0bd63

[MIG] stock_quant_manual_assign: Migration to 11.0

83366b5

[IMP] stock_quant_manual_assign:

40aefd8

* Better layout * Remove active_id dependency in some computed fields * Clean code * Refine constraint * Take into account if the current line is previously reserved before clicking on the button.

[FIX] stock_quant_manual_assign: Related fields are not filled if not…

02d8e47

… default them

[IMP] stock_quant_manual_assign: Add owner to criteria + reorder fiel…

abd77b7

…ds + add security groups + hook

[UPD] Update stock_quant_manual_assign.pot

f83e7bc

[12.0][MIG] stock_quant_manual_assign

a60b752

[IMP] stock_quant_manual_assign: black, isort, prettier

9e4ecf7

[MIG] stock_quant_manual_assign: Migration to 13.0

1aa5ccf

[UPD] Update stock_quant_manual_assign.pot

ad07824

[UPD] README.rst

268e9c7

[UPD] Eficent -> ForgeFlow

d1ce44d

[UPD] README.rst

49dc221

[MIG] stock_quant_manual_assign: Migration to 14.0

c2bbad6

[UPD] Update stock_quant_manual_assign.pot

37aa1b7

[UPD] README.rst

2853b4a

[IMP] stock_quant_manual_assign: add prepare lines method

587847b

[UPD] Update stock_quant_manual_assign.pot

f5b362e

stock_quant_manual_assign 14.0.1.1.0

5c8a14d

[MIG] stock_quant_manual_assign: Migration to 15.0

3af77db

[UPD] Update stock_quant_manual_assign.pot

0264c93

[UPD] README.rst

bdf88e6

[IMP] stock_quant_manual_assign: make several columns sortable in wizard

4500679

stock_quant_manual_assign 15.0.1.1.0

770c959

xavier-bouquiaux and others added 14 commits March 25, 2024 20:28

[FIX] stock_quant_manual_assign

3c9f93f

some minor change in code + on real bug in screen -> readonly fields needs a force_save on the view

stock_quant_manual_assign 16.0.1.0.1

3437f69

[UPD] README.rst

696d206

[17.0-mig-stock] [IMP] stock_quant_manual_assign: pre-commit stuff

33c3e45

siemenv marked this pull request as draft March 25, 2024 20:29

siemenv force-pushed the 17.0-mig-stock_quant_manual_assign branch 2 times, most recently from 431304d to 4d86f70 Compare March 28, 2024 12:51

siemenv marked this pull request as ready for review March 28, 2024 12:51

siemenv commented Mar 28, 2024

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Mar 28, 2024

OCA-git-bot mentioned this pull request Mar 28, 2024

Migration to version 17.0 #1883

Open

43 tasks

rousseldenis added needs review migration labels Mar 28, 2024

fanha99 reviewed May 24, 2024

View reviewed changes

[17.0-mig-stock] [MIG] stock_quant_manual_assign: Migration to 17.0

df7b89c

siemenv force-pushed the 17.0-mig-stock_quant_manual_assign branch from 4d86f70 to df7b89c Compare May 29, 2024 06:02

fanha99 reviewed May 29, 2024

View reviewed changes

OCA-git-bot mentioned this pull request Jun 15, 2024

[17][MIG] stock_quant_manual_assign #2071

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] stock_quant_manual_assign: Migration to 17.0 #1973

[17.0][MIG] stock_quant_manual_assign: Migration to 17.0 #1973

siemenv commented Mar 25, 2024

siemenv Mar 28, 2024

fanha99 May 24, 2024

rousseldenis commented Mar 28, 2024

BT-jmichaud commented May 3, 2024

fanha99 left a comment

fanha99 May 24, 2024

fanha99 May 24, 2024

fanha99 May 24, 2024

fanha99 May 29, 2024

fanha99 May 29, 2024

fanha99 May 29, 2024

fanha99 May 29, 2024

[17.0][MIG] stock_quant_manual_assign: Migration to 17.0 #1973

Are you sure you want to change the base?

[17.0][MIG] stock_quant_manual_assign: Migration to 17.0 #1973

Conversation

siemenv commented Mar 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis commented Mar 28, 2024

BT-jmichaud commented May 3, 2024

fanha99 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment