[8.0] stock_valuation_account_manual_adjustment #228

JordiBForgeFlow · 2016-12-14T16:33:33Z

Stock Inventory Account Manual Adjustment

This module shows in the product inventory stock value and the accounting
value, and allows to create accounting adjustment entries to align the
accounting value to match with the inventory stock value.

Configuration

Assign the group 'Stock Valuation Account Manual Adjustments' to the users
that should be allowed to list the valuation discrepancies and to reconcile
them.

Usage

Go to 'Warehouse / Inventory Control / Real Time Inventory Valuation'
Filter on 'Valuation Discrepancy != 0.0' using the advanced filter.
Select the products that you wish to reconcile and press 'More /
Adjust Stock Valuation Account Discrepancies'.

Known issues / Roadmap

In order to properly manage the inventory valuation from an accounting
perspective all journal items created for inventory accounts should
include the product.
The price change function of Odoo creates journal entries to the inventory
account without specifying the product. This is bad because you loose the
ability to control the inventory valuation from accounting at the level of
the product. In order to fix this, use the module
'stock_inventory_revaluation', to be found in the same OCA repository.

JordiBForgeFlow · 2016-12-14T16:33:49Z

cc @eficent

…ove and account move line - to avoid forcing the computation

- Create a specific menu to display real time inventory valuation - Change the method to compute inventory value

- ability to search for discrepancies by product. - Search for queant associated to stockable products

andhit-r · 2016-12-16T13:37:55Z

@jbeficent i have a case study that you might want to consider

YourCompany has an Finished Good Account to hold inventory accounting value
A manual journal entry created to open balance for Finished Good Account. Let say:
Finished Good Account Dr. 700
Opening Balance Cr. 700
This journal entry obviously still create discrepancies because manually created journal entry (and move) could not fill product_id field on account.move.line
Manual Valuation then should be performed to adjust. Here is the catch, (1) YourCompany does not want to create additional account as contra-valuation-account, (2) Finished Good Account balance after manual valuation perform should not change.
So manual valuation performed with wizard value: (1) Valuation Increase Contra-Account == Finished Good Account, and (2) Valuation Decrease Contra-Account == Finished Good Account. This to make sure that final balance will not change. Journal entry will be:
Finished Good Account Dr. 700
Finished Good Account Cr. 700
Now both journal items above will have product_id filled
The discrepancies will still != 0

Screenshot for manual valuation:

Screenshot for created journal entry:

Screenshot discrepency after valuation:

IMO you should only assign product_id to one journal item only.

andhit-r · 2016-12-16T13:44:26Z

stock_valuation_account_manual_adjustment/wizards/mass_create_view.xml

+                     </group>
+                     <newline/>
+                     <group colspan="2">
+                         <button name="process"


It's better to put the buttons on

What do you mean?

@andhit-r Regarding your long comment, if a company runs perpetual inventory the inventory account should be detailed at a product level. I recently performed an initial balance for a company, and I asked the quantity on stock and the valuation of each product, in order to create the opening entry, detailed at product level.

In order to load what I did was:
1-. Enter the correct standard cost in the product
2.- Set the product valuation to real_time
3.- Change the virtual inventory location to use as debit and credit account "Opening Balance Equity"
4.- Perform an inventory adjustment, to add the on hand quantities as they reported

As a result journal entries were created for each product as:
Dr. Finished Goods
Cr. Opening Balance Equity

That's the correct way to do IMHO. No need to use the manual adjustments tool at all.

True, but not all implementation project start that way. What is a company use accounting only module first?

You should put all buttons inside footer tag.
Without footer tag:

With footer tag:

If a company starts using accounting only, when they switch to stock accounting they should open a new GL account to manage inventory valuation, of course! Then they will need to credit the balance from the old and debit into the new. Same procedure as above, but replace "opening balance equity" with "old inventory account". :)

Thanks for the feedback!

andhit-r · 2016-12-16T23:59:17Z

stock_valuation_account_manual_adjustment/README.rst

+=====
+
+* Go to the list of products or product variants. You can see in the tree
+  view the inventory value and the accounting value.


Inventory Value, Accounting Value, and Discrepancy can only be seen on Real Time Inventory Valuation

Thanks. Done!

andhit-r · 2016-12-17T00:07:28Z

stock_valuation_account_manual_adjustment/models/stock_valuation_account_manual_adjustment.py

+
+    @api.multi
+    def post(self):
+        timenow = time.strftime('%Y-%m-%d')


Why not use fields.Datetime.now()? You use it on https://github.com/OCA/stock-logistics-warehouse/pull/228/files#diff-ecb3b276206e9b56ac80d5cccbfe6518R167.

andhit-r · 2016-12-17T00:13:51Z

@jbeficent i'm still sure that you only need to assign product_in on one move line. Strange things always happen on implementation hahaha. But for now it's fine. I will create PR if my use case happen in the future. Waiting to pass all test before tumbs. Thank you for this PR. Can't wait to use it on production.

- rename move_id to account_move_id - fix incorrect tests

JordiBForgeFlow · 2016-12-19T11:17:11Z

@eficent can you please review?

JordiBForgeFlow · 2016-12-20T07:56:09Z

stock_valuation_account_manual_adjustment/init_hook.py

+        cr.execute(
+            """
+            ALTER TABLE account_move_line
+            ADD COLUMN stock_valuation_account_manual_adjustment_id


@pedrobaeza Can you help me with this? I am adding field 'stock_valuation_account_manual_adjustment_id' in account.move.line as a related with move_id, and in order to speed-up the install I am pre-creating the field. However at the time of install the field is being still computed. Why?

I think that computed with store=True are always computed when the module is installed.

In fact the pre-init code is running correctly.

LoisRForgeFlow

LGTM 👍

JordiBForgeFlow · 2016-12-20T11:24:17Z

@andhit-r Runbot is green. However there's still one issue related to the pre-init hook. I'm not sure if it's being effective.

AaronHForgeFlow

LGTM 👍

I think also that it would be a good idea to have the filter 'Valuation Discrepancy != 0.0' in the "Real-Time Inventory valuation" tree view.

andhit-r · 2016-12-20T13:07:06Z

👍 . It's better if all status checks pass though.

JordiBForgeFlow · 2016-12-21T10:02:59Z

Thanks @andhit-r. Now merged

[ADD] stock_valuation_account_manual_adjustment

stock_split_picking : open action instead of create wizard

[ADD] stock_valuation_account_manual_adjustment

JordiBForgeFlow added 2 commits December 14, 2016 17:25

[ADD] product_inventory_account_reconcile

56b9116

[IMP] update README

a21bb37

JordiBForgeFlow added 6 commits December 15, 2016 06:04

[IMP] optimize performance

c9d3a1c

[IMP] renamed module + various other improvements

74c3bee

[IMP] remove unnecessary dependency

ed02b5a

[FIX] tests

ed25209

[IMP] add restriction on unlink

87e43fd

[FIX] security

66c9bdd

JordiBForgeFlow changed the title ~~[8.0] product_inventory_account_reconcile~~ [8.0] stock_valuation_account_manual_adjustment Dec 15, 2016

JordiBForgeFlow added 10 commits December 15, 2016 15:23

[FIX] flake8 and pylint

77648bc

[IMP] add pre_init hook to pre-create the new fields in the account m…

4da48e5

…ove and account move line - to avoid forcing the computation

[FIX] reference in openerp.py to pre-init-hook

38f5eef

[FIX] correct field in view

948d757

[FIX] view

7ef839d

[FIX]

fb5e12a

- Create a specific menu to display real time inventory valuation - Change the method to compute inventory value

[IMP]

6b97936

[IMP] security

030e194

[IMP]

67311f3

- ability to search for discrepancies by product. - Search for queant associated to stockable products

[IMP] optimize performance

9e87407

andhit-r reviewed Dec 16, 2016

View reviewed changes

JordiBForgeFlow added 3 commits December 16, 2016 17:29

[IMP] various improvements to optimize performance

0f9f41f

[IMP] add footer on form

87355e7

[FIX] travis and runbot errors

f63990c

andhit-r reviewed Dec 16, 2016

View reviewed changes

andhit-r reviewed Dec 17, 2016

View reviewed changes

[FIX]

bba937a

- rename move_id to account_move_id - fix incorrect tests

JordiBForgeFlow commented Dec 20, 2016

View reviewed changes

[IMP] add ability to search for inventory and accounting value

509da92

LoisRForgeFlow approved these changes Dec 20, 2016

View reviewed changes

AaronHForgeFlow approved these changes Dec 20, 2016

View reviewed changes

JordiBForgeFlow merged commit d592b4a into OCA:8.0 Dec 21, 2016

serpentcs-dev1 pushed a commit to serpentcs-dev1/stock-logistics-warehouse that referenced this pull request Feb 22, 2017

[8.0] stock_valuation_account_manual_adjustment (OCA#228)

fba06c2

[ADD] stock_valuation_account_manual_adjustment

JordiBForgeFlow added a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Feb 22, 2017

stock_valuation_account_manual_adjustment (OCA#228)

dcff3e9

[ADD] stock_valuation_account_manual_adjustment

JordiBForgeFlow added a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Mar 14, 2017

stock_valuation_account_manual_adjustment (OCA#228)

2193ada

[ADD] stock_valuation_account_manual_adjustment

JordiBForgeFlow added a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Mar 15, 2017

stock_valuation_account_manual_adjustment (OCA#228)

1651c8b

[ADD] stock_valuation_account_manual_adjustment

yk2kus pushed a commit to thinkopensolutions/oca-stock-logistics-warehouse that referenced this pull request Mar 16, 2017

Merge pull request OCA#228 from acsone/8.0-stock_split_picking-lga

7a5a0d6

stock_split_picking : open action instead of create wizard

JordiBForgeFlow added a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Mar 23, 2017

stock_valuation_account_manual_adjustment (OCA#228)

142680b

[ADD] stock_valuation_account_manual_adjustment

JordiBForgeFlow added a commit that referenced this pull request Apr 25, 2017

stock_valuation_account_manual_adjustment (#228)

a5dccd0

[ADD] stock_valuation_account_manual_adjustment

gfcapalbo pushed a commit to gfcapalbo/stock-logistics-warehouse that referenced this pull request Jun 29, 2017

stock_valuation_account_manual_adjustment (OCA#228)

4a32781

[ADD] stock_valuation_account_manual_adjustment

LoisRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Jan 26, 2018

stock_valuation_account_manual_adjustment (OCA#228)

edbf2ff

[ADD] stock_valuation_account_manual_adjustment

LoisRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Nov 14, 2018

stock_valuation_account_manual_adjustment (OCA#228)

732eb07

[ADD] stock_valuation_account_manual_adjustment

LoisRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Jan 2, 2019

stock_valuation_account_manual_adjustment (OCA#228)

277b792

[ADD] stock_valuation_account_manual_adjustment

LoisRForgeFlow deleted the 8.0-product_inventory_account_reconcile branch December 17, 2019 09:10

AaronHForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Apr 8, 2020

stock_valuation_account_manual_adjustment (OCA#228)

8c9573f

[ADD] stock_valuation_account_manual_adjustment

AaronHForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Jun 5, 2020

stock_valuation_account_manual_adjustment (OCA#228)

5550608

[ADD] stock_valuation_account_manual_adjustment

AaronHForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Jun 8, 2020

stock_valuation_account_manual_adjustment (OCA#228)

e553d6c

[ADD] stock_valuation_account_manual_adjustment

MiquelRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Dec 17, 2020

stock_valuation_account_manual_adjustment (OCA#228)

1ad1941

[ADD] stock_valuation_account_manual_adjustment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.0] stock_valuation_account_manual_adjustment #228

[8.0] stock_valuation_account_manual_adjustment #228

JordiBForgeFlow commented Dec 14, 2016 •

edited

JordiBForgeFlow commented Dec 14, 2016

andhit-r commented Dec 16, 2016

andhit-r Dec 16, 2016

JordiBForgeFlow Dec 16, 2016

JordiBForgeFlow Dec 16, 2016

andhit-r Dec 16, 2016

andhit-r Dec 16, 2016

JordiBForgeFlow Dec 16, 2016

andhit-r Dec 16, 2016

JordiBForgeFlow Dec 20, 2016

andhit-r Dec 17, 2016

andhit-r commented Dec 17, 2016

JordiBForgeFlow commented Dec 19, 2016

JordiBForgeFlow Dec 20, 2016

AaronHForgeFlow Dec 20, 2016

JordiBForgeFlow Dec 21, 2016

LoisRForgeFlow left a comment

JordiBForgeFlow commented Dec 20, 2016

AaronHForgeFlow left a comment

andhit-r commented Dec 20, 2016

JordiBForgeFlow commented Dec 21, 2016

[8.0] stock_valuation_account_manual_adjustment #228

[8.0] stock_valuation_account_manual_adjustment #228

Conversation

JordiBForgeFlow commented Dec 14, 2016 • edited

Stock Inventory Account Manual Adjustment

Configuration

Usage

Known issues / Roadmap

JordiBForgeFlow commented Dec 14, 2016

andhit-r commented Dec 16, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andhit-r commented Dec 17, 2016

JordiBForgeFlow commented Dec 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

JordiBForgeFlow commented Dec 20, 2016

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

andhit-r commented Dec 20, 2016

JordiBForgeFlow commented Dec 21, 2016

JordiBForgeFlow commented Dec 14, 2016 •

edited