New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] Add stock_reorder_forecast module with tests #307
Conversation
a5a34aa
to
5e073fa
Compare
e772117
to
a8e31c3
Compare
a8e31c3
to
fdad665
Compare
6e49482
to
e798830
Compare
Hoi @gfcapalbo , is this completed? |
'product', | ||
'stock', | ||
'sale', | ||
'purchase' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking for me but, purchase depends of stock and sale of product, then 2 module here as dependencies is sufficient
@daramousk other than a small flake error and @bealdav 's dependency question , yes. It has been working on production for months |
reducing redundant dependencies
@bealdav this has been working for months. I have condensed and removed extra dependencies. Do you see anything else? I think this 9.0 version would be useful for many if merged . we are also preparing a 10.0 version. |
purchase_multiple = supplier.purchase_multiple | ||
if purchase_multiple == 0: | ||
purchase_multiple = 1 | ||
qty = int((qty + purchase_multiple - 1) / purchase_multiple) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are expecting an integer division here, can you use the '//' operator? This will make the porting to python3 easier.
@gfcapalbo reviewed and approved (tiny improvement suggested); Please help us reduce the pending PRs stack by reviewing some of them 😸 |
@lreficent @jbeficent Does this conflicts with stock_demand_estimate ? |
almost ready to be merged, just a small view alert. Thanks fo your work |
@bealdav It was fixed by @gurneyalex at f48d027. |
My purpose was just that, thanks |
@gfcapalbo Closing this as no activity. Feel free to reopen it if needed. |
Allows to predict date stock levels will reach minimum by
analizying sales volume in a period and therefore to trigger RFQ's ahead
of time",
reopening of #222