Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] Add stock_reorder_forecast module with tests #307

Closed
wants to merge 8 commits into from

Conversation

gfcapalbo
Copy link
Contributor

Allows to predict date stock levels will reach minimum by
analizying sales volume in a period and therefore to trigger RFQ's ahead
of time",

reopening of #222

@daramousk
Copy link
Member

Hoi @gfcapalbo , is this completed?

'product',
'stock',
'sale',
'purchase'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking for me but, purchase depends of stock and sale of product, then 2 module here as dependencies is sufficient

@gfcapalbo
Copy link
Contributor Author

@daramousk other than a small flake error and @bealdav 's dependency question , yes. It has been working on production for months

reducing redundant dependencies
@gfcapalbo
Copy link
Contributor Author

@bealdav this has been working for months. I have condensed and removed extra dependencies. Do you see anything else? I think this 9.0 version would be useful for many if merged . we are also preparing a 10.0 version.

@gurneyalex gurneyalex changed the title Add stock_reorder_forecast module with tests [9.0] Add stock_reorder_forecast module with tests Mar 23, 2018
purchase_multiple = supplier.purchase_multiple
if purchase_multiple == 0:
purchase_multiple = 1
qty = int((qty + purchase_multiple - 1) / purchase_multiple)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are expecting an integer division here, can you use the '//' operator? This will make the porting to python3 easier.

@gurneyalex
Copy link
Member

@gfcapalbo reviewed and approved (tiny improvement suggested);

Please help us reduce the pending PRs stack by reviewing some of them 😸

@rousseldenis
Copy link
Sponsor Contributor

@lreficent @jbeficent Does this conflicts with stock_demand_estimate ?

@rousseldenis rousseldenis added this to the 9.0 milestone Feb 25, 2019
@bealdav
Copy link
Member

bealdav commented Feb 25, 2019

almost ready to be merged, just a small view alert. Thanks fo your work

@rousseldenis
Copy link
Sponsor Contributor

rousseldenis commented Feb 25, 2019

@bealdav It was fixed by @gurneyalex at f48d027.
@gfcapalbo Could you rebase ?

@bealdav
Copy link
Member

bealdav commented Feb 25, 2019

My purpose was just that, thanks
openerp_test openerp.addons.base.ir.ir_ui_view: Element '<xpath expr="//field[@name='line_ids']/tree/field[@name='discrepancy_threshold']">' cannot be located in parent view

@rousseldenis
Copy link
Sponsor Contributor

@gfcapalbo Closing this as no activity. Feel free to reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants