Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] [MIG] account move line product: Migration to 11.0 #354

Closed

Conversation

VRodrigo
Copy link

No description provided.

@oca-clabot
Copy link

Hey @VRodrigo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 11.0 milestone Nov 14, 2017
@pedrobaeza pedrobaeza mentioned this pull request Nov 14, 2017
46 tasks
@oca-clabot
Copy link

Hey @VRodrigo,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reivew LGTM

Please squash your migration commits into one.

Thanks!

@@ -0,0 +1,57 @@
.. image:: https://img.shields.io/badge/license-AGPLv3-blue.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to .png image

Images
------

* Odoo Community Association: `Icon <https://github.com/OCA/maintainer-tools/blob/master/template/module/static/description/icon.svg>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to .png image


.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/92/10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10.0 -> 11.0 version change

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine to me, pending for runbot for functional

@pedrobaeza
Copy link
Member

There are still comments unattended.

@JordiBForgeFlow
Copy link
Sponsor Member

@VRodrigo can you address the minor comments? We're almost ready to merge.

@emagdalenaC2i
Copy link

@pedrobaeza I think this PR should be closed because this module is already merged in #471

@pedrobaeza pedrobaeza closed this Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants