[11.0] [MIG] stock_quant_manual_assign #361

fanha99 · 2017-12-28T12:25:43Z

[11.0] [MIG] stock quant manual assign
please help to check, thx.

NOTE: in v11, the stock_quant is take different role in compare to v10.
This module must be stock lot/serial manual assign

… the wizard of "quants Manual" and check availability.

* Extended usage in README

…automatically

Conforms to the latest README template: bugtracker, runbot etc. Fixes bugtracker URL on some modules. States OCA as maintainer, removes other contributors from the 'Maintainer' section.

* Fix uom issue * Convert move quantity in the default product uom to use the same uom as quant

[FIX] test_flake8 [FIX] - use the already existing field product_qty - fix picking edition by warehouse user due to related none readonly field

pedrobaeza · 2017-12-28T12:34:30Z

You can review other PRs and ask in exchange that they review yours

fanha99 · 2017-12-28T13:32:37Z

Hi,
Am I need to fix all the test_flake8 in the Travis-CI, most of them is "line too long (96 > 79 characters)"?

2 other Travis-CI report is relative to the "test_stock_quant_manual_assign.py" which is from v9.0 -> v10.0. I just don't know how to use them. is there any document about the it? Is that good to remove them?

pedrobaeza · 2017-12-28T13:37:38Z

You should fix everything, and test shouldn't be removed, but fixed. Tests assures that everything goes correct. Tests can fail because:

The migration is not correct and it's not covering the expected results.
Something in the code has changed (field names, model names, method names...) and you need to adapt the test to this new situation.

rousseldenis · 2017-12-29T15:43:38Z

@fanha99 The quantity field in stock.quant model has changed.

It's called 'quantity' now (old name : qty).

fanha99 · 2017-12-30T04:47:15Z

@rousseldenis, thanks. I can run the test now. but there are still bugs
is there a document online about how to debug the test?

fanha99 · 2018-02-09T16:07:17Z

@DbTechGit you can try this module to "lock" assigned serial

rousseldenis · 2018-10-02T07:39:31Z

@fanha99 Is this ok ?

fanha99 · 2018-10-03T12:32:59Z

@rousseldenis : i'm using this module in our production Odoo. I think it is ok for us. :)

it is work well on PC, but not good on the mobile interface (as some problem with the kanban refresh)
it will not work in case the stock move don't have the init demand quantity. because the module check and don't allow user to transfer the quantity is bigger then init demand quantity.

rousseldenis

Code review

rousseldenis · 2018-10-05T08:29:29Z

stock_quant_manual_assign/wizard/assign_manual_quants.py

-        self.env['stock.quant'].quants_reserve(quants, move)
+        move._do_unreserve()
+        for line in self.quants_lines:
+            if line.qty > 0:


@fanha99 Please use float_compare

should I use math.isclose(line.qty, 0.0, rel_tol=1e-6)
the math.isclose is with the python 3.5

No, Odoo orm uses a layer on top of some float fields to interpret what is stored in database. These fields are defined with decimal precision. So, to interpret values, you have to use orm-integrated functions as float_compare. Other libraries are useless.

rousseldenis · 2018-10-05T08:32:37Z

stock_quant_manual_assign/wizard/assign_manual_quants.py

+                    move.product_id,
+                    move.location_id,
+                    lot_id=line.lot_id)
+                if available_quantity <= 0:


Maybe a float_compare on this should be used too

rousseldenis · 2018-10-05T08:37:18Z

stock_quant_manual_assign/wizard/assign_manual_quants.py

+            line['qty'] = 0
+            move_lines = move.move_line_ids.filtered(
+                lambda ml:
+                ml.location_id == x.location_id and ml.lot_id == x.lot_id)


I think this is too restrictive (or I don't understand the flow) ? IMHO you have to add condition as you maybe want to match quants that don't have lot if move line has no lot.

... and (ml.lot_id == False and x.lot_id = False or ml.lot_id == x.lot_id)

multi locations?
when the delivery order is form location A, you could not choice the product from location B to send out.

On move lines, you can have multiple locations if products come from children of move location.

Try to store product A in STOCK > Shelf 1 and product B in STOCK > Shelf 2. Create a picking from stock to out with product A and product B.

Moves are from stock to out and move lines are from children locations.

these lines of code is getting the correct reserved quant/lot info (form previous action) and display to the wizard form.

rousseldenis · 2018-10-05T08:41:45Z

stock_quant_manual_assign/tests/test_stock_quant_manual_assign.py

-            wizard.lines_qty)
-        for quant in self.move.reserved_quant_ids:
-            self.assertTrue(quant in selected_quants)
+        # self.assertEqual(len(wizard.quants_lines.filtered('selected')),


Please remove comments if they are not needed

rousseldenis · 2018-10-05T08:43:28Z

stock_quant_manual_assign/wizard/assign_manual_quants_view.xml

-                            <field name="in_date" />
-                            <field name="lot_id" />
-                            <field name="package_id" />
+                            <field name="lot_id" readonly="1"/>


Why changing to readonly from v10 ? Is the flow changed ?

these fields were set to readonly in the python code. Just not remember why need to set readonly the the xml view too. maybe there are bugs or somethings else.
will double check.
there are 10 months since the last commit (Dec 28, 2017).

Ok, no problem. Try to make this merged.

cubells · 2018-10-11T09:08:49Z

@fanha99 can I push to this repository and finish this pull request?

fanha99 · 2018-10-11T11:05:19Z

@cubells : yes, please :)

LoisRForgeFlow · 2018-11-09T16:50:35Z

@fanha99 Thanks for the work here!

I just tested it on runbot and it does not work as I expected if you select quants in sublocations. Example:

In the example above I select the quant in the small refrigerator and confirm. After that the quantity reserved is still 0.

pedrobaeza · 2018-11-09T16:54:16Z

This is because there's no stock.move.line created.

rousseldenis

Code review. LGTM. Could you attend @lreficent remarks?

rousseldenis · 2018-11-10T07:21:17Z

stock_quant_manual_assign/__init__.py

@@ -0,0 +1,5 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory


This is not relevant

pedrobaeza · 2018-11-10T11:05:39Z

@rousseldenis I don't think this is working properly. See our previous comments.

cubells · 2018-11-10T12:11:35Z

I'm working on a pr to approve this pr.

cubells · 2018-11-12T06:28:43Z

Superseded by #508

avanzosc1 and others added 29 commits December 28, 2017 19:16

[mod] added qty control

b67238b

[mod]

2f47602

[mod] _rec_name

7730e96

[mod] new_api

11ef052

[fix] null lines error and remaining qty assign

8324fc0

[MOD] Fixed some problems when there are quants with diferente histories

d54db24

[IMP] Expand AUTHORS

d717c68

[IMP] stock_quant_manual_assign: Delete picking operations to confirm…

e01c637

… the wizard of "quants Manual" and check availability.

OCA Transbot updated translations from Transifex

b848fbd

[IMP] stock_quant_manual_assign: added tests

6441412

[IMP] stock_quant_manual_assign: Tests for missing cases

2a373d4

[IMP] stock_quant_manual_assign:

7b4dcce

* Extended usage in README

OCA Transbot updated translations from Transifex

ccc98b7

[IMP] stock_quant_manual_assign: Add lot and package to selection view

f2c28d2

[FIX] stock_quant_manual_assign: lot_id and package_id not populated …

527e657

…automatically

Update READMEs

767de97

Conforms to the latest README template: bugtracker, runbot etc. Fixes bugtracker URL on some modules. States OCA as maintainer, removes other contributors from the 'Maintainer' section.

OCA Transbot updated translations from Transifex

296b4de

OCA Transbot updated translations from Transifex

9c1ead7

[FIX] stock_quant_manual_assign: Search in all child locations

5798df4

OCA Transbot updated translations from Transifex

45d87e8

[MOV] stock_quant_manual_assign: make module uninstallable

a1f2d44

[FIX] remove en.po that was erroneously created by transbot

a791453

[MIG] Rename manifest files

b5b0d59

[9.0][MIG] stock_manual_assign: Migration to 9.0

932d9ea

* Fix uom issue * Convert move quantity in the default product uom to use the same uom as quant

[FIX] computation of remaining qty

f89762e

[FIX] test_flake8 [FIX] - use the already existing field product_qty - fix picking edition by warehouse user due to related none readonly field

Fix: avoid remove assigned lots on manual assignement

6070d83

[FIX] stock_quant_manual_assign: computed field is not the same

3e88c3b

[CHG] stock_quant_manual_assign: Update copyright and author

0a3473b

[10.0][MIG] stock_quant_manual_assign: Migration to 10.0

e88bf59

pedrobaeza mentioned this pull request Dec 28, 2017

Migration to version 11.0 #343

Closed

46 tasks

pedrobaeza added this to the 11.0 milestone Dec 28, 2017

pedrobaeza added the needs review label Dec 28, 2017

fanha99 force-pushed the 11.0-mig-stock_quant_manual_assign branch from fb31d5e to 340afb7 Compare January 6, 2018 15:37

fanha99 force-pushed the 11.0-mig-stock_quant_manual_assign branch from 340afb7 to 7850ab9 Compare July 23, 2018 10:24

rousseldenis requested changes Oct 5, 2018

View reviewed changes

11.0-mig-stock_quant_manual_assign

4a3a6d2

fanha99 force-pushed the 11.0-mig-stock_quant_manual_assign branch from aea7c2e to 4a3a6d2 Compare October 17, 2018 09:09

LoisRForgeFlow changed the title ~~[11.0] [MIG] stock quant manual assign~~ [11.0] [MIG] stock_quant_manual_assign Nov 9, 2018

rousseldenis approved these changes Nov 10, 2018

View reviewed changes

cubells mentioned this pull request Nov 12, 2018

[MIG] stock_quant_manual_assign: Migration to 11.0 #508

Merged

pedrobaeza closed this Nov 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0] [MIG] stock_quant_manual_assign #361

[11.0] [MIG] stock_quant_manual_assign #361

fanha99 commented Dec 28, 2017 •

edited

pedrobaeza commented Dec 28, 2017

fanha99 commented Dec 28, 2017

pedrobaeza commented Dec 28, 2017

rousseldenis commented Dec 29, 2017

fanha99 commented Dec 30, 2017

fanha99 commented Feb 9, 2018

rousseldenis commented Oct 2, 2018

fanha99 commented Oct 3, 2018 •

edited

rousseldenis left a comment

rousseldenis Oct 5, 2018

fanha99 Oct 9, 2018

rousseldenis Oct 9, 2018

rousseldenis Oct 5, 2018

rousseldenis Oct 5, 2018

fanha99 Oct 9, 2018

rousseldenis Oct 9, 2018

fanha99 Oct 10, 2018

rousseldenis Oct 5, 2018

rousseldenis Oct 5, 2018

fanha99 Oct 9, 2018

rousseldenis Oct 9, 2018

cubells commented Oct 11, 2018

fanha99 commented Oct 11, 2018

LoisRForgeFlow commented Nov 9, 2018

pedrobaeza commented Nov 9, 2018

rousseldenis left a comment

rousseldenis Nov 10, 2018

pedrobaeza commented Nov 10, 2018

cubells commented Nov 10, 2018

cubells commented Nov 12, 2018

[11.0] [MIG] stock_quant_manual_assign #361

[11.0] [MIG] stock_quant_manual_assign #361

Conversation

fanha99 commented Dec 28, 2017 • edited

pedrobaeza commented Dec 28, 2017

fanha99 commented Dec 28, 2017

pedrobaeza commented Dec 28, 2017

rousseldenis commented Dec 29, 2017

fanha99 commented Dec 30, 2017

fanha99 commented Feb 9, 2018

rousseldenis commented Oct 2, 2018

fanha99 commented Oct 3, 2018 • edited

rousseldenis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cubells commented Oct 11, 2018

fanha99 commented Oct 11, 2018

LoisRForgeFlow commented Nov 9, 2018

pedrobaeza commented Nov 9, 2018

rousseldenis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 10, 2018

cubells commented Nov 10, 2018

cubells commented Nov 12, 2018

fanha99 commented Dec 28, 2017 •

edited

fanha99 commented Oct 3, 2018 •

edited