Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] stock_warehouse_orderpoint_stock_info #376

Merged

Conversation

mpanarin
Copy link

migration to Odoo 11

removed innecessary data
Domain on filter mistaken
Expand AUTHORS
Changed email
@pedrobaeza pedrobaeza added this to the 11.0 milestone Feb 14, 2018
@pedrobaeza pedrobaeza mentioned this pull request Feb 14, 2018
46 tasks
@mpanarin mpanarin force-pushed the 11.0-mig-stock_warehouse_orderpoint_stock_info branch from bbc21ec to 028906a Compare February 14, 2018 12:58
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments as I see this is mostly a syntax refactor.



class TestStockWarehouseOrderpoint(common.TransactionCase):
class TestStockWarehouseOrderpoint(SavepointCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why you are moving to Savepointcase?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faster than TransactionCase as the setup can be done only once for all tests (here there's only 1 test but if a test is added, direct benefit)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough! thanks

product_location_qty = fields.Float(
string='Quantity On Location',
compute='_compute_product_available_qty')
compute='_compute_product_available_qty'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you move to that pro-git-diffs syntax do not forget to use trailing commas.

@LoisRForgeFlow LoisRForgeFlow changed the title 11.0 mig stock warehouse orderpoint stock info [11.0][MIG] stock_warehouse_orderpoint_stock_info Feb 14, 2018
@yvaucher
Copy link
Member

@mpanarin could you squash the translation commits "OCA Transbot updated translations from Transifex"

Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please just squash the translation commits and your !squash commit for licenses

@mpanarin mpanarin force-pushed the 11.0-mig-stock_warehouse_orderpoint_stock_info branch from 028906a to 0b55a29 Compare February 19, 2018 13:55
@mpanarin
Copy link
Author

@yvaucher i squashed the commit. Those transifex commits are not actually one after another. Github weirdly shows the tree here. You can see in commits tab

@yvaucher
Copy link
Member

@mpanarin you can reorder those commits anyway :)

To do this a git rebase -i will do. In your editor you can move the commits up and down by cut and paste the line somewhere else.

In this can we shouldn't have conflicts as those commits are updating the same files.
As long as you make sure to keep the same order.

Then once you have them grouped, you can do the usual squashing.

Here you probably want to move down

78fecce, 51f54b2 and 773d088

just before

7f86803

With this result:

[...]
pick 78fecce
f 51f54b2
f 773d088
f 7f86803
[...]

pedrobaeza and others added 8 commits February 19, 2018 16:25
…opied travis from wip * added translation status to readme
stock_warehouse_orderpoint_stock_info: Search orderpoint rules by product category
tested computation for product availability.
field available cannot be a stored field.
remove field 'available', as it was not correctly defined
remove unused method
@mpanarin mpanarin force-pushed the 11.0-mig-stock_warehouse_orderpoint_stock_info branch from 0b55a29 to 07e2799 Compare February 19, 2018 14:25
@guewen guewen merged commit 8fa301d into OCA:11.0 Feb 20, 2018
LRovira-PlanetaTIC pushed a commit to PlanetaTIC/stock-logistics-warehouse that referenced this pull request May 15, 2020
…auto_fill_form_view_zak

[10.0][REF]stock_pack_operation_auto_fill: move auto fill button to header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet