-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] stock_warehouse_orderpoint_stock_info #376
[11.0][MIG] stock_warehouse_orderpoint_stock_info #376
Conversation
removed innecessary data Domain on filter mistaken Expand AUTHORS Changed email
bbc21ec
to
028906a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments as I see this is mostly a syntax refactor.
|
||
|
||
class TestStockWarehouseOrderpoint(common.TransactionCase): | ||
class TestStockWarehouseOrderpoint(SavepointCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering why you are moving to Savepointcase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faster than TransactionCase as the setup can be done only once for all tests (here there's only 1 test but if a test is added, direct benefit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough! thanks
product_location_qty = fields.Float( | ||
string='Quantity On Location', | ||
compute='_compute_product_available_qty') | ||
compute='_compute_product_available_qty' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you move to that pro-git-diffs syntax do not forget to use trailing commas.
@mpanarin could you squash the translation commits "OCA Transbot updated translations from Transifex" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please just squash the translation commits and your !squash commit for licenses
028906a
to
0b55a29
Compare
@yvaucher i squashed the commit. Those transifex commits are not actually one after another. Github weirdly shows the tree here. You can see in commits tab |
@mpanarin you can reorder those commits anyway :) To do this a In this can we shouldn't have conflicts as those commits are updating the same files. Then once you have them grouped, you can do the usual squashing. Here you probably want to move down just before With this result:
|
…opied travis from wip * added translation status to readme
stock_warehouse_orderpoint_stock_info: Search orderpoint rules by product category
tested computation for product availability.
field available cannot be a stored field. remove field 'available', as it was not correctly defined remove unused method
0b55a29
to
07e2799
Compare
…auto_fill_form_view_zak [10.0][REF]stock_pack_operation_auto_fill: move auto fill button to header
migration to Odoo 11