[11.0] [MIG] stock orderpoint uom #386
Conversation
bodedra
force-pushed
the
11.0-mig-stock_orderpoint_uom
branch
from
39fd1d8
to
6803e25
Compare
|
@bodedra I wanted to try out the module and do a review, but I keep having a weird behaviour. Although the value here is 9 : https://github.com/OCA/stock-logistics-warehouse/pull/386/files#diff-ace9f064ade2bd0ba24d6a8148f9c701R16 Any idea ? |
| Bugs are tracked on `GitHub Issues | ||
| <https://github.com/OCA/stock-logistics-warehouse/issues>`_. In case of trouble, please | ||
| check there if your issue has already been reported. If you spotted it first, | ||
| help us smashing it by providing a detailed and welcomed feedback. |
| [('orderpoint_id', '=', orderpoint.id), | ||
| ('order_id', '=', purchase.id)]) | ||
| self.assertEquals(len(purchase_line), 1) | ||
| self.assertEqual(purchase_line.product_qty, 2.0) |
There was a problem hiding this comment.
use assertAlmostEqual for float comparsions
There was a problem hiding this comment.
I have changed from 2.0 to 2
stock_orderpoint_uom/__manifest__.py
Outdated
| "version": "11.0.1.0.0", | ||
| "author": "Eficent, " | ||
| "Odoo Community Association (OCA)", | ||
| "website": "https://www.odoo-community.org", |
There was a problem hiding this comment.
There was a problem hiding this comment.
Well it took me a while to figure it out, so please cherry-pick this commit grindtildeath@e520445 (as I can't open a PR on your repo) to go faster.
| product_qty = orderpoint.product_uom._compute_quantity( | ||
| product_qty, orderpoint.procure_uom_id) | ||
| return super(ProcurementGroup, self).run(product_id, product_qty, | ||
| product_uom, location_id, |
There was a problem hiding this comment.
This should be orderpoint.procure_uom_id
Because product_qty here is updated to the new UOM while product_uom stays the same...
| sched = self.env['procurement.order'] | ||
| sched.run_scheduler() | ||
| proc = sched.search([('product_id', '=', self.productA.id)]) | ||
| self.assertEqual(proc.product_uom, self.uom_dozen) |
There was a problem hiding this comment.
Well, had you kept this replacing proc with purchase_line, the test would have failed because of the uom of the purchase is not the procure_uom of the orderpoint. 👎
bodedra
force-pushed
the
11.0-mig-stock_orderpoint_uom
branch
3 times, most recently
from
b36b739
to
bb2056f
Compare
bodedra
force-pushed
the
11.0-mig-stock_orderpoint_uom
branch
from
bb2056f
to
ba59b52
Compare
stock_orderpoint_uom/__manifest__.py
Outdated
| "version": "11.0.1.0.0", | ||
| "author": "Eficent, " | ||
| "Odoo Community Association (OCA)", | ||
| "website": "https://www.odoo-community.org", |
There was a problem hiding this comment.
No description provided.