-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0 mig stock partner lot #419
11.0 mig stock partner lot #419
Conversation
Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests And also check Travis status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
quant_count = fields.Integer('Owned Products', | ||
compute='_compute_quant_count') | ||
|
||
@api.multi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please depends on quant_ids
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my, yes the quant_count should updated when the value of quant_ids has changed, ill revise it and the description, thanks @rousseldenis
|
||
@api.multi | ||
def _compute_quant_count(self): | ||
"""compute the quant each of partnet""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe 'Compute the quants length for each partner'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends updated
7d5aa63
to
01cc9dc
Compare
({'no_reset_password': True, 'mail_create_nosubscribe': True}) | ||
user = self.env['res.users'].with_context( | ||
{'no_reset_password': True, 'mail_create_nosubscribe': True} | ||
) | ||
self.purchase_user = user.create({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code unused i think self.purchase_user
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you plan to use this user to create data you should add ...sudo(self.purchase_user).create...
at L41
01cc9dc
to
c4c1bb2
Compare
Hello! So this module won't have any effect. Can you confirm this is working for you as expected and owner_id is set on your move lines/quants? If so, do you have special configuration? Thanks for your insights! edit: nevermind found the configuration. Should have read the module readme.. |
@agungrachmatulah Can you attend comments ? |
@agungrachmatulah |
1 similar comment
@agungrachmatulah |
Closing this as it's quite old. Feel free to reopen it if needed |
Migrating and adding Unit Test