Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fix a bug when iterate the data with call create #466

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

nicomacr
Copy link

Fix a bug when call the create method with data dict, in each iteration modify data dict.

@rousseldenis rousseldenis added this to the 9.0 milestone Aug 23, 2018
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@rousseldenis
Copy link
Sponsor Contributor

@nicomacr Can you put maybe a stack trace you had or a little bit explain what happen.

Because data is a copy yet. And just the product_id is modified on each itearation.

@nicomacr
Copy link
Author

@rousseldenis what is happening is that when you call the create in each iteration the value "data" is overwritten somewhere in the create method and brings values ​​that then give error, like for example the followers of the models.

@rousseldenis
Copy link
Sponsor Contributor

@nicomacr Ok, that makes sense obviously!

@pedrobaeza
Copy link
Member

Do you know why Travis is red?

Copy link
Contributor

@zaoral zaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks @nicomacr

@pedrobaeza It seems like this error is in 11.0 branch already, is not introduced by this change. You can see this in travis

Best Regards

@zaoral
Copy link
Contributor

zaoral commented Aug 24, 2018

Who has permissions to re run travis 9.0 branch?
the last 9.0 run was a month ago. There is a change that this error was introduced in this month and that we do not notice?

It seems like this PR solve it #467
Thanks @rousseldenis

@pedrobaeza pedrobaeza merged commit 177be5f into OCA:9.0 Aug 27, 2018
@pedrobaeza
Copy link
Member

Yes, it's OK, thanks.

@zaoral zaoral deleted the 9.0-h-12803-nmr branch August 27, 2018 12:14
cubells pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Sep 27, 2018
cubells pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Sep 27, 2018
cubells pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Sep 27, 2018
chienandalu pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Dec 16, 2019
victoralmau pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Oct 27, 2020
ThomasBinsfeld pushed a commit to acsone/stock-logistics-warehouse that referenced this pull request Mar 23, 2021
ThomasBinsfeld pushed a commit to acsone/stock-logistics-warehouse that referenced this pull request Mar 23, 2021
ThomasBinsfeld pushed a commit to acsone/stock-logistics-warehouse that referenced this pull request Mar 23, 2021
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
chienandalu pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Feb 1, 2023
sergiocorato pushed a commit to sergiocorato/stock-logistics-warehouse that referenced this pull request Oct 20, 2023
sergiocorato pushed a commit to sergiocorato/stock-logistics-warehouse that referenced this pull request Nov 6, 2023
sergiocorato pushed a commit to sergiocorato/stock-logistics-warehouse that referenced this pull request Nov 6, 2023
sergiocorato pushed a commit to sergiocorato/stock-logistics-warehouse that referenced this pull request Nov 6, 2023
bguillot pushed a commit to akretion/stock-logistics-warehouse that referenced this pull request Feb 8, 2024
astirpe pushed a commit to astirpe/stock-logistics-warehouse that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants