-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] fix a bug when iterate the data with call create #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
@nicomacr Can you put maybe a stack trace you had or a little bit explain what happen. Because data is a copy yet. And just the product_id is modified on each itearation. |
@rousseldenis what is happening is that when you call the create in each iteration the value "data" is overwritten somewhere in the create method and brings values that then give error, like for example the followers of the models. |
@nicomacr Ok, that makes sense obviously! |
Do you know why Travis is red? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks @nicomacr
@pedrobaeza It seems like this error is in 11.0 branch already, is not introduced by this change. You can see this in travis
Best Regards
Who has permissions to re run travis 9.0 branch? It seems like this PR solve it #467 |
Yes, it's OK, thanks. |
Fix a bug when call the create method with data dict, in each iteration modify data dict.