Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the translation template files and Finnish translations #49

Merged
merged 1 commit into from
Jul 14, 2015

Conversation

mlaitinen
Copy link
Contributor

Added the translation template files and Finnish translations to stock_reserve and stock_reserve_sale.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.41% when pulling 4f94622 on mlaitinen:8.0 into a7272f4 on OCA:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.41% when pulling 4f94622 on mlaitinen:8.0 into a7272f4 on OCA:8.0.

@pedrobaeza
Copy link
Member

👍

@yvaucher
Copy link
Member

Technically 👍
Thanks

@yvaucher
Copy link
Member

yvaucher commented Jun 1, 2015

@mlaitinen Is it wanted to add those 2 last non translation commits ?

Maybe you could add them in another PR

@mlaitinen
Copy link
Contributor Author

No, sorry. It's unintentional and happened because I'm a bit noobish with
GitHub pull requests. Should I cancel this pull request and create separate
pull requests using feature branching, or do you have a better idea?
On Jun 1, 2015 12:04 PM, "Yannick Vaucher" notifications@github.com wrote:

@mlaitinen https://github.com/mlaitinen Is it wanted to add those 2
last non translation commits ?

Maybe you could add them in another PR


Reply to this email directly or view it on GitHub
#49 (comment)
.

@pedrobaeza
Copy link
Member

Please rebase and solve the current issues

@mlaitinen
Copy link
Contributor Author

Yes! Finally made it. My first rebase and I didn't even get hurt.

pedrobaeza added a commit that referenced this pull request Jul 14, 2015
Added the translation template files and Finnish translations
@pedrobaeza pedrobaeza merged commit ad2d9ad into OCA:8.0 Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants