11.0 mig stock move location WIP #522

mpanarin · 2019-01-02T08:40:39Z

WIP of migration and refactoring for the old module with additional functionality

fix known issue with reservations
improve readme info
add docs
get tests up

stock_move_location/models/stock_inventory.py

stock_move_location/tests/test_common.py

stock_move_location/tests/test_move_location.py

stock_move_location/wizard/stock_move_location.py

simahawk · 2019-01-08T07:27:02Z

stock_move_location/wizard/stock_move_location.py

+
+        product_data = []
+        for group in grouped_quants_data:
+            quants = quants_obj.search(group.get("__domain"))


seems that quants is needed only for the sum: can't you select it straight instead of using sum+mapped?

stock_move_location/wizard/stock_move_location.py

simahawk · 2019-01-08T07:30:31Z

stock_move_location/wizard/stock_move_location.py

+    def add_lines(self):
+        self.ensure_one()
+        if not self.stock_move_locaiton_line_ids:
+            for line_val in self._get_stock_move_location_lines_values():


how many records do we expect to create potentially? This can be reaaaaally heavy w/ all the writes and the computations after hand. We could do a multiple insert via SQL then trigger recompute on newly created records.

@mpanarin any answer to this?

To be honest - I don't know about the number of lines. That depends on the workflow of the end user.

I minimized the amount of creates. So here - only lines of the wizards are created and nothing more. As well as i switched from inventories to pickings, which are less heavy.

Switching to sql inserts is not worth it in my opinion anyway :\

@simahawk I think this operation is not an usual one. If your stock locations are fine tuned (just some product or just one in a same location), the solution is quite acceptable

simahawk · 2019-01-08T07:30:57Z

stock_move_location/wizard/stock_move_location.py

+    def set_inventory_lines(self, inventory):
+        inventory_line_obj = self.env["stock.inventory.line"]
+        for line_vals in self._get_inventory_lines_values(inventory):
+            inventory_line_obj.create(line_vals)


simahawk · 2019-01-08T07:31:28Z

stock_move_location/wizard/stock_move_location.py

+            return available_qty
+        return line.move_quantity
+
+    def _get_quants(self, line):


again: can't you just select the sum?

stock_move_location/wizard/stock_move_location_line.py

stock_move_location/wizard/stock_move_location.py

simahawk · 2019-01-09T10:49:33Z

stock_move_location/wizard/stock_move_location.py

+                'max_quantity': group.get("sum"),
+                'origin_location_id': self.origin_location_id.id,
+                'destination_location_id': self.destination_location_id.id,
+                # cursor returns None instead of False


None is fine anyway

simahawk · 2019-01-09T10:49:58Z

stock_move_location/wizard/stock_move_location.py

+    def add_lines(self):
+        self.ensure_one()
+        if not self.stock_move_locaiton_line_ids:
+            for line_val in self._get_stock_move_location_lines_values():


@mpanarin any answer to this?

Tonow-c2c

Just answer to @simahawk question and remove the README.rst and for me it's ok

stock_move_location/tests/test_common.py

rousseldenis · 2019-01-10T10:38:50Z

stock_move_location/wizard/stock_move_location.py

+    def _get_stock_move_location_lines_values(self):
+        product_obj = self.env['product.product']
+
+        # Using sql as search_group doesn't support aggregation functions


@mpanarin You can use the read_group function. The aggregation function by default for float fields is 'sum'. See https://github.com/odoo/odoo/blob/9246375b25f4e90000bb6e578aceb8a116dfc28a/odoo/fields.py#L1182

rousseldenis · 2019-01-10T10:44:13Z

stock_move_location/wizard/stock_move_location.py

+        FROM stock_quant
+        WHERE location_id = {location_id} AND company_id = {company_id}
+        GROUP BY product_id, lot_id
+        """.format(


@mpanarin If you use cr.execute, pass parameters as second argument of the function.

stock_move_location/wizard/stock_move_location_line.py

rousseldenis · 2019-01-10T10:55:28Z

@mpanarin I'm not sure if the implementation is the right one.

I would have done something different like :

A new parameter on stock picking types : 'Product Change Location' (with a little help).
With this, you can go to the dashboard, create a picking with that type.
Add a button which is visible with that type that fill in the picking as you did.

So, the flow respect the standard one and maybe is more intuitive for the user.

Moreover, you can add a magic button on locations that with context creates a new picking of that type with the origin location already filled in.

What do you think about ?

rousseldenis · 2019-01-16T20:41:06Z

stock_move_location/wizard/stock_move_location_line.py

+        for record in self:
+            if (float_compare(
+                    record.move_quantity,
+                    record.max_quantity, 3


@mpanarin You cannot hardcode rounding. As it concerns moves, I think you should use product uom rounding.

…wizard

…om the wizard

sebalix · 2019-01-25T08:50:16Z

@rousseldenis I continue the work started by @mpanarin . It has been stated that your proposal is the good approach, but we are lacking of time to do it, so we think to keep it as it is for now, I added a roadmap with your suggestions.
I made another PR by rebasing/squashing current work: #535

rousseldenis · 2019-01-25T08:55:31Z

@mpanarin Can we close this ?

sebalix · 2019-01-25T08:59:13Z

@rousseldenis you can, @mpanarin is on leave for a few days :)

[ADD] stock_move_location

b0c8e5e

pedrobaeza added this to the 11.0 milestone Jan 2, 2019

pedrobaeza mentioned this pull request Jan 2, 2019

Migration to version 11.0 #343

Closed

46 tasks

mpanarin force-pushed the 11.0-mig-stock_move_location branch 2 times, most recently from 565365e to e90fd70 Compare January 4, 2019 10:14

simahawk requested changes Jan 8, 2019

View reviewed changes

[MIG] 11.0 stock_move_location

9966b79

mpanarin force-pushed the 11.0-mig-stock_move_location branch from 8cbd95b to 939e76a Compare January 9, 2019 00:07

simahawk reviewed Jan 9, 2019

View reviewed changes

Tonow-c2c reviewed Jan 10, 2019

View reviewed changes

stock_move_location/tests/test_common.py Outdated Show resolved Hide resolved

[IMP] refactor to use pickings instead of inventories

188b7f2

mpanarin force-pushed the 11.0-mig-stock_move_location branch from e0389f2 to 188b7f2 Compare January 10, 2019 10:13

rousseldenis reviewed Jan 10, 2019

View reviewed changes

stock_move_location/wizard/stock_move_location_line.py Outdated Show resolved Hide resolved

mpanarin added 3 commits January 16, 2019 14:29

fixup! [IMP] refactor to use pickings instead of inventories

84716ff

prevent user from creating lots from the wizard

4e6bc40

fixup! prevent user from creating lots from the wizard

1fefc72

rousseldenis reviewed Jan 16, 2019

View reviewed changes

mpanarin added 4 commits January 21, 2019 16:49

fixup! fixup! prevent user from creating lots from the wizard

82604b2

fixup! fixup! fixup! prevent user from creating lots from the wizard

452dc76

fixup! fixup! fixup! fixup! prevent user from creating lots from the …

af5ec7a

…wizard

fixup! fixup! fixup! fixup! fixup! prevent user from creating lots fr…

7709e1a

…om the wizard

sebalix mentioned this pull request Jan 25, 2019

[11.0][MIG] stock_move_location #535

Merged

rousseldenis closed this Jan 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

11.0 mig stock move location WIP #522

11.0 mig stock move location WIP #522

mpanarin commented Jan 2, 2019 •

edited

simahawk Jan 8, 2019

simahawk Jan 8, 2019

simahawk Jan 9, 2019

mpanarin Jan 10, 2019

rousseldenis Jan 10, 2019

simahawk Jan 8, 2019

simahawk Jan 8, 2019

simahawk Jan 9, 2019

simahawk Jan 9, 2019

Tonow-c2c left a comment

rousseldenis Jan 10, 2019

rousseldenis Jan 10, 2019

rousseldenis commented Jan 10, 2019

rousseldenis Jan 16, 2019

sebalix commented Jan 25, 2019

rousseldenis commented Jan 25, 2019

sebalix commented Jan 25, 2019

11.0 mig stock move location WIP #522

11.0 mig stock move location WIP #522

Conversation

mpanarin commented Jan 2, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tonow-c2c left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis commented Jan 10, 2019

Choose a reason for hiding this comment

sebalix commented Jan 25, 2019

rousseldenis commented Jan 25, 2019

sebalix commented Jan 25, 2019

mpanarin commented Jan 2, 2019 •

edited