12.0 mig stock available #540

devang-dreambits · 2019-02-07T11:48:53Z

No description provided.

Generic module to compute the stock quantity available to promise using several implementations. stock_available_immediatly is changed to become the first optional implementation. Cherry pick of commit 0b060f6 from the v7 branch [IMP] stock_available* uses new API [ADD] stock_available_mrp Module to take immediate manufaturing capability into account in the stock quantity available to promise. Conflicts: stock_available/res_config.py [DEL] move stock_available_mrp to __unported__ [ADD] stock_available_sale Take sale quotations into account in the stock quantity available to promise Cherry-picked from 497068f Conflicts: stock_available/res_config.py [DEL] move stock_available_sale to __unported__ [IMP] READMEs and TODOs Cherry-picked from v7 at 8add4be Conflicts: __unported__/stock_available_mrp/__openerp__.py stock_available/__openerp__.py stock_available_immediately/__openerp__.py [IMP] respect product decimal precision odoo/odoo#5512 and odoo-dev/odoo@b3e5a94 makes it clear the standard intends to support decimal precision on the product form.

…uct and product.template, now takes in account variants and correctly displays value. [FLAKE8] Removing duplicate modules and moving README.rst into __unported__ [ADD} location calculations [FIX] typo

not using internal qty_available that seems not to take in consideration reserved quants. [ADD] Tests

Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move). Fixes OCA#79 Remove loop and use correct decorator Restore the features of stock_available_immediately The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly. This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too. Restore the qty avail. to promise on variant treeview PEP8

* fix the dependencies for the computed field * use api.multi instead of api.one to avoid calling super()._immediately_usable_qty in a loop (this improves perfs on a tree view display)

There are cases where we dot NOT want to simply sum the quantities of all the variants. For example when dealing with manufacturing capacities, we may have to chose between variants because we can't make ALL of them with the same components. So instead of a simple non-modular implementation, we'll let each module define his own implementation of how to compute the product template's quantity available for sale. Conflicts: stock_available/__openerp__.py stock_available_immediately/__openerp__.py

…ch field use to compute potential

[CHG] improve code regarding code review [ADD] add test [CHG] optimize stock computation by avoiding to call useless compute

… related unit test Increase version number of the module

Currently translated at 61.9% (13 of 21 strings) Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_available Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_available/ar/

oca-clabot · 2019-02-07T11:48:56Z

Hey @devang-dreambits, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@SodexisTeam
Lionel Sausin (Numérigraphe) ls@numerigraphe.com (no github login found)
Giovanni francesco Capalbo giovanni@intervlag.nl (no github login found)
Laetitia Gangloff laetitia.gangloff@acsone.eu (no github login found)
Lionel Sausin ls@numerigraphe.com (no github login found)
Cyril Gaudin cyril.gaudin@camptocamp.com (no github login found)

Appreciation of efforts,
OCA CLAbot

oca-clabot · 2019-02-07T11:54:49Z

Hey @devang-dreambits, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@SodexisTeam

Appreciation of efforts,
OCA CLAbot

rousseldenis

Code review. Minor comments

rousseldenis · 2019-02-07T16:30:17Z

stock_available/README.rst

@@ -0,0 +1,77 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg


Could you please follow migration guide about readme fragments : https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0 ?

rousseldenis · 2019-02-07T16:31:47Z

stock_available/__manifest__.py

+# Copyright 2016 Sodexis
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+{


Could you please add some missing entries like in https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py#L9

Nikul-Chaudhary

Improve Code

Nikul-Chaudhary · 2019-02-07T16:42:12Z

stock_available/__manifest__.py

+
+{
+    'name': 'Stock available to promise',
+    'version': '12.0.1.0.0',


@devang-dreambits Add website key and URL like https://github.com/OCA/stock-logistics-warehouse

Nikul-Chaudhary · 2019-02-07T16:42:46Z

stock_available/__init__.py

@@ -0,0 +1,5 @@
+# Copyright 2014 Numérigraphe


remove Copyright from all init file

Nikul-Chaudhary · 2019-02-07T16:43:02Z

stock_available/README.rst

+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/153/11.0


ray-odoo · 2019-02-08T17:31:43Z

I will have the opportunity to test this in the next few days. Woo hoo!!

ray-odoo · 2019-02-09T23:11:45Z

When testing this, I noticed that I was unable to set the "Exclude incoming goods" boolean via Inventory --> Settings.

I looked into the module code, and it seems that the configuration option "Exclude incoming goods" is designed to install "stock_available_immediately" when set to TRUE as the help for this boolean is "This installs the module stock_available_immediately.".

I don't see that module in this PR, and I don't see it available for testing at v12.

The User Experience when stock_available_immediately isn't available is to appear to do nothing, as the boolean is not set to True, but the user is provided no warning.

It appears that this module also optionally installs: stock_available_sale, sale_delivery_date, stock_available_mrp but I also don't see these modules available for testing at v12.

So I can't really test until these other modules are available. Do I misunderstand something?

I am going to take a look at stock_available_unreserved in an effort to understand the differences between this module and that one.

…init__.py; added development_status & website in manifest.py

oca-clabot · 2019-03-01T14:26:39Z

Hey @devang-dreambits, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@SodexisTeam

Appreciation of efforts,
OCA CLAbot

rousseldenis · 2019-03-18T16:40:55Z

@devang-dreambits Could you add recent improvements from v10.0 like 29b6bcd#diff-2c6955de963025ce90888f7e13128f22 ?

rousseldenis · 2019-04-27T09:58:29Z

When testing this, I noticed that I was unable to set the "Exclude incoming goods" boolean via Inventory --> Settings.

I looked into the module code, and it seems that the configuration option "Exclude incoming goods" is designed to install "stock_available_immediately" when set to TRUE as the help for this boolean is "This installs the module stock_available_immediately.".

I don't see that module in this PR, and I don't see it available for testing at v12.

The User Experience when stock_available_immediately isn't available is to appear to do nothing, as the boolean is not set to True, but the user is provided no warning.

It appears that this module also optionally installs: stock_available_sale, sale_delivery_date, stock_available_mrp but I also don't see these modules available for testing at v12.

So I can't really test until these other modules are available. Do I misunderstand something?

I am going to take a look at stock_available_unreserved in an effort to understand the differences between this module and that one.

Yes indeed, stock_available module was designed like that and options to install other modules that depend on this are present anyway even if modules are not present.

The good solution should be removing all those options here and adding them in each module. It's clearer for user.

@lreficent @jbeficent @Cedric-Pigeon @devang-dreambits What do you think of this? That could be a good improvement for user experience

rafaelbn · 2019-06-07T11:42:57Z

Please just notice about performance issues with this module:

pedrobaeza · 2019-06-26T19:30:58Z

@karan-dreambits are you interested in continuing this PR? There's another PR for the module in #632 that has an interesting change in the smart-button style, but yours have priority as first in arrive.

karan-dreambits · 2019-06-27T12:24:22Z

@pedrobaeza I see #632 is much better so lets close this and let it supersede this :)
@devang-dreambits Please update our project setup to use the #632 PR instead of this one

sergio-teruel · 2019-06-27T15:10:23Z

@karan-dreambits Please, can you review #632 ??

pedrobaeza · 2019-06-27T15:12:27Z

Thanks for your comprehension, so closing.

Lionel Sausin (Numérigraphe) and others added 26 commits February 7, 2019 16:02

[FIX] corrected calculation of immediately_usable_qty on product.prod…

b9160d0

…uct and product.template, now takes in account variants and correctly displays value. [FLAKE8] Removing duplicate modules and moving README.rst into __unported__ [ADD} location calculations [FIX] typo

[FIX] searching on products, leaving full calculations

56ce006

not using internal qty_available that seems not to take in consideration reserved quants. [ADD] Tests

[FIX] stock_available : update sublocations computation

62eb3ea

OCA Transbot updated translations from Transifex

cb00bcc

[UPD] prefix versions with 8.0

1fb262b

[FIX] stock_available: Fix manifest

653d234

[9.0][PORT] Stock available

6f75811

product_available improvements

1c94d28

* fix the dependencies for the computed field * use api.multi instead of api.one to avoid calling super()._immediately_usable_qty in a loop (this improves perfs on a tree view display)

stock_available / stock_available_mrp : add possibility to choose whi…

8e223d2

…ch field use to compute potential

bom stock: small improvements and add test for field choice

35312c5

[FIX] remove en.po that was erroneously created by transbot

7e42b00

[MIG] Rename manifest files

f60622f

[10.0][MIG] stock_available & stock_available_immediately (OCA#219)

17c5c5d

[10.0]stock_available: improve computation performance

1394373

[CHG] improve code regarding code review [ADD] add test [CHG] optimize stock computation by avoiding to call useless compute

[MIG] stock_available_sale: Migration to 10.0

bc2cc02

[FIX] stock_available: Some affectations

f508def

[ADD] Add search function for immediately_usable_qty computed field +…

c39f7df

… related unit test Increase version number of the module

[MIG] stock_available: Migration to 11.0

5f93ad2

[FIX] Improve migration to 11.0

9ea933f

remove obsolete .pot files [ci skip]

92a394c

[UPD] Update stock_available.pot

9dd524b

Added translation using Weblate (Arabic)

5c9a36c

[MIG] stock_available: Migration 12.0

e4ff621

devang-dreambits force-pushed the 12.0-mig-stock_available branch from 420b5f7 to e4ff621 Compare February 7, 2019 11:54

devang-dreambits mentioned this pull request Feb 7, 2019

Migration to version 12.0 #487

Closed

54 tasks

pedrobaeza added this to the 12.0 milestone Feb 7, 2019

pedrobaeza added the needs review label Feb 7, 2019

rousseldenis requested changes Feb 7, 2019

View reviewed changes

Nikul-Chaudhary reviewed Feb 7, 2019

View reviewed changes

[UPD] updated readme as per guideline; removed copyrights from all __…

9199222

…init__.py; added development_status & website in manifest.py

[UPD] changes added from 10.0 as suggested

9991347

pedrobaeza mentioned this pull request Jun 26, 2019

[12.0][MIG] stock_available: Migration to v12.0 #632

Merged

pedrobaeza closed this Jun 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

12.0 mig stock available #540

12.0 mig stock available #540

devang-dreambits commented Feb 7, 2019

oca-clabot commented Feb 7, 2019

oca-clabot commented Feb 7, 2019

rousseldenis left a comment

rousseldenis Feb 7, 2019

rousseldenis Feb 7, 2019

Nikul-Chaudhary left a comment

Nikul-Chaudhary Feb 7, 2019

Nikul-Chaudhary Feb 7, 2019

Nikul-Chaudhary Feb 7, 2019

ray-odoo commented Feb 8, 2019

ray-odoo commented Feb 9, 2019

oca-clabot commented Mar 1, 2019

rousseldenis commented Mar 18, 2019

rousseldenis commented Apr 27, 2019 •

edited

rafaelbn commented Jun 7, 2019

pedrobaeza commented Jun 26, 2019

karan-dreambits commented Jun 27, 2019

sergio-teruel commented Jun 27, 2019

pedrobaeza commented Jun 27, 2019

		@@ -0,0 +1,77 @@
		.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg

12.0 mig stock available #540

12.0 mig stock available #540

Conversation

devang-dreambits commented Feb 7, 2019

oca-clabot commented Feb 7, 2019

oca-clabot commented Feb 7, 2019

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis Feb 7, 2019

Choose a reason for hiding this comment

rousseldenis Feb 7, 2019

Choose a reason for hiding this comment

Nikul-Chaudhary left a comment

Choose a reason for hiding this comment

Nikul-Chaudhary Feb 7, 2019

Choose a reason for hiding this comment

Nikul-Chaudhary Feb 7, 2019

Choose a reason for hiding this comment

Nikul-Chaudhary Feb 7, 2019

Choose a reason for hiding this comment

ray-odoo commented Feb 8, 2019

ray-odoo commented Feb 9, 2019

oca-clabot commented Mar 1, 2019

rousseldenis commented Mar 18, 2019

rousseldenis commented Apr 27, 2019 • edited

rafaelbn commented Jun 7, 2019

pedrobaeza commented Jun 26, 2019

karan-dreambits commented Jun 27, 2019

sergio-teruel commented Jun 27, 2019

pedrobaeza commented Jun 27, 2019

rousseldenis commented Apr 27, 2019 •

edited