Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_demand_estimate #563

Merged
merged 11 commits into from May 11, 2019
Merged

[12.0][MIG] stock_demand_estimate #563

merged 11 commits into from May 11, 2019

Conversation

MiquelRForgeFlow
Copy link
Contributor

Standard migration.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-stock_demand_estimate branch 3 times, most recently from ac724da to 9ae3897 Compare March 20, 2019 14:15
@rousseldenis rousseldenis added this to the 12.0 milestone Mar 26, 2019
rousseldenis
rousseldenis approved these changes Mar 26, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Minor comments

stock_demand_estimate/wizards/stock_demand_estimate_wizard.py Outdated Show resolved Hide resolved
stock_demand_estimate/__manifest__.py Show resolved Hide resolved
tbaden
tbaden suggested changes Apr 16, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work 👍
i did a code review. here some changes:

stock_demand_estimate/__manifest__.py Show resolved Hide resolved
stock_demand_estimate/models/stock_demand_estimate.py Outdated Show resolved Hide resolved
stock_demand_estimate/security/stock_security.xml Outdated Show resolved Hide resolved
stock_demand_estimate/views/date_range.xml Outdated Show resolved Hide resolved
stock_demand_estimate/views/stock_demand_estimate_view.xml Outdated Show resolved Hide resolved
stock_demand_estimate/views/stock_demand_estimate_view.xml Outdated Show resolved Hide resolved
stock_demand_estimate/wizards/stock_demand_estimate_wizard_view.xml Outdated Show resolved Hide resolved
stock_demand_estimate/wizards/stock_demand_estimate_wizard_view.xml Outdated Show resolved Hide resolved
stock_demand_estimate/wizards/stock_demand_estimate_wizard_view.xml Outdated Show resolved Hide resolved
stock_demand_estimate/wizards/stock_demand_estimate_wizard_view.xml Outdated Show resolved Hide resolved
@rafaelbn
Copy link
Member

Hi @mreficent could you please update branch to resolve conflict? if all is OK and green it could be merged!

@MiquelRForgeFlow
Copy link
Contributor Author

@rafaelbn rebased
@tbaden comments attended

tbaden
tbaden approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review: lgtm

@OCA-git-bot OCA-git-bot mentioned this pull request Apr 26, 2019
Closed
54 tasks
@rousseldenis
Copy link
Sponsor Contributor

@mreficent Do you will squash two last commits or let as is ?

@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Apr 26, 2019 •
edited

As you prefer. I wanted to not squash them in order to maintain your authorship of your contribution.

@rousseldenis
Copy link
Sponsor Contributor

As you prefer. I wanted to not squash them in order to maintain your authorship of your contribution.

Too much honor 😄

@rousseldenis rousseldenis merged commit c615498 into OCA:12.0 May 11, 2019
@LoisRForgeFlow LoisRForgeFlow deleted the 12.0-mig-stock_demand_estimate branch May 13, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow left review comments

@gurneyalex gurneyalex gurneyalex approved these changes

@tbaden tbaden tbaden approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@MiquelRForgeFlow @rafaelbn @rousseldenis @gurneyalex @tbaden @LoisRForgeFlow @OCA-git-bot @JordiBForgeFlow @oca-transbot @oca-travis