[12.0][MIG] stock_account_internal_move #570

kittiu · 2019-04-03T04:12:02Z

Migrate to v12

[IMP] Doc

* Rewrite SQL constraints to Python * Adapt location view to display valuation accounts on internal locations

Treat corresponding valuation account counterparts on internal locations as valuation accounts when a move is `in` or `out`, namely: * treat location's `valuation_in_account` as a valuation on `in` moves, * treat location's `valuation_out_account` as one on `out` moves. Sure, the above takes place only when location has `force_accounting_entries` on it, otherwise vanilla behavior is not to tamper w/.

kittiu · 2019-04-04T03:20:47Z

Migrated

rousseldenis

Code review

tbaden

thanks for the work 👍
code review: lgtm
just the one question (see below)

tbaden · 2019-04-16T18:56:33Z

stock_account_internal_move/models/stock_move.py

+        self.ensure_one()
+        res = super()._run_valuation(quantity)
+        if self._is_internal() and not self.value:
+            # TODO: recheck if this part respects product valuation method


were the todo checked?

Hi, sorry, I am not sure what is the intention of the original author too.
Any hint, @max3903?

gurneyalex

also suggested some typo fixes in the strings

gurneyalex · 2019-04-26T08:26:38Z

stock_account_internal_move/models/stock_location.py

+            if loc.usage != 'internal' and loc.force_accounting_entries:
+                raise ValidationError(_(
+                    'You cannot force accounting entries'
+                    ' on a non-internal locations.'))


Suggested change

' on a non-internal locations.'))

' on a non-internal location.'))

gurneyalex · 2019-04-26T08:26:52Z

stock_account_internal_move/models/stock_location.py

+            if not loc.valuation_in_account_id \
+                    or not loc.valuation_out_account_id:
+                raise ValidationError(_(
+                    'You must provide a valuation in/out accounts'


Suggested change

'You must provide a valuation in/out accounts'

'You must provide a valuation in/out account'

OCA-git-bot · 2019-04-26T08:27:30Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2019-04-26T16:39:10Z

@kittiu Do you plan to attend @gurneyalex comments ?

oca-clabot · 2019-04-26T17:27:31Z

Hey @kittiu, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Artem Kostyuk a.kostyuk@mobilunity.com (no github login found)

Appreciation of efforts,
OCA CLAbot

kittiu · 2019-04-26T17:27:41Z

@kittiu Do you plan to attend @gurneyalex comments ?

Done :)

rousseldenis · 2019-04-26T17:29:11Z

@max3903 Any advice on the TODO ?

rousseldenis · 2019-09-30T11:51:10Z

I think we can merge this.

rousseldenis · 2019-09-30T11:51:32Z

/ocabot merge

OCA-git-bot · 2019-09-30T11:51:50Z

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-570-by-rousseldenis-bump-no, awaiting test results.

Signed-off-by rousseldenis

OCA-git-bot · 2019-09-30T20:35:43Z

Congratulations, your PR was merged at b986233. Thanks a lot for contributing to OCA. ❤️

Signed-off-by pedrobaeza

Artem Kostyuk and others added 22 commits April 3, 2019 11:08

[11.0][ADD] stock_account_internal_move

177ca66

[DOC] Add README parts

c013e37

[COV] Add tests

48839d8

[REF] Split valuation accounts on locations

cae7e74

fixup! [REF] Split valuation accounts on locations

ad4e135

fixup! [REF] Split valuation accounts on locations

032a655

fixup! [REF] Split valuation accounts on locations

b9f57ec

[FIX] Prevent negative qtys from appearing in account.move.lines

23e11d7

[IMP] Prevent valuation of products that never asked for this

6c814f1

fixup! [REF] Split valuation accounts on locations

c72657c

Update test_stock_move_confirmation.py

b37eaed

[FIX] Duplicate field and related constraint

02bd626

[IMP] Doc

[REF] stock_account_internal_move: Reuse fields from stock_account

40671e2

* Rewrite SQL constraints to Python * Adapt location view to display valuation accounts on internal locations

[REF] Split internal logic to proper methods

f1c6b1d

[COV] Update tests

fb3bfdd

fixup! [REF] Split internal logic to proper methods

45467c3

fixup! [REF] Split internal logic to proper methods

c0ccf53

Update stock_location.py

5e6f91c

[UPD] Update stock_account_internal_move.pot

d38052e

[UPD] README.rst

c84b85d

[UPD] README.rst

e327c4f

rousseldenis added this to the 12.0 milestone Apr 3, 2019

OCA-git-bot mentioned this pull request Apr 3, 2019

Migration to version 12.0 #487

Closed

54 tasks

kittiu force-pushed the 12.0-mig-stock_account_internal_move branch from aae7cb8 to 25877e1 Compare April 4, 2019 03:09

rousseldenis added the needs review label Apr 4, 2019

rousseldenis approved these changes Apr 4, 2019

View reviewed changes

tbaden reviewed Apr 16, 2019

View reviewed changes

gurneyalex approved these changes Apr 26, 2019

View reviewed changes

OCA-git-bot added the approved label Apr 26, 2019

gurneyalex reviewed Apr 26, 2019

View reviewed changes

OCA-git-bot added the ready to merge label Apr 26, 2019

[12.0][MIG] stock_account_internal_move

73c68c2

kittiu force-pushed the 12.0-mig-stock_account_internal_move branch from 25877e1 to 73c68c2 Compare April 26, 2019 17:27

OCA-git-bot added a commit that referenced this pull request Sep 30, 2019

Merge PR #570 into 12.0

7a2df8c

Signed-off-by rousseldenis

OCA-git-bot added the merged 🎉 label Sep 30, 2019

OCA-git-bot merged commit 73c68c2 into OCA:12.0 Sep 30, 2019

i-vyshnevska pushed a commit to camptocamp/stock-logistics-warehouse that referenced this pull request Apr 13, 2020

Merge PR OCA#570 into 12.0

4e76a1a

Signed-off-by pedrobaeza

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] stock_account_internal_move #570

[12.0][MIG] stock_account_internal_move #570

kittiu commented Apr 3, 2019 •

edited

kittiu commented Apr 4, 2019

rousseldenis left a comment

tbaden left a comment

tbaden Apr 16, 2019

kittiu Apr 22, 2019

gurneyalex left a comment

gurneyalex Apr 26, 2019

gurneyalex Apr 26, 2019

OCA-git-bot commented Apr 26, 2019

rousseldenis commented Apr 26, 2019

oca-clabot commented Apr 26, 2019

kittiu commented Apr 26, 2019

rousseldenis commented Apr 26, 2019

rousseldenis commented Sep 30, 2019

rousseldenis commented Sep 30, 2019

OCA-git-bot commented Sep 30, 2019

OCA-git-bot commented Sep 30, 2019

	' on a non-internal locations.'))
	' on a non-internal location.'))

	'You must provide a valuation in/out accounts'
	'You must provide a valuation in/out account'

[12.0][MIG] stock_account_internal_move #570

[12.0][MIG] stock_account_internal_move #570

Conversation

kittiu commented Apr 3, 2019 • edited

kittiu commented Apr 4, 2019

rousseldenis left a comment

Choose a reason for hiding this comment

tbaden left a comment

Choose a reason for hiding this comment

tbaden Apr 16, 2019

Choose a reason for hiding this comment

kittiu Apr 22, 2019

Choose a reason for hiding this comment

gurneyalex left a comment

Choose a reason for hiding this comment

gurneyalex Apr 26, 2019

Choose a reason for hiding this comment

gurneyalex Apr 26, 2019

Choose a reason for hiding this comment

OCA-git-bot commented Apr 26, 2019

rousseldenis commented Apr 26, 2019

oca-clabot commented Apr 26, 2019

kittiu commented Apr 26, 2019

rousseldenis commented Apr 26, 2019

rousseldenis commented Sep 30, 2019

rousseldenis commented Sep 30, 2019

OCA-git-bot commented Sep 30, 2019

OCA-git-bot commented Sep 30, 2019

kittiu commented Apr 3, 2019 •

edited