Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0] stock_product_putaway add wizard to mass update putaway on products #583

Merged
merged 1 commit into from
Oct 1, 2019
Merged

[10.0] stock_product_putaway add wizard to mass update putaway on products #583

merged 1 commit into from
Oct 1, 2019

Conversation

PierrickBrun
Copy link
Contributor

No description provided.

@rousseldenis
Copy link
Sponsor Contributor

Nice ! Missing that feature for long (never had time to develop it)

@rousseldenis rousseldenis added this to the 10.0 milestone Apr 30, 2019
@rousseldenis
Copy link
Sponsor Contributor

@PierrickBrun Don't forget to update module version (minor one as new feature)

rousseldenis
rousseldenis requested changes Apr 30, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Should add in Roadmap:

  • Two modes : for the moment, it allows only to select one location for several products. In another mode, you could select different products and then a different location per product (you can have configuration with one location per product).
  • Allow to launch the wizard on product templates (if you don't activate product variants you haven't access to wizard).

stock_putaway_product/wizard/quick_add_location.py Outdated Show resolved Hide resolved
stock_putaway_product/README.rst Show resolved Hide resolved
rousseldenis
rousseldenis approved these changes May 15, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code review

@rousseldenis
Copy link
Sponsor Contributor

@PierrickBrun Do you plan to add tests ?

@rousseldenis
Copy link
Sponsor Contributor

@PierrickBrun

@PierrickBrun
Copy link
Contributor Author

Hi @rousseldenis , I've done the PR but the code is from @bealdav, I don't plan on adding tests for now

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 10.0-ocabot-merge-pr-583-by-rousseldenis-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 30, 2019
@OCA-git-bot
Merge PR #583 into 10.0
49ba332 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-583-by-rousseldenis-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 30, 2019
@OCA-git-bot
Merge PR #583 into 10.0
45788fa 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-583-by-rousseldenis-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019
@OCA-git-bot
Merge PR #583 into 10.0
4e0312f 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-583-by-rousseldenis-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019
@OCA-git-bot
Merge PR #583 into 10.0
8b65a84 
Signed-off-by rousseldenis
@OCA-git-bot OCA-git-bot merged commit 36fda7e into OCA:10.0 Oct 1, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3715a8c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bealdav bealdav bealdav approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PierrickBrun @rousseldenis @OCA-git-bot @bealdav