Allow releasing multiple reservations at once #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix50 Conflicts: stock_reserve_sale/test/sale_reserve.yml
| @@ -132,8 +132,9 @@ def release(self): | |||
| """ | |||
| Release moves from reservation | |||
| """ | |||
| move_recs = self.move_id | |||
| move_recs.action_cancel() | |||
| for rec in self: | |||
There was a problem hiding this comment.
You can do better: self.mapped('move_id').action_cancel()
There was a problem hiding this comment.
Awesome, thanks! I learned about mapped() only after I had originally made this change.
|
👍 |
1 similar comment
|
👍 |
pedrobaeza
added a commit
that referenced
this pull request
Jul 30, 2015
Allow releasing multiple reservations at once
gschrott-osi
pushed a commit
to ursais/stock-logistics-warehouse
that referenced
this pull request
Jun 5, 2023
[FIX] Two openvalue bugs - incorrect model name and fix MO splitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #50