[12.0][MIG] stock_cycle_count: Migration to 12.0 #625

bodedra · 2019-06-24T12:47:20Z

Depends on:

[12.0][MIG] stock_inventory_discrepancy: Migration to 12.0 #622 stock_inventory_discrepancy
[12.0][MIG] stock_inventory_exclude_sublocation: Migration to 12.0 #623 stock_inventory_exclude_sublocation

bodedra · 2019-06-25T08:37:25Z

@jbeficent @lreficent @aheficent

Would you please help me find out root cause to fail ('Zero confirmation not being created.') test case ?

LoisRForgeFlow · 2019-07-05T14:28:13Z

@bodedra just opened a PR to fix the remaining issue: ursais#2. Could you review?

bodedra · 2019-07-05T14:55:06Z

@lreficent

Thanks for your fix.

Now all test case are passed. Still ci/runbot fail.

stock_cycle_count/reports/report_stock_location_accuracy.py

rousseldenis · 2019-07-05T16:30:20Z

stock_cycle_count/models/stock_warehouse.py

@@ -40,8 +39,7 @@ def get_horizon_date(self):
    @api.model
    def _get_cycle_count_locations_search_domain(
            self, parent):
-        domain = [('parent_left', '>=', parent.parent_left),
-                  ('parent_right', '<=', parent.parent_right),
+        domain = [('parent_path', '=like', parent.parent_path + '%'),


I'm wondering why child of/parent of would not works here ?

See https://github.com/odoo/odoo/blob/12.0/odoo/osv/expression.py#L755

@rousseldenis I use it as a reference of https://github.com/odoo/odoo/blob/12.0/addons/stock/models/product.py#L206 and https://github.com/odoo/odoo/blob/12.0/addons/stock/models/product.py#L211

Yeah, that's weird because it's in the same commit that implements parent_path to optimize queries...

Additionally, parent_left and parent_right fields are removed from stock.location object.

Yes, that was the aim of parent_path: to optimize child of/parent of search operators, so, normally, you should use them as before.

so what do you recommend on these ?

rousseldenis

Code review

rousseldenis · 2019-07-05T16:43:57Z

@bodedra Could you squash your commits ?

bodedra · 2019-07-05T16:45:34Z

@rousseldenis Sure.

bodedra · 2019-07-06T08:28:08Z

@rousseldenis @mreficent Thanks for your review and suggestion.

@lreficent can you update your review ?

* Update README. * Fixes: DEFAULT_SERVER_DATETIME_FORMAT, PERCENT variables and sale price calculation.

* simplify fetching latest inventory date * use api.depends where needed * add hook for cycle count creation * take advantage of api.multi on check_zero_confirmation method

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

For avoiding an error validating pickings.

Now zero-qty quants are not removed straight away but by a cron job. Therefore, we have to also check that the quants are not zero-qty ones.

LoisRForgeFlow

LGTM (just fixed history a little to recover my contribution to the migration)

Let's merge after travis goes green.

LoisRForgeFlow · 2019-07-08T07:43:00Z

/ocabot merge

OCA-git-bot · 2019-07-08T07:43:15Z

What a great day to merge this nice PR. Let's do it!
Rebased to 12.0-ocabot-merge-pr-625-by-lreficent-bump-no, awaiting test results.

OCA-git-bot · 2019-07-08T08:38:10Z

Congratulations, your PR was merged at 476dd50. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

Signed-off-by lreficent

Signed-off-by LoisRForgeFlow

bodedra force-pushed the bodedra_12.0-mig-stock_cycle_count branch from 3a1aeb2 to 1836db8 Compare June 24, 2019 12:52

rousseldenis added this to the 12.0 milestone Jun 24, 2019

rousseldenis added the work in progress label Jun 24, 2019

OCA-git-bot mentioned this pull request Jun 24, 2019

Migration to version 12.0 #487

Closed

54 tasks

bodedra force-pushed the bodedra_12.0-mig-stock_cycle_count branch 2 times, most recently from 0c78e87 to c12e41a Compare June 24, 2019 14:36

LoisRForgeFlow self-requested a review July 3, 2019 11:47

bodedra force-pushed the bodedra_12.0-mig-stock_cycle_count branch from c12e41a to 794928e Compare July 4, 2019 12:29

MiquelRForgeFlow reviewed Jul 5, 2019

View reviewed changes

stock_cycle_count/reports/report_stock_location_accuracy.py Show resolved Hide resolved

bodedra force-pushed the bodedra_12.0-mig-stock_cycle_count branch from 5e33471 to acec4c5 Compare July 5, 2019 15:25

rousseldenis reviewed Jul 5, 2019

View reviewed changes

rousseldenis approved these changes Jul 5, 2019

View reviewed changes

bodedra force-pushed the bodedra_12.0-mig-stock_cycle_count branch from acec4c5 to f76efd9 Compare July 5, 2019 16:47

rousseldenis added needs review and removed work in progress labels Jul 5, 2019

bodedra changed the title ~~[WIP][12.0][MIG] stock_cycle_count: Migration to 12.0~~ [12.0][MIG] stock_cycle_count: Migration to 12.0 Jul 5, 2019

MiquelRForgeFlow approved these changes Jul 5, 2019

View reviewed changes

OCA-git-bot added the approved label Jul 5, 2019

LoisRForgeFlow and others added 6 commits July 8, 2019 08:49

[ADD] stock_cycle_count

2290db0

[ADD] Adding tests

6a10a24

[IMP] stock_cycle_count:

6fd947b

* Update README. * Fixes: DEFAULT_SERVER_DATETIME_FORMAT, PERCENT variables and sale price calculation.

[IMP] tests.

9a8e538

[9.0][FIX] Solves issue when doing picking with several moves.

8585384

OCA Transbot updated translations from Transifex

00d8c41

LoisRForgeFlow and others added 17 commits July 8, 2019 08:49

[9.0][IMP] stock_cycle_count: basic_accuracy report

83ca070

[9.0][IMP] stock_cycle_count: enhance views

50e15fc

[9.0][IMP] stock_cycle_count: cycle counts report

297844b

OCA Transbot updated translations from Transifex

2fe5d86

[10.0][MIG] stock_cycle_count

acba3db

cycle_count: fix cycle count state issue

29c7046

[10.0][IMP] fix api issues and clean up code

73496b5

[10.0] stock_cycle_count: adapt to follow OCA convention.

e7a61d0

[10.0][IMP] stock_cycle_count:

38aa408

* simplify fetching latest inventory date * use api.depends where needed * add hook for cycle count creation * take advantage of api.multi on check_zero_confirmation method

[10.0][UPD] stock_cycle_count: add roadmap.

1c7052c

[UPD] Update stock_cycle_count.pot

42ff852

[11.0][MIG] stock_cycle_count

0115f6c

stock_cycle_count: fix issue with nan while doing the mean calculation

09bda00

[UPD] README.rst

f7bf95a

[UPD] Update stock_cycle_count.pot

feebf83

Update translation files

d0f88ab

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[FIX] stock_cycle_count: Don't lose return value

5fbd81b

For avoiding an error validating pickings.

LoisRForgeFlow force-pushed the bodedra_12.0-mig-stock_cycle_count branch from f76efd9 to 8387920 Compare July 8, 2019 06:54

Bhavesh Odedra and others added 2 commits July 8, 2019 08:57

[12.0][MIG] stock_cycle_count: Migration to 12.0

198e6a1

[12.0][FIX/MIG] stock_cycle_count: fix zero confirmation rules.

e19fd84

Now zero-qty quants are not removed straight away but by a cron job. Therefore, we have to also check that the quants are not zero-qty ones.

LoisRForgeFlow force-pushed the bodedra_12.0-mig-stock_cycle_count branch from 8387920 to e19fd84 Compare July 8, 2019 06:58

LoisRForgeFlow approved these changes Jul 8, 2019

View reviewed changes

OCA-git-bot merged commit e19fd84 into OCA:12.0 Jul 8, 2019

OCA-git-bot added a commit that referenced this pull request Jul 8, 2019

Merge PR #625 into 12.0

476dd50

Signed-off-by lreficent

OCA-git-bot added the merged 🎉 label Jul 8, 2019

bodedra deleted the bodedra_12.0-mig-stock_cycle_count branch July 8, 2019 08:59

manuelcalerosolis pushed a commit to xtendoo-corporation/stock-logistics-warehouse that referenced this pull request Oct 21, 2020

Merge PR OCA#625 into 12.0

2ac44df

Signed-off-by LoisRForgeFlow

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] stock_cycle_count: Migration to 12.0 #625

[12.0][MIG] stock_cycle_count: Migration to 12.0 #625

bodedra commented Jun 24, 2019 •

edited

bodedra commented Jun 25, 2019

LoisRForgeFlow commented Jul 5, 2019 •

edited

bodedra commented Jul 5, 2019

rousseldenis Jul 5, 2019 •

edited

bodedra Jul 5, 2019 •

edited

rousseldenis Jul 5, 2019

bodedra Jul 5, 2019

rousseldenis Jul 5, 2019

bodedra Jul 5, 2019

rousseldenis left a comment

rousseldenis commented Jul 5, 2019

bodedra commented Jul 5, 2019

bodedra commented Jul 6, 2019

LoisRForgeFlow left a comment

LoisRForgeFlow commented Jul 8, 2019

OCA-git-bot commented Jul 8, 2019

OCA-git-bot commented Jul 8, 2019

[12.0][MIG] stock_cycle_count: Migration to 12.0 #625

[12.0][MIG] stock_cycle_count: Migration to 12.0 #625

Conversation

bodedra commented Jun 24, 2019 • edited

Depends on:

bodedra commented Jun 25, 2019

LoisRForgeFlow commented Jul 5, 2019 • edited

bodedra commented Jul 5, 2019

rousseldenis Jul 5, 2019 • edited

Choose a reason for hiding this comment

bodedra Jul 5, 2019 • edited

Choose a reason for hiding this comment

rousseldenis Jul 5, 2019

Choose a reason for hiding this comment

bodedra Jul 5, 2019

Choose a reason for hiding this comment

rousseldenis Jul 5, 2019

Choose a reason for hiding this comment

bodedra Jul 5, 2019

Choose a reason for hiding this comment

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis commented Jul 5, 2019

bodedra commented Jul 5, 2019

bodedra commented Jul 6, 2019

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Jul 8, 2019

OCA-git-bot commented Jul 8, 2019

OCA-git-bot commented Jul 8, 2019

bodedra commented Jun 24, 2019 •

edited

LoisRForgeFlow commented Jul 5, 2019 •

edited

rousseldenis Jul 5, 2019 •

edited

bodedra Jul 5, 2019 •

edited