Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] stock_inventory_lockdown #629

Closed
wants to merge 14 commits into from

Conversation

osimallen
Copy link
Sponsor

@osimallen osimallen commented Jun 25, 2019

#487
Superseeds #627
Migration of stock_inventory_lockdown to version 12

Lionel Sausin & Loïc Bellier and others added 13 commits June 25, 2019 10:19
This module is a feature extracted from stock_inventory_location.

Ported to v8 and new API
Adopted latest OCA standards
Added tests
 in stock move instead of checks in quants. This will allow for a more
 robust lockdown, and still make it possible to perform inventory adjustments
 in the locked location. Also resolves an outstanding issue related to the
 previous design not allowing inventory adjustments where negative quants existed.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@bodedra bodedra force-pushed the 12.0-mig-stock_inventory_lockdown branch from eff893c to d31fafb Compare June 26, 2019 12:51
@bodedra
Copy link
Member

bodedra commented Jun 26, 2019

@mreficent @jbeficent @lreficent @lmignon Would you please review these ?

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 26, 2019
54 tasks
@rousseldenis
Copy link
Sponsor Contributor

rousseldenis commented Jun 26, 2019

Hi @osimallen, thanks for your PR.

Do you plan to add test for the unlink() on stock.location to cover 100% ?

Copy link

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot and code review 👍

Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on runbot

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 12.0-ocabot-merge-pr-629-by-lreficent-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 04ca554. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Jul 3, 2019
Signed-off-by lreficent
@OCA-git-bot OCA-git-bot closed this Jul 3, 2019
@bodedra bodedra deleted the 12.0-mig-stock_inventory_lockdown branch July 3, 2019 13:57
i-vyshnevska pushed a commit to camptocamp/stock-logistics-warehouse that referenced this pull request Apr 13, 2020
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet