Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_inventory_verification_request #630

Merged
merged 12 commits into from Jul 4, 2019
Merged

[12.0][MIG] stock_inventory_verification_request #630

merged 12 commits into from Jul 4, 2019

Conversation

osimallen
Copy link
Sponsor

Migration of stock_inventory_verification_request to version 12

Depends on stock_inventory_discrepncy: #622

@osimallen osimallen mentioned this pull request Jun 25, 2019
Closed
@bodedra bodedra force-pushed the 12.0-mig-stock_inventory_verification_request branch 2 times, most recently from cd2b315 to 154c493 Compare June 26, 2019 16:49
@bodedra
Copy link
Member

bodedra commented Jun 26, 2019

🍏 Ready for review.

@lreficent

@bodedra
Copy link
Member

bodedra commented Jun 26, 2019

@max3903

@max3903 max3903 added this to the 12.0 milestone Jun 26, 2019
max3903
max3903 reviewed Jun 26, 2019
View reviewed changes
oca_dependencies.txt Outdated
@@ -3,3 +3,4 @@
product-attribute
server-ux
web
stock_inventory_discrepancy https://github.com/ursais/stock-logistics-warehouse bodedra_12.0-mig-stock_inventory_discrepancy
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osimallen You should remove this and wait for the module to be merged and rebase this branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max3903 I added those line. Yes will do.

@bodedra
Copy link
Member

bodedra commented Jul 3, 2019

@lreficent Would you please review these.

@bodedra bodedra mentioned this pull request Jul 3, 2019
Closed
54 tasks
LoisRForgeFlow
LoisRForgeFlow requested changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove the line in oca_dependencies as pointed by @max3903

Thanks for the work 👍

@bodedra bodedra force-pushed the 12.0-mig-stock_inventory_verification_request branch from 154c493 to e13c6d3 Compare July 4, 2019 11:52
@bodedra
Copy link
Member

bodedra commented Jul 4, 2019

Thanks @max3903 @lreficent Comment attended. Test case are failed in OCA/OCB stock_request_purchase module.

LoisRForgeFlow
LoisRForgeFlow approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis fixed, let's merge!

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Rebased to 12.0-ocabot-merge-pr-630-by-lreficent-bump-no, awaiting test results.

@LoisRForgeFlow LoisRForgeFlow changed the title 12.0 mig stock inventory verification request [12.0][MIG] stock_inventory_verification_request Jul 4, 2019
@OCA-git-bot OCA-git-bot merged commit e13c6d3 into OCA:12.0 Jul 4, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 91030bb. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Jul 4, 2019
@OCA-git-bot
Merge PR #630 into 12.0
91030bb 
Signed-off-by lreficent
@bodedra bodedra deleted the 12.0-mig-stock_inventory_verification_request branch July 4, 2019 14:41
i-vyshnevska pushed a commit to camptocamp/stock-logistics-warehouse that referenced this pull request Apr 13, 2020
@OCA-git-bot
Merge PR OCA#630 into 12.0
e8d3997 
Signed-off-by LoisRForgeFlow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodedra bodedra bodedra left review comments

@max3903 max3903 max3903 approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees

@osimallen osimallen

Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@osimallen @bodedra @LoisRForgeFlow @OCA-git-bot @max3903 @oca-transbot @gurneyalex @oca-travis