Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_request_purchase #631

Closed
wants to merge 11 commits into from
Closed

[12.0][MIG] stock_request_purchase #631

wants to merge 11 commits into from

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Jun 26, 2019

Done migrated.

oca-transbot and others added 10 commits June 26, 2019 16:51
@oca-transbot @kittiu
OCA Transbot updated translations from Transifex
7d11468
@JordiBForgeFlow @kittiu
add stock_request in 11.0
561967d
@oca-transbot @kittiu
OCA Transbot updated translations from Transifex
6a27664
@MiquelRForgeFlow @kittiu
[IMP] stock_request_purchase: Remove hook
79485f2
@etobella @kittiu
[IMP] stock_request_purchase: Add Stock request orders. Change logo
7721421
@MiquelRForgeFlow @kittiu
[FIX] Various fixes:
78bcfa4 
- Error with the sequence number.
- Visible texts that should be in uppercases.
- order_id should only be visible if group_stock_request_order
  option is enabled.
- adds more tests
- adds consistency between models company-wise
@JordiBForgeFlow @kittiu
various fixes
25d30ed
@etobella @kittiu
[IMP] simplify queries
e56b6ac
@oca-travis @kittiu
[UPD] Update stock_request_purchase.pot
18e4b41
@etobella @kittiu
Translated using Weblate (Spanish)
27a642c 
Currently translated at 100,0% (13 of 13 strings)

Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_request_purchase
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_request_purchase/es/
@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 26, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 26, 2019
Closed
54 tasks
rousseldenis
rousseldenis approved these changes Jun 26, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

tbaden
tbaden suggested changes Jun 26, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review:
please use the fragment readme mentioned in the migration guidelines

@kittiu kittiu force-pushed the 12.0-mig-stock_request_purchase branch from e79d207 to a85f421 Compare June 27, 2019 01:46
@kittiu
Copy link
Member Author

kittiu commented Jun 27, 2019

Thank you all, I did the readme.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Rebased to 12.0-ocabot-merge-pr-631-by-rousseldenis-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 1, 2019
@OCA-git-bot
Merge PR #631 into 12.0
a3736c3 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a3736c3. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@OCA-git-bot OCA-git-bot closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaden tbaden tbaden approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@kittiu @OCA-git-bot @rousseldenis @tbaden @pedrobaeza @oca-transbot @JordiBForgeFlow @MiquelRForgeFlow @etobella @oca-travis