Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] procurement_auto_create_group #638

Closed
wants to merge 13 commits into from
Closed

[12.0][MIG] procurement_auto_create_group #638

wants to merge 13 commits into from

Conversation

MiquelRForgeFlow
Copy link
Contributor

Standard migration.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-procurement_auto_create_group branch 4 times, most recently from 7503ea0 to a0e10a6 Compare July 4, 2019 11:18
JordiBForgeFlow and others added 12 commits July 5, 2019 12:43
@JordiBForgeFlow @MiquelRForgeFlow
add module 'procurement_auto_create_group' to 9.0
9f60e1f
@LoisRForgeFlow @MiquelRForgeFlow
[9.0][ADD] procurement_auto_create_group: add tests
bd39c3b
@LoisRForgeFlow @MiquelRForgeFlow
hide if propagation option is not "propagate"
1427f1d
@JordiBForgeFlow @MiquelRForgeFlow
auto_create_group should be false when group_propagation_option is no…
737794c 
…t 'propagate'
@oca-transbot @MiquelRForgeFlow
OCA Transbot updated translations from Transifex
e877b7f
@LoisRForgeFlow @MiquelRForgeFlow
[10.0][MIG] procurement_auto_create_group
8f13b7b
@oca-transbot @MiquelRForgeFlow
OCA Transbot updated translations from Transifex
34504da 
[UPD] Update procurement_auto_create_group.pot
@LoisRForgeFlow @MiquelRForgeFlow
[11.0][MIG] procurement_auto_create_group
2475983
@OCA-git-bot @MiquelRForgeFlow
[UPD] README.rst
d9b11b2
@oca-travis @MiquelRForgeFlow
[UPD] Update procurement_auto_create_group.pot
076bb1b 
Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@LoisRForgeFlow @MiquelRForgeFlow
[11.0][IMP] procurement_auto_create_group:
773a7dd 
ensure that the procurement group is only created in the procurment process.

Sometimes the method _get_rule is just needed to obtain the information of the rule,
and it isn't followed by the run of the procurement.
@oca-travis @MiquelRForgeFlow
[UPD] Update procurement_auto_create_group.pot
2b69c4c
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-procurement_auto_create_group branch from a0e10a6 to 14ad576 Compare July 5, 2019 10:46
@rousseldenis rousseldenis added this to the 12.0 milestone Jul 6, 2019
AaronHForgeFlow
AaronHForgeFlow approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional tests ok

@AaronHForgeFlow
Copy link
Contributor

Please check travis @mreficent

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 8, 2019
Closed
54 tasks
AdriaGForgeFlow
AdriaGForgeFlow approved these changes Jul 10, 2019
View reviewed changes
Copy link

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

rousseldenis
rousseldenis requested changes Jul 10, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM. You need to adapt all texts to remove procurement references.

procurement_auto_create_group/README.rst Outdated Show resolved Hide resolved
procurement_auto_create_group/__manifest__.py Outdated Show resolved Hide resolved
procurement_auto_create_group/__manifest__.py Outdated Show resolved Hide resolved
procurement_auto_create_group/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
procurement_auto_create_group/readme/USAGE.rst Outdated Show resolved Hide resolved
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-procurement_auto_create_group branch from 14ad576 to 1119d01 Compare July 10, 2019 11:08
@MiquelRForgeFlow
Copy link
Contributor Author

@rousseldenis hope you like the new descriptions :)

LoisRForgeFlow
LoisRForgeFlow approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot, everything ok 👍

@LoisRForgeFlow
Copy link
Contributor

@rousseldenis good to go?

@rousseldenis
Copy link
Sponsor Contributor

rousseldenis commented Jul 11, 2019 •
edited

@lreficent What I wanted to say is that 'procurement' does not exists anymore and so, 'running procurements' has no sense (from a functionnal point of view)...

@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Jul 11, 2019 •
edited

@rousseldenis I think it does, you still "procure" material, which is quite similar. Also technically it uses the method run, so is not that bad to say run the procurement (aka run "the need for materials").

Yet it could likely be stated more clearly, so... which is your proposal?

@rousseldenis
Copy link
Sponsor Contributor

I think it does, you still "procure" material, which is quite similar.

Ok, that's good for me. I just didn't want user expect to find 'procurements'... Let's merge

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Rebased to 12.0-ocabot-merge-pr-638-by-rousseldenis-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7935e7c. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Jul 12, 2019
@OCA-git-bot
Merge PR #638 into 12.0
7935e7c 
Signed-off-by rousseldenis
@LoisRForgeFlow LoisRForgeFlow deleted the 12.0-mig-procurement_auto_create_group branch July 12, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@MiquelRForgeFlow @AaronHForgeFlow @LoisRForgeFlow @rousseldenis @OCA-git-bot @AdriaGForgeFlow @JordiBForgeFlow @oca-transbot @oca-travis