Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] stock_quant_manual_assign #651

Closed

Conversation

LoisRForgeFlow
Copy link
Contributor

avanzosc1 and others added 30 commits July 11, 2019 16:00
… the wizard of "quants Manual" and check availability.
* Extended usage in README
Conforms to the latest README template: bugtracker, runbot etc.
Fixes bugtracker URL on some modules.
States OCA as maintainer, removes other contributors from the 'Maintainer' section.
* Fix uom issue
* Convert move quantity in the default product uom to use the same uom as quant
[FIX] test_flake8

 [FIX]
 - use the already existing field product_qty
 - fix picking edition by warehouse user due to related none readonly field
* Better layout
* Remove active_id dependency in some computed fields
* Clean code
* Refine constraint
* Take into account if the current line is previously reserved before clicking on the button.
@LoisRForgeFlow LoisRForgeFlow added this to the 12.0 milestone Jul 11, 2019
@LoisRForgeFlow LoisRForgeFlow force-pushed the 12.0-mig-stock_quant_manual_assign branch from 813475b to f2a61a7 Compare July 11, 2019 14:55
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 12, 2019
54 tasks
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM. Some comments.

stock_quant_manual_assign/__manifest__.py Outdated Show resolved Hide resolved
stock_quant_manual_assign/__manifest__.py Outdated Show resolved Hide resolved
stock_quant_manual_assign/wizard/assign_manual_quants.py Outdated Show resolved Hide resolved
stock_quant_manual_assign/wizard/assign_manual_quants.py Outdated Show resolved Hide resolved
stock_quant_manual_assign/wizard/assign_manual_quants.py Outdated Show resolved Hide resolved
@LoisRForgeFlow LoisRForgeFlow force-pushed the 12.0-mig-stock_quant_manual_assign branch from f2a61a7 to e5659ce Compare July 12, 2019 08:06
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Functional review

@LoisRForgeFlow
Copy link
Contributor Author

Thanks for you reviews! 😃. Now merging.

@LoisRForgeFlow
Copy link
Contributor Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Rebased to 12.0-ocabot-merge-pr-651-by-lreficent-bump-no, awaiting test results.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8a90d6c. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Jul 12, 2019
Signed-off-by lreficent
@LoisRForgeFlow LoisRForgeFlow deleted the 12.0-mig-stock_quant_manual_assign branch July 12, 2019 10:31
manuelcalerosolis pushed a commit to xtendoo-corporation/stock-logistics-warehouse that referenced this pull request Oct 21, 2020
Signed-off-by rousseldenis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet