Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_account_inventory_force_date #676

Merged
merged 5 commits into from Oct 16, 2019
Merged

[12.0][MIG] stock_account_inventory_force_date #676

merged 5 commits into from Oct 16, 2019

Conversation

HviorForgeFlow
Copy link
Member

Standard migration

CC @eficent

@HviorForgeFlow HviorForgeFlow force-pushed the 12.0-mig-stock_account_inventory_force_date branch 2 times, most recently from 2742b29 to 66501f3 Compare August 2, 2019 09:05
@HviorForgeFlow HviorForgeFlow force-pushed the 12.0-mig-stock_account_inventory_force_date branch from 66501f3 to 280315e Compare August 5, 2019 09:02
@max3903 max3903 added this to the 12.0 milestone Aug 20, 2019
rousseldenis
rousseldenis approved these changes Sep 30, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@HviorForgeFlow
Copy link
Member Author

@daramousk can you update your review? Thanks!

@HviorForgeFlow
Copy link
Member Author

ping @daramousk

daramousk
daramousk approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@daramousk daramousk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, although the code coverage needs to be raised so that stuff gets green.

@rousseldenis
Copy link
Sponsor Contributor

@hveficent Do you plan to increase coverage ?

@HviorForgeFlow
Copy link
Member Author

@rousseldenis @daramousk, I think current tests cover most of the use cases. Not full coverage is due to doing an Inventory Adjustment of all product, so I can make it happen, but asserts can't be precise across changes in demo data, so I think it is not needed and it is ready to be merged.

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-676-by-rousseldenis-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 16, 2019
@OCA-git-bot
Merge PR #676 into 12.0
78a8de7 
Signed-off-by rousseldenis
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 16, 2019
Closed
54 tasks
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-676-by-rousseldenis-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 16, 2019
@OCA-git-bot
Merge PR #676 into 12.0
4121823 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-676-by-rousseldenis-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 16, 2019
@OCA-git-bot
Merge PR #676 into 12.0
ec57cb3 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8eee830. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 280315e into OCA:12.0 Oct 16, 2019
@HviorForgeFlow HviorForgeFlow deleted the 12.0-mig-stock_account_inventory_force_date branch October 16, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daramousk daramousk daramousk approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@HviorForgeFlow @rousseldenis @OCA-git-bot @daramousk @max3903 @LoisRForgeFlow @JordiBForgeFlow @oca-travis