New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] stock_location_lockdown : Migration to 12.0 #720
[MIG] stock_location_lockdown : Migration to 12.0 #720
Conversation
Improve README
Currently translated at 80.0% (4 of 5 strings) Translation: stock-logistics-warehouse-10.0/stock-logistics-warehouse-10.0-stock_location_lockdown Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-10-0/stock-logistics-warehouse-10-0-stock_location_lockdown/pt/
When forcing an outgoing move and then moving it. Odoo create a negative quant. This quant should not be in the locked location because no quand will go in it and so the negative quant will stay here for ever
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-10.0/stock-logistics-warehouse-10.0-stock_location_lockdown Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-10-0/stock-logistics-warehouse-10-0-stock_location_lockdown/
3655a74
to
2935fe7
Compare
319949d
to
17cc489
Compare
mission is to support the collaborative development of Odoo features and | ||
promote its widespread use. | ||
|
||
This module is part of the `OCA/stock-logistics-warehouse <https://github.com/OCA/stock-logistics-warehouse/tree/10.0/stock_location_lockdown>`_ project on GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10.0 - > 12.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, the readme file is re-generated from the readme folder.
So no need to change anything about that.
|
||
{ | ||
"name": "Stock Location Lockdown", | ||
"summary": "Prevent to add stock on flagged locations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of flagged location it would be better if you can replace it with something meaningful description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks quite meaningful to me knowing that there is the complete description on the DESCRIPTION.rst file.
Do you have a better suggestion ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest something like Prevent to add stock on locked locations.
17cc489
to
039b4ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
a514a36
to
1014d79
Compare
|
||
{ | ||
"name": "Stock Location Lockdown", | ||
"summary": "Prevent to add stock on locked locations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeetKD I've just changed it. Is the rest of the module ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review using Runbot 👍
cc @nuriamartinxifre |
This PR has the |
/ocabot merge |
This PR looks fantastic, let's merge it! |
It looks like something changed on |
Congratulations, your PR was merged at 1ab0949. Thanks a lot for contributing to OCA. ❤️ |
Module migration adding a Warning message when trying to check the stock location 's "Block stock entrance" checkbox if the stock location has got quants.
Also added a test to test this Warning message.