Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_inventory_virtual_location #739

Merged
merged 9 commits into from Jun 29, 2020
Merged

[12.0][MIG] stock_inventory_virtual_location #739

merged 9 commits into from Jun 29, 2020

Conversation

MiquelRForgeFlow
Copy link
Contributor

Standard migration.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-stock_inventory_virtual_location branch 2 times, most recently from 428ae84 to 25538b7 Compare October 29, 2019 17:33
@rousseldenis rousseldenis added this to the 12.0 milestone Nov 6, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 6, 2019
Closed
54 tasks
rousseldenis
rousseldenis requested changes Nov 6, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

Could you make another PR for the second module ?

stock_inventory_virtual_location/__manifest__.py Outdated Show resolved Hide resolved
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-stock_inventory_virtual_location branch from 25538b7 to a7a8c7a Compare November 6, 2019 16:21
@MiquelRForgeFlow
Copy link
Contributor Author

Could you make another PR for the second module ?

@rousseldenis why? I think it's not necessary in this specific case.

@rousseldenis
Copy link
Sponsor Contributor

@MiquelRForgeFlow Could you rebase ?

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-stock_inventory_virtual_location branch from a7a8c7a to 7da1b4f Compare June 25, 2020 07:47
@MiquelRForgeFlow
Copy link
Contributor Author

@rousseldenis rebased

@JordiBForgeFlow
Copy link
Sponsor Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-739-by-JordiBForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7a53434 into OCA:12.0 Jun 29, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 47b5e5b. Thanks a lot for contributing to OCA. ❤️

@HviorForgeFlow HviorForgeFlow deleted the 12.0-mig-stock_inventory_virtual_location branch June 29, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@MiquelRForgeFlow @rousseldenis @JordiBForgeFlow @OCA-git-bot @marcelsavegnago @HviorForgeFlow @HaraldPanten @oca-travis