[12.0][MIG] stock_move_location #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for further improvements
A recordset object is not reliable enough to use as a key for the built-in 'sorted' and 'itertools.groupby' functions (sometimes it works, sometimes not). Using the ID of the record (here the product ID) can fix the problem, but the 'group_lines()' has been totally rewritten for a simpler implementation without any use of 'sorted' or 'itertools.groupby' functions to group the wizard lines by product: an iteration on lines to fill a dictionary does the job.
…n to another directly from selected quants
Currently translated at 100.0% (32 of 32 strings) Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_move_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_move_location/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_move_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_move_location/
Currently translated at 100.0% (33 of 33 strings) Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_move_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_move_location/de/
Currently translated at 100.0% (33 of 33 strings) Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_move_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_move_location/de/
Currently translated at 100.0% (33 of 33 strings) Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_move_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_move_location/de/
|
Hey @Joansis, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
AaronHForgeFlow
approved these changes
Nov 6, 2019
[FIX] improvement move line generation
JoanSForgeFlow
force-pushed
the
12.0-mig-stock_move_location
branch
from
6836ded
to
6b6768d
Compare
rousseldenis
approved these changes
Nov 6, 2019
JoanSForgeFlow
force-pushed
the
12.0-mig-stock_move_location
branch
from
283a668
to
d4f0ee0
Compare
|
This PR has the |
|
@Joansis Do you plan to squash commits or let like this ? |
|
@rousseldenis I think like this is fine. One commit is for the migration, other for an improvement, and the other one is a separate fix. |
|
/ocabot merge |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 6ec0a5c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves lines creation in the wizard.
cc @eficent