[11.0][ADD] Scrap reason code module

[bodedra]

Usage

In the Inventory module, open the Configuration menu and select Scrap Reason Codes.
Create the required scrap reason codes. Under Operations, select Scrap. Click the
create button to create a new scrap order. You will see a reason code field on the
scrap form which will allow you to select any of the scrap codes you created previously.

[OCA-git-bot]

Hi @bodedra,
some modules you are maintaining are being modified, check this out!

[bodedra]

@hveficent @aheficent @lreficent @jbeficent @max3903

Would you please help me.

Test case is failed in stock_request or stock_request_analytic module.

[bodedra]

Are you available for review?

@b-kannan @osimallen @smangukiya @gavindav @diverfr @MDodoo @guimarc-br

Test case are green for this PR.

[bodedra]

ci is 🍏

[HviorForgeFlow]

@bodedra all I can see is that stock_request_user is not available to read stock.warehouse0 record.
Can't see why

[bodedra]

@bodedra all I can see is that stock_request_user is not available to read stock.warehouse0 record.
Can't see why

@hveficent Agree. I verified that read access right is already set. Here is ref https://github.com/OCA/stock-logistics-warehouse/blob/11.0/stock_request/security/ir.model.access.csv#L14

[bodedra]

@rousseldenis Is there any suggestion for fix #770 (comment)

Read access right already for warehouse. https://github.com/OCA/stock-logistics-warehouse/blob/11.0/stock_request/security/ir.model.access.csv#L14

[HviorForgeFlow]

@bodedra
Ugly form to fix error:

if self.warehouse_id != loc_wh:
    self.location_id = self.warehouse_id.sudo().lot_stock_id.id
if self.warehouse_id.sudo().company_id != self.company_id:
    self.company_id = self.warehouse_id.sudo().company_id

[HviorForgeFlow]

@etobella can you figure out how to avoid sudo usage here? I think as you only writing/reading fields it does not matters.

[bodedra]

This PR is 🍏 and ready for your review.

@b-kannan @dreispt @max3903 @gavindav @diverfr @MDodoo @guimarc-br

[bodedra]

Thank you @hveficent for suggested fix in stock_request_* module.

[nikul-serpentcs]

nitpicking

Squash Commit's

[bodedra]

@nikul-serpentcs Comment addressed! Thanks for your review.

[nikul-serpentcs]

Code Review LGTM 👍

[bodedra]

@rousseldenis Comment attended!

[bodedra]

@Chandresh-SerpentCS are you available for a review?

[rousseldenis]

Code review

[bodedra]

@rousseldenis Comment attended! Would you please review it again.

[bodedra]

@OCA/logistics-maintainers are we good to merge this?

[bodedra]

Ping @dreispt

[rousseldenis]

@bodedra Do you want to keep the 3 commits or do you plan to squash them ?

[bodedra]

@rousseldenis Let me squash them into 1.

[rousseldenis]

/ocabot merge

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 11.0-ocabot-merge-pr-770-by-rousseldenis-bump-no, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 5ec1ba5. Thanks a lot for contributing to OCA. ❤️