Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] stock_available_immediately: Migration to 11.0 #778

Merged
merged 51 commits into from
Dec 4, 2019
Merged

[MIG] stock_available_immediately: Migration to 11.0 #778

merged 51 commits into from
Dec 4, 2019

Conversation

dmsergio
Copy link

No description provided.

nbessi and others added 30 commits November 29, 2019 16:15
(lp:c2c-addons/6.1  rev 28.1.10)
…PL-3 with author agreement, improved help messages and pep8

(lp:c2c-addons/6.1  rev 45.1.8)
[UPG] Upgraded to version 8, fixed references to new 8.0  views and  moved fields that were in  product.product to product.template

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[UPG] stock available immediately, corrected the calculation method of
immediately_usable_qty to take in accountthe sign change in outgoing_qty
(from negative to positive) in version 8.

[FLAKE8]

[FIX] renaming of a class, comment removing, useless code.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.
[UPG] Upgraded to version 8, fixed references to new 8.0  views and  moved fields that were in  product.product to product.template
[RFR] Removing useless code and renaming
Generic module to compute the stock quantity available to promise using several implementations.
stock_available_immediatly is changed to become the first optional implementation.
Cherry pick of commit 0b060f6 from the v7 branch
Cherry-picked from v7 at 8add4be

Conflicts:
	__unported__/stock_available_mrp/__openerp__.py
	stock_available/__openerp__.py
	stock_available_immediately/__openerp__.py
…uct and

product.template, now takes in account variants and correctly displays value.
[FLAKE8]

Removing duplicate modules and moving README.rst into __unported__
calculations done in product template are fine.
…he quant calculations done in product template are fine."

This reverts commit d6dee6f.
The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix #73 too.
@oca-clabot
Copy link

Hey @dmsergio, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@dmsergio
Copy link
Author

Hello @pedrobaeza, have I preserved correctly the history commit?

@pedrobaeza
Copy link
Member

Yes, thanks. Check now why Travis is red.

@pedrobaeza
Copy link
Member

I think it's not your fault, but stock_request one. @lreficent are you aware of this error?

@dmsergio
Copy link
Author

Yes, thanks. Check now why Travis is red.

The tests of stock_available_immediately addon has passed correctly. Travis found errors in another addons.

@dmsergio
Copy link
Author

dmsergio commented Dec 2, 2019

Any news about this PR?

@pedrobaeza
Copy link
Member

You have to find reviewers of the PR. You can review others and ask in exchange that they review yours.

@jesuspablo
Copy link

@dmsergio, I think the changes made are correct, we have missed the migration of this module

@rousseldenis rousseldenis added this to the 11.0 milestone Dec 3, 2019
@pedrobaeza pedrobaeza mentioned this pull request Dec 3, 2019
46 tasks
@pedrobaeza
Copy link
Member

Please use GitHub's approval mechanism for proper visibility.

Copy link

@maurochip maurochip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested It and it works properly on my Odoo dev

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

Although none of the reviewers is PSC of this repo, I think we can trust being a migration and of something very confined, so

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-778-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 4, 2019
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 044fc64 into OCA:11.0 Dec 4, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 44842f9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet