Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][ADD] stock_location_limit_product #787

Merged
merged 12 commits into from
Dec 24, 2019
Merged

[12.0][ADD] stock_location_limit_product #787

merged 12 commits into from
Dec 24, 2019

Conversation

nikitavaghela
Copy link

Stock Location Limit Product

Added stock_location_limit_product as mention #756

@oca-clabot
Copy link

Hey @nikitavaghela, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@nikitavaghela nikitavaghela changed the title Stock Location Limit Product [12.0][ADD]Stock Location Limit Product Dec 13, 2019
@rousseldenis rousseldenis added this to the 13.0 milestone Dec 16, 2019
@rousseldenis rousseldenis modified the milestones: 13.0, 12.0 Dec 16, 2019
rousseldenis
rousseldenis requested changes Dec 16, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

As I understand, this is a base module for further ones ?

stock_location_limit_product/__manifest__.py Outdated Show resolved Hide resolved
stock_location_limit_product/models/stock_location_limit.py Outdated Show resolved Hide resolved
stock_location_limit_product/models/stock_location_limit.py Outdated Show resolved Hide resolved
stock_location_limit_product/models/stock_location_limit.py Outdated Show resolved Hide resolved
rousseldenis
rousseldenis approved these changes Dec 17, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

Could you squash your commits ?

@nikitavaghela nikitavaghela reopened this Dec 17, 2019
@nikitavaghela
Copy link
Author

Code review.
Could you squash your commits ?

I tried to squash but there are some other commits also between our module commit. so it's not sqashed.

@rousseldenis
Copy link
Sponsor Contributor

What did you do to squash (commands) ?

@nikitavaghela
Copy link
Author

What did you do to squash (commands) ?

git rebase -i HEAD~(no of commit to squash)

@nikitavaghela
Copy link
Author

Hello @max3903, @dreispt,
Can you please review this?

@max3903
Copy link
Sponsor Member

max3903 commented Dec 19, 2019

@nikitavaghela Please add a test that adds a limit record to the stock location.

@max3903 max3903 changed the title [12.0][ADD]Stock Location Limit Product [12.0][ADD] stock_location_limit_product Dec 20, 2019
@max3903
Copy link
Sponsor Member

max3903 commented Dec 20, 2019

@nikitavaghela Please review and merge nikitavaghela#1

@nikitavaghela nikitavaghela mentioned this pull request Dec 23, 2019
Merged
@max3903
Copy link
Sponsor Member

max3903 commented Dec 24, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-787-by-max3903-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 24, 2019
@OCA-git-bot
Merge PR #787 into 12.0
a075ac1 
Signed-off-by max3903
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit a2af21b into OCA:12.0 Dec 24, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8958f80. Thanks a lot for contributing to OCA. ❤️

@rousseldenis rousseldenis mentioned this pull request Feb 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees

@nikitavaghela nikitavaghela

Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nikitavaghela @oca-clabot @rousseldenis @max3903 @OCA-git-bot