Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_inventory_cost_info: Migration to 12.0 #795

Merged
merged 3 commits into from Dec 18, 2019
Merged

[12.0][MIG] stock_inventory_cost_info: Migration to 12.0 #795

merged 3 commits into from Dec 18, 2019

Conversation

pedrobaeza
Copy link
Member

  • Standard procedure
  • Adapted tests

@Tecnativa TT20190

@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 17, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 17, 2019
Closed
54 tasks
carlosdauden
carlosdauden approved these changes Dec 17, 2019
View reviewed changes
Copy link

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

sergio-teruel
sergio-teruel approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little comment

stock_inventory_cost_info/models/stock_inventory.py Show resolved Hide resolved
@pedrobaeza
Copy link
Member Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-795-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 18, 2019
@OCA-git-bot
Merge PR #795 into 12.0
1c2f147 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-795-by-pedrobaeza-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-795-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 18, 2019
@OCA-git-bot
Merge PR #795 into 12.0
0ce3ce1 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 09b5d06 into OCA:12.0 Dec 18, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2a9b535. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

@ps-tubtim ps-tubtim ps-tubtim approved these changes

@ernestotejeda ernestotejeda Awaiting requested review from ernestotejeda

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pedrobaeza @OCA-git-bot @sergio-teruel @carlosdauden @ps-tubtim @ernestotejeda