[13.0][MIG] stock_available_mrp #803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ps-tubtim, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
hello @ps-tubtim I can't enter the products screen after installing the module log: after add store=True to bom_id field to fix the previous issue, when I Create new product potential quantities values not calculated, but if I uninstall stock_available and install stock_available_mrp potential quantities values calculated and appear |
ps-tubtim
force-pushed
the
13.0-mig-stock_available_mrp
branch
2 times, most recently
from
941fbe9
to
2bf56e6
Compare
|
@ps-tubtim You can rebase as #802 is merged |
ps-tubtim
force-pushed
the
13.0-mig-stock_available_mrp
branch
from
53f70af
to
b011bb0
Compare
ps-tubtim
force-pushed
the
13.0-mig-stock_available_mrp
branch
from
b011bb0
to
fca5f82
Compare
|
@ps-tubtim can you pls rebase and check travis build for errors |
ps-tubtim
force-pushed
the
13.0-mig-stock_available_mrp
branch
from
fca5f82
to
b78a942
Compare
|
Hello @ps-tubtim a fix is included into #1070 |
leemannd
reviewed
Feb 3, 2021
| or (not b.product_id and b.product_tmpl_id == product.product_tmpl_id) | ||
| ) | ||
| if product_boms: | ||
| product.bom_id = first(product_boms) |
There was a problem hiding this comment.
Suggested change
| product.bom_id = first(product_boms) | |
| product.bom_id = first(product_boms) | |
| else: | |
| product.bom_id = False |
There was a problem hiding this comment.
Thank you for your review. Edited.
leemannd
suggested changes
Feb 3, 2021
|
We just merged this changes due to Odoo upstream changes that intruduced some incompatibilities. https://github.com/OCA/stock-logistics-warehouse/pull/1099/files Please include it in your migration |
Compute potential quantities for both product templates and variants. To keep the code simple, only the biggest potential of any single variant is accounted for in the template's potential. Take all levels of phantom BoM into account, respects validity dates etc. thanks to the use of the standard method _bom_explode, as suggested by @gdgellatly in OCA#5 (comment) Improve tests, rewritten in python. Adhere to new file/manifest/README conventions. Simplify copyright headers
sudo is not required since mrp.bom are readable to groups with access to the qty_x fields on a product. Moreover using sudo to retrive the bom will ignore the company_id defined on the bom
Record rules used to not be checked on stock quants, but now they are since Odoo's commit 2fd14db (odoo/odoo@2fd14db). In our test we changed the company of the products and BoMs but we neglected that the stock was not attached to the right company, and that made the test fail. To fix that, make the test inventory for the right company. Since there is a little inconsistency in the demo data with a negative quantity of an unrelated product, use the `partial` filter for the inventories instead of the `none` filter, so that no wrong inventory lines are added automatically.
…ch field use to compute potential
…ew + small improvements
* mrp_bom.name has been deleted.
* mrp_bom_line.type moved to mrp_bom.type.
* Fix missing group_mrp_user issue.
* Change versions
…recordset + Condition never statisfied
…of immediately usable qty
…ilable_immediately
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_mrp Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_mrp/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_mrp Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_mrp/
Currently translated at 100.0% (7 of 7 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_mrp Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_mrp/zh_CN/
ps-tubtim
force-pushed
the
13.0-mig-stock_available_mrp
branch
2 times, most recently
from
0159bce
to
11f612e
Compare
After this change odoo/odoo@3d34d58 it isn't possible to have an storable kit product anymore. The main issue is that we have to drop some uses cases that this module considered for this kind of situations.
ps-tubtim
force-pushed
the
13.0-mig-stock_available_mrp
branch
from
11f612e
to
e38446a
Compare
ps-tubtim
force-pushed
the
13.0-mig-stock_available_mrp
branch
from
f27011d
to
fc49cf9
Compare
|
This can be closed. The module has been migrated into another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is waiting for #802, you can always use this for readability.