Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] Add stock_location_position #805

Merged
merged 5 commits into from
Mar 4, 2020

Conversation

guewen
Copy link
Member

@guewen guewen commented Dec 19, 2019

Continued the work started on #712, including the renaming and addition of tooltips asked there.
Migrated to 13.0.

@guewen guewen force-pushed the 13.0-add-stock_location_position branch from 8c0233f to 46b934c Compare January 7, 2020 07:04
@ps-tubtim
Copy link
Member

Please squash migration commits into one.

@guewen
Copy link
Member Author

guewen commented Mar 3, 2020

@ps-tubtim I see only one migration commit (46b934c)?

@ps-tubtim
Copy link
Member

@guewen I mean squash the last three commit into one (8644b67, 745a41a, 46b934c).
Why you separate to three commit ?

@guewen
Copy link
Member Author

guewen commented Mar 4, 2020

@ps-tubtim

  • "Add tooltips" is not part of the migration, it adds new things. If we want to backport them to 12.0 for instance, a cherry-pick allows to get them without getting the changes done for 13.0
  • "Add setuptools files" is the result of the command setuptools-odoo-make-default -d . which generates these files. It's not part of the changes required to make the module work in 13.0, I think it's cleaner to have a commit to keep these new files apart.

@ps-tubtim
Copy link
Member

@guewen Thank you for expand it to me.

@ps-tubtim
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-805-by-ps-tubtim-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a72d8d7. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 0b95190 into OCA:13.0 Mar 4, 2020
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
Signed-off-by ps-tubtim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants