Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] stock_inventory_lockdown #811

Merged
merged 23 commits into from
Dec 23, 2019

Conversation

AdriaGForgeFlow
Copy link

Standard migration of module stock_inventory_lockdown to v13.

cc ~ @ForgeFlow

Lionel Sausin & Loïc Bellier and others added 23 commits December 20, 2019 15:26
This module is a feature extracted from stock_inventory_location.

Ported to v8 and new API
Adopted latest OCA standards
Added tests
 in stock move instead of checks in quants. This will allow for a more
 robust lockdown, and still make it possible to perform inventory adjustments
 in the locked location. Also resolves an outstanding issue related to the
 previous design not allowing inventory adjustments where negative quants existed.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
The virtual adjustment location may be different from the one provided in property_stock_inventory of the product.
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_lockdown
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_lockdown/zh_CN/
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_lockdown
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_lockdown/pt_BR/
@oca-clabot
Copy link

Hey @AdriaGForgeFlow, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@rousseldenis rousseldenis added this to the 13.0 milestone Dec 20, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 20, 2019
53 tasks
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review, LGTM

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-811-by-LoisRForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 23, 2019
Signed-off-by LoisRForgeFlow
@OCA-git-bot OCA-git-bot merged commit 21f259c into OCA:13.0 Dec 23, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4332760. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 13.0-mig-stock_inventory_lockdown branch December 23, 2019 10:06
"""Refuse changes during exhaustive Inventories"""

_inherit = "stock.location"
_order = "name"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdriaGForgeFlow @rousseldenis
Do you know if there is a reason for changing the default order (default is complete_name)?
It seems pretty brutal. In my case, it makes tests fail in #997

Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I didn't notice it. This is obviously not advised to change _order parameter.

@LoisRForgeFlow @AdriaGForgeFlow Is this needed ?

Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming from the creation of this module in v9. I guess it made sense back then but I'm not really sure it is needed anymore, probably not

CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
Signed-off-by LoisRForgeFlow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet