Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] stock_putaway_method #820

Merged
merged 6 commits into from Jan 2, 2020
Merged

[MIG] stock_putaway_method #820

merged 6 commits into from Jan 2, 2020

Conversation

max3903
Copy link
Sponsor Member

@max3903 max3903 commented Dec 31, 2019

No description provided.

@max3903 max3903 added this to the 12.0 milestone Dec 31, 2019
@max3903 max3903 self-assigned this Dec 31, 2019
@max3903 max3903 marked this pull request as ready for review December 31, 2019 22:12
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 31, 2019
Closed
54 tasks
bodedra
bodedra approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rousseldenis
Copy link
Sponsor Contributor

@max3903 Could you squash commits ?

rousseldenis
rousseldenis approved these changes Jan 2, 2020
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

asaunier and others added 6 commits January 2, 2020 17:28
@asaunier
Putaway strategy: add module to restore the method field
bbc1ae4 
The method field was removed in module 'stock' of Odoo 11. See
odoo/odoo@f292682

Since the field is used by OCA modules such as stock_putaway_product
(eg. to add a 'per_product' method), the new stock_putaway_method module
is added to restore this feature if needed.
@oca-transbot
OCA Transbot updated translations from Transifex
0a7755c
@carlosdauden
[FIX] stock_putaway_method: Fix travis
71e24b3
@oca-travis
[UPD] Update stock_putaway_method.pot
3679ec7
@OCA-git-bot
[ADD] icon.png
25260c3
@max3903
[12.0][MIG] stock_putaway_method
c54d60c
@bodedra bodedra force-pushed the 12.0-mig-stock_putaway_method branch from 1ccc781 to c54d60c Compare January 2, 2020 11:59
@bodedra
Copy link
Member

bodedra commented Jan 2, 2020

@max3903 Could you squash commits ?

@rousseldenis It's done. Thank you.

@max3903
Copy link
Sponsor Member Author

max3903 commented Jan 2, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-820-by-max3903-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 2, 2020
@OCA-git-bot
Merge PR #820 into 12.0
cd8c296 
Signed-off-by max3903
@OCA-git-bot OCA-git-bot merged commit c54d60c into OCA:12.0 Jan 2, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at df43102. Thanks a lot for contributing to OCA. ❤️

@bodedra bodedra deleted the 12.0-mig-stock_putaway_method branch January 3, 2020 17:19
@josepmy
Copy link

josepmy commented Jan 11, 2020

It's ready stock_putaway_method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikul-serpentcs nikul-serpentcs nikul-serpentcs left review comments

@bodedra bodedra bodedra approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@osi-scampbell osi-scampbell osi-scampbell approved these changes

Assignees

@max3903 max3903

Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet