[Alpha][13.0] Add stock_cubiscan #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
from
ffabef8
to
e7f58dc
Compare
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
2 times, most recently
from
677f940
to
5d54c06
Compare
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
from
5d54c06
to
d50dbd9
Compare
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
from
d50dbd9
to
0e9a7d7
Compare
simahawk
requested changes
Mar 20, 2020
stock_cubiscan/models/stock.py
Outdated
|
|
||
| class ProductPackaging(models.Model): | ||
| _inherit = "product.packaging" | ||
| # FIXME: move this in product_packaging_type |
There was a problem hiding this comment.
yes, it should be in this module IMO OCA/product-attribute#536
There was a problem hiding this comment.
can you update the comment w/ a link to https://github.com/OCA/product-attribute/tree/13.0/product_packaging_type ?
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
2 times, most recently
from
ad41bef
to
5b3d046
Compare
p-tombez
reviewed
Mar 20, 2020
jgrandguillaume
approved these changes
Mar 23, 2020
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
from
5b3d046
to
6a1daba
Compare
|
@p-tombez the dependency (OCA/web#1480) has been merged, I amended the last commit to trigger travis and runbot builds |
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
from
6a1daba
to
c411ae9
Compare
|
tests are 🔴 |
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
from
c411ae9
to
ba64ab5
Compare
* was using a link to product.template in the wizard instead of product.product * use product.packaging.type instead of the name of the packaging * update product_packaging_type from OCA * fix the numbe of digits of the volume
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
2 times, most recently
from
d840877
to
ed69537
Compare
|
@simahawk fixed |
simahawk
approved these changes
Mar 26, 2020
stock_cubiscan/models/stock.py
Outdated
|
|
||
| class ProductPackaging(models.Model): | ||
| _inherit = "product.packaging" | ||
| # FIXME: move this in product_packaging_type |
There was a problem hiding this comment.
can you update the comment w/ a link to https://github.com/OCA/product-attribute/tree/13.0/product_packaging_type ?
The module product_packaging_type creates a packaging type "Default Type" with sequence 1. In the test, the "unit" is created with sequence 1 too, which makes the ordering of the packagings in the test "test_cubiscan_measures" undeterministic. Note: "unit" should not be a packaging type, although the wizard should allow to change the width, length and weight of the product too.
guewen
force-pushed
the
13.0-add-stock_cubiscan
branch
from
ed69537
to
f9a146a
Compare
|
@simahawk yes, you are right, I amended the migration commit with your 2 remarks |
|
/ocabot merge |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at de625ae. Thanks a lot for contributing to OCA. ❤️ |
62 tasks
CarlosRoca13
pushed a commit
to Tecnativa/stock-logistics-warehouse
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cubiscan are dimensioners for cubing and weighing in
warehouses. This module implements the communication with the dimensioners as
well as a screen to measure and weight packaging of the products.