Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] stock_available_immediately: Migration to 12.0 #872

Merged
merged 21 commits into from Mar 25, 2020

Conversation

pedrobaeza
Copy link
Member

  • Standard procedure
  • README by fragments
  • Adapted test

cc @Tecnativa TT23032

nbessi and others added 21 commits March 19, 2020 17:30
(lp:c2c-addons/6.1  rev 28.1.10)
…PL-3 with author agreement, improved help messages and pep8

(lp:c2c-addons/6.1  rev 45.1.8)
[UPG] Upgraded to version 8, fixed references to new 8.0  views and  moved fields that were in  product.product to product.template

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[UPG] stock available immediately, corrected the calculation method of
immediately_usable_qty to take in accountthe sign change in outgoing_qty
(from negative to positive) in version 8.

[FLAKE8]

[FIX] renaming of a class, comment removing, useless code.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.
Generic module to compute the stock quantity available to promise using several implementations.
stock_available_immediatly is changed to become the first optional implementation.
Cherry pick of commit 0b060f6 from the v7 branch

[IMP] stock_available* uses new API

[IMP] READMEs and TODOs

Cherry-picked from v7 at 8add4be

Conflicts:
	__unported__/stock_available_mrp/__openerp__.py
	stock_available/__openerp__.py
	stock_available_immediately/__openerp__.py
…uct and

product.template, now takes in account variants and correctly displays value.
[FLAKE8]

Removing duplicate modules and moving README.rst into __unported__
* fix the dependencies for the computed field

* use api.multi instead of api.one to avoid calling
  super()._immediately_usable_qty in a loop (this improves perfs on a tree view
  display)
There are cases where we dot NOT want to simply sum the quantities of all the
variants. For example when dealing with manufacturing capacities, we may have
to chose between variants because we can't make ALL of them with the same
components.

So instead of a simple non-modular implementation, we'll let each module define
his own implementation of how to compute the product template's quantity
available for sale.

Conflicts:
	stock_available/__openerp__.py
	stock_available_immediately/__openerp__.py
optimize stock computation by avoiding to call useless compute
Due to merge mess, we need to restore current code this way
* New README by fragments
* Bump manifest version
* Adapted tests
@pedrobaeza pedrobaeza added this to the 12.0 milestone Mar 19, 2020
@pedrobaeza
Copy link
Member Author

@sergio-teruel @ernestotejeda can you please review?

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 19, 2020
54 tasks
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-872-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 24, 2020
Signed-off-by pedrobaeza
@pedrobaeza
Copy link
Member Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-872-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 42ae9c5 into OCA:12.0 Mar 25, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 24edc26. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet