[12.0][MIG] stock_inventory_revaluation #894

matt454357 · 2020-04-28T15:02:59Z

Migration from 10.0 to 12.0

CasVissers-360ERP

Initial functional review for AVCO costing, will do FiFo later.

sale_stock_info_popup/README.rst

stock_inventory_revaluation/README.rst

stock_inventory_revaluation/models/stock_inventory_revaluation.py

CasVissers-360ERP · 2020-04-29T06:13:29Z

I think a nice addition would be a new revaluation type "Based on Template", in which the stock user can choose for example repair or modification as template and stock accounts are automatically loaded. This allows a user without accounting knowledge to do revaluations.

matt454357 · 2020-04-29T16:27:08Z

@CasVissers,
Adding a template model is a great idea, not only for users without accounting knowledge, but also for automating revaluations from other modules.

Making it a revaluation type doesn't make sense to me. The revaluation types should be mutually exclusive. After choosing a template, we still need to know whether this is a Unit Price Change, or a Total Value Change. I think I would make the revaluation type another field on the template.

rousseldenis · 2020-04-30T09:48:02Z

stock_inventory_revaluation/views/stock_inventory_revaluation_view.xml

@@ -113,7 +113,7 @@
                    <field name="name"/>
                    <field name="revaluation_type"/>
                    <field name="document_date"/>
-                    <field name="user_id"/>
+                    <field name="create_uid"/>


@JordiBForgeFlow Do you have an advice on this ? Why did you use a specific field for this ?

@rousseldenis, @JordiBForgeFlow, Can we go ahead, and merge this PR? This is the only unresolved comment.

matt454357 · 2020-05-04T20:39:54Z

Still getting flake8 FAIL. It passes flake8 tests locally. Other PRs are passing the flake8 test. Can someone help me understand why mine is failing?

CasVissers-360ERP · 2020-05-11T13:45:29Z

@matt454357 Nice work on the template functionality!

Added one minor remark about new_value which should be readonly when posted.

For the decimal rounding in the value change I'm not sure yet. I understand the issue, but the current workflow implies that the value will be updated to the entered value. It will be confusing for end-users.

The only solution I have for now is to add a price difference or rounding difference account which is used to book the difference. This gives the user more flexibility and also explains and warns for possible rounding issues. What do you think?

matt454357 · 2020-05-12T03:09:38Z

@CasVissers thanks for all the feedback.

I made new_value readonly, as you suggested.

For the decimal rounding, I noted the behavior in some field help attributes. I also added some info to the list of known issues. The issue seems to have been present in previous versions, so I don't feel bad about leaving it.

stock_inventory_revaluation/__manifest__.py

rousseldenis

Minor remark. Apart of that, seems great

…ventory revaluation, instead of directly posting the journal entries.

…proper traceability

…s been posted.

… quants with real method

CasVissers-360ERP

LGTM. Even-though I would have liked a better flow for rounding differences when updating the stock value. I think this is still confusing for end-users.

OCA-git-bot · 2020-05-18T12:00:03Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

matt454357 · 2020-05-27T16:09:01Z

@rousseldenis, @CasVissers, @pedrobaeza,
Is there something else I need to do, or can this be merged?

pedrobaeza · 2020-05-27T16:12:27Z

I let @rousseldenis to merge as I'm not a qualified reviewer for this module and he has merge rights.

HaraldPanten

Seems to be OK

CasVissers-360ERP · 2020-06-09T07:20:51Z

@rousseldenis
Think this one can be merged?

rousseldenis · 2020-06-24T10:45:32Z

/ocabot merge patch

OCA-git-bot · 2020-06-24T10:45:51Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-894-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot · 2020-06-24T11:51:46Z

Congratulations, your PR was merged at f588433. Thanks a lot for contributing to OCA. ❤️

dreispt · 2021-03-09T14:37:07Z

/ocabot merge nobump

OCA-git-bot · 2021-03-09T14:37:15Z

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-894-by-dreispt-bump-nobump, awaiting test results.

matt454357 changed the title ~~12.0 mig stock inventory revaluation~~ [12.0][MIG] stock_inventory_revaluation Apr 28, 2020

rousseldenis added migration needs review labels Apr 28, 2020

rousseldenis added this to the 12.0 milestone Apr 28, 2020

OCA-git-bot mentioned this pull request Apr 28, 2020

Migration to version 12.0 #487

Closed

54 tasks

matt454357 mentioned this pull request Apr 28, 2020

[11.0][MIG]stock_inventory_revaluation #881

Closed

CasVissers-360ERP suggested changes Apr 29, 2020

View reviewed changes

rousseldenis reviewed Apr 30, 2020

View reviewed changes

matt454357 requested review from pedrobaeza and rousseldenis May 12, 2020 22:46

rousseldenis reviewed May 13, 2020

View reviewed changes

stock_inventory_revaluation/__manifest__.py Outdated Show resolved Hide resolved

rousseldenis approved these changes May 13, 2020

View reviewed changes

JordiBForgeFlow and others added 13 commits May 13, 2020 06:32

stock_inventory_revaluation

5fcf4ea

refactoring of the module to simplify

135d047

various fixes as per peer review

df8923c

The button to change standard price in product form now creates an in…

ef0af1c

…ventory revaluation, instead of directly posting the journal entries.

add the user that created the inventory revaluation, so that there's …

3b50c7f

…proper traceability

flake8 fix

7459a65

Migrated stock_inventory_revaluation module to v9.

d883405

test coverage

663977c

OCA Transbot updated translations from Transifex

a1d852e

[MIG] stock_inventory_revaluation: Migration to 10.0

1341ed2

[FIX] it should be possible to delete quants after the revaluation ha…

4c8d84f

…s been posted.

[ADD] Dutch translations

a7bca74

fixes permissions error when cancelling an inventory revaluation

e593cc0

MiquelRForgeFlow and others added 10 commits May 13, 2020 06:32

[FIX] Restrict button_cancel

196b36d

[DEL] old migration scripts

0b69615

[FIX] Comments

9d27707

[FIX] Precisions

c9fca9f

OCA Transbot updated translations from Transifex

a095ac9

OCA Transbot updated translations from Transifex

4366b87

OCA Transbot updated translations from Transifex

b15ef2c

[UPD] Update stock_inventory_revaluation.pot

e525dc4

[10.0][FIX] stock_inventory_revaluation: unable to revaluate multiple…

048f6e6

… quants with real method

[MIG] stock_inventory_revaluation: Migration to 12.0

50f3dde

CasVissers-360ERP approved these changes May 18, 2020

View reviewed changes

OCA-git-bot added approved ready to merge labels May 18, 2020

HaraldPanten approved these changes May 28, 2020

View reviewed changes

AaronHForgeFlow mentioned this pull request Jun 5, 2020

[12.0][MIG]stock_valuation_account_manual_adjustment #915

Closed

1 task

OCA-git-bot added the bot is merging ⏳ label Jun 24, 2020

marcelsavegnago approved these changes Jun 24, 2020

View reviewed changes

OCA-git-bot merged commit fe00950 into OCA:12.0 Jun 24, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 24, 2020

OCA-git-bot added the bot is merging ⏳ label Mar 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] stock_inventory_revaluation #894

[12.0][MIG] stock_inventory_revaluation #894

matt454357 commented Apr 28, 2020

CasVissers-360ERP left a comment

CasVissers-360ERP commented Apr 29, 2020 •

edited

matt454357 commented Apr 29, 2020

rousseldenis Apr 30, 2020

matt454357 May 12, 2020

matt454357 commented May 4, 2020

CasVissers-360ERP commented May 11, 2020

matt454357 commented May 12, 2020

rousseldenis left a comment

CasVissers-360ERP left a comment

OCA-git-bot commented May 18, 2020

matt454357 commented May 27, 2020

pedrobaeza commented May 27, 2020

HaraldPanten left a comment

CasVissers-360ERP commented Jun 9, 2020

rousseldenis commented Jun 24, 2020

OCA-git-bot commented Jun 24, 2020

OCA-git-bot commented Jun 24, 2020

dreispt commented Mar 9, 2021

OCA-git-bot commented Mar 9, 2021

[12.0][MIG] stock_inventory_revaluation #894

[12.0][MIG] stock_inventory_revaluation #894

Conversation

matt454357 commented Apr 28, 2020

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

CasVissers-360ERP commented Apr 29, 2020 • edited

matt454357 commented Apr 29, 2020

rousseldenis Apr 30, 2020

Choose a reason for hiding this comment

matt454357 May 12, 2020

Choose a reason for hiding this comment

matt454357 commented May 4, 2020

CasVissers-360ERP commented May 11, 2020

matt454357 commented May 12, 2020

rousseldenis left a comment

Choose a reason for hiding this comment

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

OCA-git-bot commented May 18, 2020

matt454357 commented May 27, 2020

pedrobaeza commented May 27, 2020

HaraldPanten left a comment

Choose a reason for hiding this comment

CasVissers-360ERP commented Jun 9, 2020

rousseldenis commented Jun 24, 2020

OCA-git-bot commented Jun 24, 2020

OCA-git-bot commented Jun 24, 2020

dreispt commented Mar 9, 2021

OCA-git-bot commented Mar 9, 2021

CasVissers-360ERP commented Apr 29, 2020 •

edited