[14.0][MIG] stock_move_backdating #1494

toita86 · 2024-01-30T15:59:12Z

No description provided.

…l.picking

use sudo: false to enable container build use cache: pip to cache pip packages

… method _create_account_move_line [FIX] upgrade quant_ids date in a single call

francesco-ooops

Functional ok!

OCA-git-bot · 2024-03-18T10:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

francesco-ooops · 2024-03-20T09:44:24Z

@rousseldenis good to go? thanks!

rousseldenis

Code review

rousseldenis · 2024-03-20T09:49:36Z

stock_move_backdating/models/stock_inventory.py

@@ -21,7 +21,7 @@ def onchange_date_backdating(self):
        check_date(self.date_backdating)

    def post_inventory(self):
-        no_backdate_inventories = self.env["stock.inventory"].browse()
+        no_backdate_inventories = self.env["stock.inventory"]


@toita86 The former writing was the good one.

Why is it? We get the same result

Yes, but formally this is better as instance is not really the same as a browse record set. Nevertheless, this one is not blocking

Thank you for the review, I implemented almost all the changes you suggested.

stock_move_backdating/models/stock_inventory_line.py

stock_move_backdating/models/stock_move.py

rousseldenis · 2024-03-20T09:53:53Z

stock_move_backdating/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_fill_date_backdating,access_fill_date_backdating,model_fill_date_backdating,base.group_user,1,0,0,0


Shouldn't it be stock.group_stock_user instead ?

aleuffre · 2024-03-22T16:44:19Z

stock_move_backdating/models/stock_picking.py

+    # Disable pylint to match the exact signature in super
+    # pylint: disable=dangerous-default-value


chore: these two lines can be removed, it's no longer necessary to disable pylint

stock_move_backdating/models/stock_move.py

francesco-ooops · 2024-03-26T10:22:29Z

@newtratip could you take a look? thanks!

aleuffre

Code review, LGTM

francesco-ooops · 2024-03-29T15:55:56Z

@rousseldenis ready for your review, thanks!

francesco-ooops · 2024-04-03T07:55:10Z

@rousseldenis good for merge?

rousseldenis · 2024-04-03T07:57:11Z

/ocabot merge patch

OCA-git-bot · 2024-04-03T07:57:22Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1494-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot · 2024-04-03T08:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-04-03T08:09:40Z

@rousseldenis The merge process could not be finalized, because command twine upload --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo14_addon_stock_move_backdating-14.0.1.0.1-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo14_addon_stock_move_backdating-14.0.1.0.1-py3-none-any.whl
�[?25l
�[2K�[35m  0%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m0.0/67.5 kB�[0m • �[36m--:--�[0m • �[31m?�[0m
�[2K�[35m  0%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m0.0/67.5 kB�[0m • �[36m--:--�[0m • �[31m?�[0m
�[2K�[35m  0%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m0.0/67.5 kB�[0m • �[36m--:--�[0m • �[31m?�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m67.5/67.5 kB�[0m • �[33m00:00�[0m • �[31m35.7 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m67.5/67.5 kB�[0m • �[33m00:00�[0m • �[31m35.7 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m67.5/67.5 kB�[0m • �[33m00:00�[0m • �[31m35.7 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m67.5/67.5 kB�[0m • �[33m00:00�[0m • �[31m35.7 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m67.5/67.5 kB�[0m • �[33m00:00�[0m • �[31m35.7 MB/s�[0m
�[?25h�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/          
         The user 'OCA' isn't allowed to upload to project                      
         'odoo14-addon-stock-move-backdating'. See                              
         https://pypi.org/help/#project-name for more information.

tafaRU and others added 30 commits January 30, 2024 15:23

[ADD] stock_move_backdating

a2a60b1

[FIX]stock_move_backdating: stock_view.xml

de22441

[FIX] authors

096971b

[REF] stock_partial_picking_line

278060f

[FIX] changed view

645314a

[imp] use back date for accounting

50f5243

[imp] orm.Model

2538333

[imp] use move date and related period

c78d602

[add] missing account.py

41650cc

[FIX] stock_partial_picking_line

0469fcd

[ADD] override to _partial_move_for and to do_partial in stock.partia…

d2b0178

…l.picking

[fix] wrong create return value

842d750

[FIX] remove pdb

19f5db8

[ADD] AUTHORS and copyright

ef6dbfe

[ADD] mail address to AUTHORS.txt

ce1f027

[FIX] PEP 8 and OpenERP syntax compliance

f278e29

[FIX] using right date: move.date_backdating

cc8307f

[FIX]replaced m by move and avoid extra spaces

c69464f

[FIX] when move.date_backdating is not set

4df3364

[IMP] stock_move_backdating and stock_picking_invoice_link descriptions

fc4302a

mark unported module as uninstallable

e5b22f4

[MOV] move addons out of __unported__ (they remain not installable)

4e49260

[MIG] Rename manifest files

c3983cb

Update travis configuration

bdd0887

use sudo: false to enable container build use cache: pip to cache pip packages

porting of the module [FIX] tests [FIX] translation

bd7c683

update quants date [FIX] test

69a3a0c

FIX when using module with user != admin. Test added

b8cfc48

README [FIX] Travis.yaml [FIX] rebased with 8.0

e339a74

author

043d956

Wizard date comparison [RM] useless inheritance class stock_quant and…

ef0082b

… method _create_account_move_line [FIX] upgrade quant_ids date in a single call

francesco-ooops approved these changes Mar 18, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 18, 2024

rousseldenis requested changes Mar 20, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Mar 20, 2024

toita86 force-pushed the 14.0-mig-stock_move_backdating branch 2 times, most recently from e5731fc to 8a49d4e Compare March 22, 2024 17:24

toita86 mentioned this pull request Mar 22, 2024

[14.0][ENH] stock_move_backdating toita86/stock-logistics-workflow#1

Open

aleuffre reviewed Mar 25, 2024

View reviewed changes

[MIG] stock_move_backdating: Migration to 14.0

705ce77

toita86 force-pushed the 14.0-mig-stock_move_backdating branch from 8a49d4e to 705ce77 Compare March 25, 2024 14:20

rousseldenis added needs review migration labels Mar 25, 2024

aleuffre approved these changes Mar 29, 2024

View reviewed changes

rousseldenis approved these changes Apr 3, 2024

View reviewed changes

OCA-git-bot added the approved label Apr 3, 2024

OCA-git-bot added bot is merging ⏳ ready to merge labels Apr 3, 2024

OCA-git-bot merged commit b09741e into OCA:14.0 Apr 3, 2024
11 checks passed

OCA-git-bot removed the bot is merging ⏳ label Apr 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] stock_move_backdating #1494

[14.0][MIG] stock_move_backdating #1494

toita86 commented Jan 30, 2024

francesco-ooops left a comment

OCA-git-bot commented Mar 18, 2024

francesco-ooops commented Mar 20, 2024

rousseldenis left a comment

rousseldenis Mar 20, 2024

PicchiSeba Mar 20, 2024 •

edited

rousseldenis Mar 20, 2024

toita86 Mar 22, 2024

rousseldenis Mar 20, 2024

aleuffre Mar 22, 2024

francesco-ooops commented Mar 26, 2024

aleuffre left a comment

francesco-ooops commented Mar 29, 2024

francesco-ooops commented Apr 3, 2024

rousseldenis commented Apr 3, 2024

OCA-git-bot commented Apr 3, 2024

OCA-git-bot commented Apr 3, 2024

OCA-git-bot commented Apr 3, 2024

		@@ -0,0 +1,2 @@
		id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
		access_fill_date_backdating,access_fill_date_backdating,model_fill_date_backdating,base.group_user,1,0,0,0

		# Disable pylint to match the exact signature in super
		# pylint: disable=dangerous-default-value

[14.0][MIG] stock_move_backdating #1494

[14.0][MIG] stock_move_backdating #1494

Conversation

toita86 commented Jan 30, 2024

francesco-ooops left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Mar 18, 2024

francesco-ooops commented Mar 20, 2024

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis Mar 20, 2024

Choose a reason for hiding this comment

PicchiSeba Mar 20, 2024 • edited

Choose a reason for hiding this comment

rousseldenis Mar 20, 2024

Choose a reason for hiding this comment

toita86 Mar 22, 2024

Choose a reason for hiding this comment

rousseldenis Mar 20, 2024

Choose a reason for hiding this comment

aleuffre Mar 22, 2024

Choose a reason for hiding this comment

francesco-ooops commented Mar 26, 2024

aleuffre left a comment

Choose a reason for hiding this comment

francesco-ooops commented Mar 29, 2024

francesco-ooops commented Apr 3, 2024

rousseldenis commented Apr 3, 2024

OCA-git-bot commented Apr 3, 2024

OCA-git-bot commented Apr 3, 2024

OCA-git-bot commented Apr 3, 2024

PicchiSeba Mar 20, 2024 •

edited