[ADD] Migrated stock_picking_line_sequence to v9. #262
Conversation
|
You should convert YML tests to Python ones, as they are deprecated |
|
|
||
| * stock_picking_reorder_lines (https://github.com/OCA/stock-logistics-workflow/) | ||
|
|
||
| Configuration |
|
|
||
| To install this module, you need to install its dependant module: | ||
|
|
||
| * stock_picking_reorder_lines (https://github.com/OCA/stock-logistics-workflow/) |
There was a problem hiding this comment.
This module is stock_picking_reorder_line, so there's no real dependency. Remove this.
| { | ||
| 'name': 'Stock picking lines with sequence number', | ||
| 'version': '8.0.0.1.0', | ||
| 'version': '9.0.1.0.1', |
There was a problem hiding this comment.
This is the first 9.0 version, so 9.0.1.0.0
| # | ||
| # | ||
| # © 2015 Eficent Business and IT Consulting Services S.L. - | ||
| # Jordi Ballester Alomar |
There was a problem hiding this comment.
Only one line per copyright, so remove this one
stock_picking_reorder_lines/stock.py
Outdated
| # | ||
| # | ||
| # © 2015 Eficent Business and IT Consulting Services S.L. - | ||
| # Jordi Ballester Alomar |
SerpentCS
changed the title
| @@ -13,7 +13,7 @@ | |||
| "Serpent CS, " | |||
| "Odoo Community Association (OCA)", | |||
| 'website': 'http://www.camptocamp.com', | |||
| 'depends': ['stock', 'sale', 'sale_stock'], | |||
There was a problem hiding this comment.
IMO, prefer explicit dependencies than implicit
|
@jbeficent I have made new changes, could you please review? |
| Installation | ||
| ============ | ||
|
|
||
| No specific installation requirements. |
There was a problem hiding this comment.
remove empty section.
| Configuration | ||
| ============= | ||
|
|
||
| No configuration is required. |
There was a problem hiding this comment.
remove empty section.
| # -*- coding: utf-8 -*- | ||
| # Copyright 2015 Camptocamp SA | ||
| # © 2015 Eficent Business and IT Consulting Services S.L. | ||
| # © 2015 Serpent Consulting Services Pvt. Ltd. |
There was a problem hiding this comment.
why 2015? is this that old?
| def write(self, values): | ||
| res = super(StockPicking, self).write(values) | ||
| for rec in self: | ||
| rec._reset_sequence() |
There was a problem hiding this comment.
IMO this makes no sense, the sequence is required to be kept to compare when invoicing or with the sale order (related lines will have same sequence number). If I change a minor thing in the picking the sequence is reset and the relation is lost.
|
@SerpentCS Hello, do you plan to achieve this PR ? |
|
@Cedric-Pigeon Okay Yes, we will resume working on this. |
|
Hi @darshan-serpent are you still planning to work on this one? |
|
Yes, this was closed because I accidentally diverged the branch and then I tried to reset it to the OCA, which took back all the commits and this PR was closed automatically. Maybe now I'll send a new one for the same. |
No description provided.